From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4CDC5A00C2; Fri, 24 Apr 2020 23:09:42 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AFDBB1D14A; Fri, 24 Apr 2020 23:09:41 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 3F0881C1CE for ; Fri, 24 Apr 2020 23:09:40 +0200 (CEST) IronPort-SDR: arCcX2qwUIUptvam7kyts6MndwPe3XJ9Yzov/8g1spfjZDSxsGA8hUrMqJpFfeuQbnIjIUpTcW 25G+MgJttjWQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2020 14:09:39 -0700 IronPort-SDR: lJxMZ++qq+WXLj77KBbOyAxLVuekXPDbvt2HjXApGFljgLbyXiLbLRuygagQbXka1zaK8YClWT 0rBXkNYshZig== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,313,1583222400"; d="scan'208";a="246726389" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga007.fm.intel.com with ESMTP; 24 Apr 2020 14:09:39 -0700 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 24 Apr 2020 14:09:39 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 24 Apr 2020 14:09:38 -0700 Received: from NAM04-SN1-obe.outbound.protection.outlook.com (104.47.44.57) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 24 Apr 2020 14:09:38 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Td0xeWCD2V/2KWwm3w2fdNIHUPf6oRPDXdqCY9cmOcA/sXVnfI0Asktk1vERICF+gLdgkCHQ3Yt6FTYPY6b6EvJV14UHj98A9yGcGGiVZqLvK7T/Qcoj3Etx69DXb84LbbX/prVsoonHcY4VaTG5XdRtx3TkfTj1PNZqm8w57K3F2uESKlhMUpnkBF9eVPpRxn5Z0ITaLM6kMCv4w9JxN1p6/REeHbG5nVniC8u8daBDcjwMhLm3lonewC4+wTdy6x6W+bC71SiGj1gepp+TmEjn4EgRZz3hHISLM5cR92hRyadQtUEL/Jgp+9WB+FXBUPO0pFmRIhodDlwL0b46IQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CnJgtj0o/vBPjOMC0HeWaJ5ca1gUVp8rcFTlJ7bXKzY=; b=M0FM+WQpPe7akDiWhEE0OtORsRNDRAJD9EbvuwT/njvLEi2OnZEatMW61Y+5krEkdKyLdm8Vz88QeKDdX1WLZ/cGDRw/T+o3mPtthIFRgqpaHN27jzr0gj2ri4+pJhtONOvhMJLEcWzreB/DQdYWxYYhbBAOZUw3+nD9e9a1Um+JPkmC3WCWjhGyi8gdQOHwfDWrzzq+zPeXV5ig5LKheWLlyFNfriub7KjDamnd2QJXlCynoxvEFj8qe4Hm7hPFtjs5rDYcUlNBKzIr/F8RlcYhUKLk0FSjGSrMiikB2W4cHZQOPgbqgQ7Bju2vna3oefwA/gqDihiNzeEductdpQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CnJgtj0o/vBPjOMC0HeWaJ5ca1gUVp8rcFTlJ7bXKzY=; b=X0BziRgUK8G7ZtulLIQiC51P5SqDMHArU519nvF9ViE4IcqHi7QhlRF9Z4ZCo23Ehm0/a/5MRzqZte9Z8zmvQ4xpxAanVyuT4nsGXNretaoHpxYO3X+Xh8X5TIAwBvmMv7zbkQ6VpoXaYKooORdPxASxYYvfGo2xsBW/ANE9VSQ= Received: from DM6PR11MB4593.namprd11.prod.outlook.com (2603:10b6:5:2a3::8) by DM6PR11MB3801.namprd11.prod.outlook.com (2603:10b6:5:136::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.13; Fri, 24 Apr 2020 21:09:36 +0000 Received: from DM6PR11MB4593.namprd11.prod.outlook.com ([fe80::acee:4fa2:2a9e:7cd6]) by DM6PR11MB4593.namprd11.prod.outlook.com ([fe80::acee:4fa2:2a9e:7cd6%3]) with mapi id 15.20.2937.020; Fri, 24 Apr 2020 21:09:36 +0000 From: "Wiles, Keith" To: "Power, Ciara" CC: dev , "Laatz, Kevin" , "Pattan, Reshma" , "jerinjacobk@gmail.com" , David Marchand , =?iso-8859-1?Q?Morten_Br=F8rup?= , "thomas@monjalon.net" Thread-Topic: [PATCH v4 00/18] update and simplify telemetry library. Thread-Index: AQHWGjiUDZmK5AkMJkCcLmtJreDAKqiIxN6A Date: Fri, 24 Apr 2020 21:09:36 +0000 Message-ID: <04150257-A7F9-4FB7-964C-280D836A1281@intel.com> References: <20200319171907.60891-1-ciara.power@intel.com> <20200424124159.45989-1-ciara.power@intel.com> In-Reply-To: <20200424124159.45989-1-ciara.power@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=keith.wiles@intel.com; x-originating-ip: [47.24.6.94] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f57441f9-e750-4ec1-eb49-08d7e893cb63 x-ms-traffictypediagnostic: DM6PR11MB3801: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-forefront-prvs: 03838E948C x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB4593.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(39860400002)(396003)(136003)(346002)(366004)(376002)(71200400001)(66446008)(66556008)(64756008)(186003)(2616005)(66946007)(4326008)(6862004)(76116006)(86362001)(966005)(66476007)(478600001)(26005)(8936002)(8676002)(33656002)(6486002)(6512007)(6506007)(54906003)(36756003)(316002)(15650500001)(53546011)(5660300002)(2906002)(81156014)(37006003)(6636002); DIR:OUT; SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: gJzjRavoPy0zOMiD0uABtdeBr+0PKsEMtJaOefdiv1TMbYhOiGv8AYvPmqFmuO2Z6dVR4K6+jCxZckPcb2s+lawaR7wHAk5KU2bdSTlWiQzzeB+owcdAKBg3OH5A+DIvkREs5eblxpmHKueJWQbhXmuDCh9HA3eMl0hksRLf0+CYoRsIbpxDm3B1T/2uX8Q+1btwQiuxbAPG1+zMgQmjxylNdP9fZVvomGTWSoWtfmI6CRxlgb+oXV2J74yA6so6ytKzmUGTNANvIwpMz6L8K0ySvXoqVRj+Cd+9zBkV2SpAPHIXvOWrA2Uao7jaLnNss4N0MWnNBbIRhag3Qz1Ej7E1SEwRg1s1cnyZC2dUJ+Im7/K/ep0Pdf+c5f8s3FY5eQ4nUX/zJWI4ADe5+dMWS45JcnCHqyRedGbuBD4biNXD+815T1NuJ1aNMqz04oeqWyiVmDUd7LeOW7Mt9JK6KBQ5nAXS07Ue7fA/Z42C93xCv63W5GL7ZRuU9QBTt9ttwmk55q/fLbjbDLGpZymvvw== x-ms-exchange-antispam-messagedata: HN2UiLWoigg8Pr3wmVXq1/WTytfVadWZIvzm5sNSdZb2C4aN/Sl8ZQSxYuMO2PIiyUplMX/amqJXo22fUdn7D7gfTE3c7u6eWJ5ga2vof+VBLecGx3knnqaFKkBSPIISAd8SLUUDRj5F6kEk0Sq84iRKo7VWasJjC1KdMABjaqh+clWBaylQC5mbXNMVbmpBQVbLiKjq9X79zNRLag+uncCf/yqTrjV8PmpkfB6nAHZYCUlhdwsJtJTeiU7I37ngQQBx9/mS4XI0A1QRgDN0YAXQpyV0cTTWrZYIVVOuaU4wMUoiR395r4INJlpCAhceqAByFZ34JoYn7Gk5Dhx1QcoPZbtavcOAdiVDSyCfP+tcj2QCycRzwEXHfyZbFW0ftd9vpUCzrPmTfcIeDc73A4d7GJQvo23rnDEJohtTizpDi4C2aiG6LBtrAGramU2Y13TIHDX8Dmw+13+uLJQL52edGBp0qQzw1ybnC+6VCDvHndxEUGPvEWXsFXScE6UYe0/lO/UbhEQec5eMwAhVdgrW65a5C3v6cMswN1rlendMJjjKqvpwyn2cGsKhWC6gN1IhvFMArQZRhx65iHZr9QI3+QKRqxC9Ny6PXGfjJGEWfxCk69dEygwve0Edi+dfbVhLU2/Q5/eZWEmiaraTzKyf6VvN03Oee/xweZv7mWegOLk5UoEn0OiGocUN7cArU+NTc6UugC9pdIdlMDwI2tyeQKaN0OeEczDNAhy32/18BnCQLAikhAbhWvyiakHt0Br7sjkIxg68EecmgGN7yPHWQqqxqCPLFw9SHg5l1LY= Content-Type: text/plain; charset="iso-8859-1" Content-ID: <81BA5E22DAC0D64E808164F3B831C436@namprd11.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: f57441f9-e750-4ec1-eb49-08d7e893cb63 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Apr 2020 21:09:36.4950 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6yD6jeYV7GJGT7tVsmUXujl2vwlb5Kv7Ke6hPKJY/W1W6BY2PmWGIfG1wd5emaOCVytvi7etg5EpI0brNd7T+A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3801 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v4 00/18] update and simplify telemetry library. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > On Apr 24, 2020, at 7:41 AM, Power, Ciara wrote: >=20 > v4: > - Internal representation now uses generic data format instead of JSON. > - Help command added to provide help text for a command. >=20 > v3: > - Removed rte_option as it is no longer used. > - General cleanup. >=20 > v2: > - Added JSON API, and unit tests, to simplify creation of valid json > responses from libraries. > - Added printing of basic info, including max output buffer size, app > PID and DPDK version on connection. > - Added /info command to report that basic info post-connect. This > replaces the eal version command from v1. > - Renamed stats to xstats in commands to allow a future generic > "stats" call. > - Added documentation, including updating existing howto and adding > programmers guide section and API docs. > - Added link status command for ethdev ports. > - Fixed windows builds. >=20 > This patchset extensively reworks the telemetry library adding new > functionality and simplifying much of the existing code, while > maintaining backward compatibility. >=20 > This work is based on the previously sent RFC for a "process info" > library: https://patchwork.dpdk.org/project/dpdk/list/?series=3D7741 > However, rather than creating a new library, this patchset takes > that work and merges it into the existing telemetry library, as > mentioned above. >=20 > The telemetry library as shipped in 19.11 is based upon the metrics > library and outputs all statistics based on that as a source. However, > this limits the telemetry output to only port-level statistics > information, rather than allowing it to be used as a general scheme for > telemetry information across all DPDK libraries. >=20 > With this patchset applied, rather than the telemetry library being > responsible for pulling ethdev stats and pushing them into the metrics > library for retrieval later, each library e.g. ethdev, rawdev, and even > the metrics library itself (for backwards compatiblity) now handle their > own stats. Any library or app can register a callback function with > telemetry, which will be called if requested by the client connected via > the telemetry socket. The callback function in the library/app then > formats its stats, or other data, into a generic data structure, and > returns it to telemetry to be sent to the client in JSON format. >=20 > To maintain backward compatibility, e.g. to allow the dpdk telemetry > collectd plugin to continue to work, some of the existing telemetry > code is kept, but is moved into the metrics library, and callbacks are > registered with telemetry for the legacy commands that were supported > previously. >=20 > The new version of the library, apart from the legacy interface support > for backward compatibility, does not have an external dependency on the > Jansson library, allowing the library to be enabled by default. >=20 > Note: In this version of the patchset, telemetry output is provided by > the ethdev, rawdev and eal libraries, but this may be expanded further > in later versions which are planned ahead of the merge deadline for > 20.05 >=20 > Bruce Richardson (8): > build: add arch-specific header path to global includes > telemetry: invert dependency on metrics > telemetry: add utility functions for creating json > telemetry: introduce new telemetry functionality > telemetry: add functions for returning callback data > usertools: add new telemetry python script > ethdev: add callback support for telemetry > eal: add eal telemetry callbacks >=20 > Ciara Power (10): > telemetry: move code to metrics for later reuse > metrics: reduce code taken from telemetry > telemetry: add default callback commands > rawdev: add callback support for telemetry > examples/l3fwd-power: enable use of new telemetry > telemetry: introduce telemetry backward compatibility > telemetry: remove existing telemetry files > lib: add telemetry as eal dependency > eal: remove rte-option infrastructure > doc: update telemetry documentation >=20 Looks good other than a few minor issues, which were sent to the list. Reviewed-by: Keith Wiles