From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D95C6A0C43; Thu, 30 Sep 2021 18:34:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A7DB7410EE; Thu, 30 Sep 2021 18:34:10 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id CCE9B40DDA; Thu, 30 Sep 2021 18:34:08 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10123"; a="310774379" X-IronPort-AV: E=Sophos;i="5.85,336,1624345200"; d="scan'208";a="310774379" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Sep 2021 09:33:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,336,1624345200"; d="scan'208";a="655956345" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga005.jf.intel.com with ESMTP; 30 Sep 2021 09:33:48 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 30 Sep 2021 09:33:47 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 30 Sep 2021 09:33:47 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 30 Sep 2021 09:33:47 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.109) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 30 Sep 2021 09:33:46 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bHOQ0TCUi7H2gzAKQ3aO8lbQyY6nLLggcWKnXZy2MMoSDKNv59C41SkT6srWRpwvyIWoxBlOeJR5dLq9u+uyuai+PV6dxPsPDgtjqprCTho8lcDf5pNOtqLtkLK5hjh+unTtnZC/sVZAsEiOPGMQkAHdv6cedvV/W4vH+lgy/HKYunDOuZ++qImk4vYgPSM+eLw2htd8Q0A4KmCQ8MRaZybDBZxIeCmNhzpV/Pw9qYvB4BV2lWC7RqJpkxp3uRIw8F5og5KFuu96lKLOimI2gmpT0z9HFBCFSgvtHPfnpf0mNDs0P+EKujQq/mAIW5LWGNDrE03B58+dGmhvAFe6Bg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=V1Knz0RwpkWml06UxSHcQSFYs3ijthLgocmVh2LL+f8=; b=U/PEhKrRpOgiZ/5vwWQoi0QaTLfuxqQlsmlNFesQd+hdC1NCWWTGjyQM6Zv+LufJcy/COGsUwnEL05lnGIoYAvNeSklicYGSKNh/JV43cnPTcqLuTS9cVIMtSCD3DW4nNiK652YhJ0Yd7KdF8sPpo6Goyvcv3KhMdv6Q3lc5JN7m8Ekqm0EABDq9Za1u95u3r8BpPXUUxDZU5IoKx+OJ0M8mFg03yrOoGMPX4+VZr5xWsD5AytPdvMbAPs9SGmZYw/VCRIAnpy8CCSej6QIy6Cql7KPM4aPgB9aMnHElFdgFpuCjQP2cuZMYDtI3AB3hYdo1e/3vpr/TPUPVGAG3wA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=V1Knz0RwpkWml06UxSHcQSFYs3ijthLgocmVh2LL+f8=; b=mVxNqjZ8kUSN3aXloiGvzXH0alI/WUHCDDnpVJ4lqYATguVmvn0bshGWuSP3vIoBw7ZKlXRsp4lC622ZsgKRaahWfDykJoIp7VRsuZH32srP5obkQMgJbHu2sE9dM1JS/STUi/PdTuz+nH+K0vS6rM7RCIYAZnhUzP7I6mLhVRg= Authentication-Results: xilinx.com; dkim=none (message not signed) header.d=none;xilinx.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4904.namprd11.prod.outlook.com (2603:10b6:510:40::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.16; Thu, 30 Sep 2021 16:33:44 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%5]) with mapi id 15.20.4544.021; Thu, 30 Sep 2021 16:33:44 +0000 To: Andrew Rybchenko , Thomas Monjalon , Kuba Kozak CC: , Ivan Ilchenko , , Andy Moreton References: <20210604144225.287678-1-andrew.rybchenko@oktetlabs.ru> <20210930160527.962319-1-andrew.rybchenko@oktetlabs.ru> <20210930160527.962319-3-andrew.rybchenko@oktetlabs.ru> From: Ferruh Yigit X-User: ferruhy Message-ID: <04199cac-141a-c292-df47-33f31fc7cd76@intel.com> Date: Thu, 30 Sep 2021 17:33:38 +0100 In-Reply-To: <20210930160527.962319-3-andrew.rybchenko@oktetlabs.ru> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB6PR0802CA0046.eurprd08.prod.outlook.com (2603:10a6:4:a3::32) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6PR0802CA0046.eurprd08.prod.outlook.com (2603:10a6:4:a3::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14 via Frontend Transport; Thu, 30 Sep 2021 16:33:42 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7962b8db-c8af-4f71-7d9e-08d9843011e6 X-MS-TrafficTypeDiagnostic: PH0PR11MB4904: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:854; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Gd7oz+2dc030ba6oG6l93DW7JR3M0+BZvxJssdJC/HWqlJsbjFRC2fKZrSVWq0VXlVCEyJaJa6JhIDrG/Amos7UEWfmPWwnjYufNnTC/wXDKUnYhpjTBs5pohUQPWAOWyBIAxUHLzqx4t8oVoLag5CkXqXAJ63ViTBl2wjmtTO7DQoNYVwhnID0H6p0m9/hbtd46ug9QoiSvgHGmZqzsH8q8rpslrJaiElfHGFHmyBCazejmlsrLUuAT09pMIjCxPzEHxBKK0SHxNynzoAygc5Pz3wJHv0qKABOi0V4hUXZllihVcDveRZtou72nU0wn0xOBOabxrEkpKw9OxqFq5Bg5KMP2LaPJmczkCAfyMy9snZhQs9LaSBG497+jSpqwoVb8b4TF65RExCI8iaDLN9ITyeojNlhOSxhwdyzXIo3V3Okx9ZyD6I/y9AxAMEw/T1QHMC9u3CxFvtG09hEDKfpvnQPmONSKaH+aaIbNxeiB5IGhmibHBVTy8NDKd3QSyboTzA04ThNLC+uVUvnkqFltdyHoXZMCUcLF/8NMEOgzQaC7EED7EGfbegy3pYF74xo+5yMuPV8LHnbcDkcJ2dP79O/hHmYtUKOKnEzR5207zdP8oFVS1ZJwa7hO43TmyghBmR32JmqK4iOIAPuyhJ2e8k6SNhFKFDmxU6M6Ds6zdgGJddCp8ktt57aVTviW2Oa4eJlfXKBXLh81+E1GqQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(53546011)(4326008)(31696002)(16576012)(6666004)(36756003)(2906002)(186003)(6486002)(54906003)(508600001)(66946007)(26005)(956004)(66556008)(44832011)(6636002)(31686004)(2616005)(83380400001)(8936002)(110136005)(8676002)(5660300002)(86362001)(66476007)(316002)(38100700002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?enRQaXdzVFE0Ump5dkJabVpMSS9ITFBrT0FXd05Mc05GUkxvNVdqUmg1di9u?= =?utf-8?B?TGtiT2FTSm5YWi9Ta2dtK3NObitzV0RVOHRaYmVDMVlYeThzM3RkU1BQdEt3?= =?utf-8?B?ajVYdllPSXpwcnVQQy9CUk9iZHdyajhzQ3QvMWFNd0RIV0hWY2hQckRaTm81?= =?utf-8?B?bzh3NnZlb2lTRDlzOEN3RkRFdk1KbjRXSHVqK05QNUpuU2VYS3Izd1U1eWYz?= =?utf-8?B?bmRzN3BmWmVRdXd2ajliSDM1Z1UrSmtQa0EvMVdxWU5pQzJwNzQzSWFaa0p0?= =?utf-8?B?Q0w2YjFBTDQ5NkFFMzhkY3gxM093MmFycFdDTk9CNVIrTThldVgxSklEUm9V?= =?utf-8?B?bkpGekJrd2NSeXI0UGVxVEM3clZNeENzYmJoYWl4cHhOeWU5UElLSVIwQ2xV?= =?utf-8?B?dmdOVlNjWTRmclhWT1RWc0o2Y2hVbjJVM3BLM0YzYXlUY283dnlDdWdzMS9r?= =?utf-8?B?cjhhdXVRVmJRVWNNemQyUDRwQkZoZlJ4TkQzSG1ucGpIQnVqSGVEeXZLeEdl?= =?utf-8?B?SFYyS2VSaU53NkhPdkVTZ240YVRuSUczVjdRL0NqTXJvQlFXS2FrekZRbmRs?= =?utf-8?B?eWZQUDJEekdBQytPUTFtaFUzWUdxbjIrajBHSFh2Y0JvNzVBZFdQRmxQS3lG?= =?utf-8?B?azBjVWNKdFdMMWdQS2hrR2Viam5RTko0WFRhSHZVR0plZHB4WC94cURUSHhw?= =?utf-8?B?TnhPQ3ZIOTJkc3A1akQrT1EvRHo5ZFM1MHlSa3cxZC81cmc0NlUrZ3o1M00v?= =?utf-8?B?a2pYRlpEakpoSkt0MVhHZmJVRzBicmpidGU1UEFGYnZDWEdnbkYzZmJ1MXJx?= =?utf-8?B?WExWZ0s4SVI3aFQxY2N1R2ZwOEROUXdGaWZaSHNPZW9VT0xMZW00anRYcDA4?= =?utf-8?B?VjI3UnBUMjRBTm5uVjhNWXJRUlFtVDNabm9sbGM0dmhyTWFjK0FwTGIxaEh0?= =?utf-8?B?RlJYNFhwK2Q4djcrT1pOV0Q3aGpPR2tudDBjbXNsL2lDdTkwTWJEQ1RlVHF1?= =?utf-8?B?ZDZDZmJMTGdtSnJmaGUxVmR4V2hQQ0tPejRYZjFqVXNOZENiRk94UEIxa21n?= =?utf-8?B?QzMyWFVxTUdvZ3g0d3lrZVNsZEFjTndUL2wxVkI0ckxTQmVXaVhHVnI4Z01s?= =?utf-8?B?K3JSa0RpN3podHdjMTMxbGxMNm9qaFVpUkMwdGJoTk1BS1RiaFBXN1dlTWo5?= =?utf-8?B?UUxHdlNJa0ZNZEk2bWtGTUNDR05jd252RUo3V2dlYytpajlXMUVMYjdRRzNq?= =?utf-8?B?TG5QTW0vSVZZWnc5U0dQZTl2YW1YYmZMOFA5QndEWWRncTgyb0lobEQ4WGtV?= =?utf-8?B?N1dxV3VnWWRMYXh6cG1lTnorUzZTZnp4bElySmsvV2tvc3RHQkxMYTBvejNB?= =?utf-8?B?L0p1ZkRuOEM5ZFFiaThFZ2hsVVE5Q2J1Z2JCSldqVTRZM2w0NTJmd010MDJM?= =?utf-8?B?K0xvSTRhLzY1a1UvMFd5dDRGS3c2YTNTZkttTlozT1pjRmJtN1lXZ1M5VFVi?= =?utf-8?B?bmNCZEJ0Mi9CNngvRWRwVTcrNE1FZlRpUzRBSGtZR0U5NDJreXdrZDIzTk1x?= =?utf-8?B?bUc3WU4xR2VQT3hLNkJIKzRMa2xlNklVd1FzUEMrc3FoanA4eXRuQlkzM0VT?= =?utf-8?B?S1FLeG4rbFcvOGZ4UGo2VDllVFRwZHdFZWdGNDF1cHJmNGcxbElkSGV4Mm9T?= =?utf-8?B?ZlBoa1daaHVrQXhQVStadHBoS3laREt3RkFSbkhCNFlEN3dudG03aVVRTFJa?= =?utf-8?Q?/9bqIwBJgos1BGzp38SCgRJ5uIX1oxdK+Lf3TcN?= X-MS-Exchange-CrossTenant-Network-Message-Id: 7962b8db-c8af-4f71-7d9e-08d9843011e6 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Sep 2021 16:33:44.4345 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YTj8If80TbQPV2KAd1F7rpjP10sMkelhuYt86ZgwEOM1D2HGityexwxuzDJSfPcLlq0z5rEmKCEHkIc19fihqQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4904 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v8 3/5] ethdev: fix docs of drivers callbacks getting xstats by IDs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/30/2021 5:05 PM, Andrew Rybchenko wrote: > From: Ivan Ilchenko > > Update xstats by IDs callbacks documentation in accordance with > ethdev usage of these callbacks. Document valid combinations of > input arguments to make driver implementation simpler. > > Fixes: 79c913a42f0 ("ethdev: retrieve xstats by ID") > Cc: stable@dpdk.org > > Signed-off-by: Ivan Ilchenko > Signed-off-by: Andrew Rybchenko > Reviewed-by: Andy Moreton > --- > lib/ethdev/ethdev_driver.h | 39 ++++++++++++++++++++++++++++++++++++-- > 1 file changed, 37 insertions(+), 2 deletions(-) > > diff --git a/lib/ethdev/ethdev_driver.h b/lib/ethdev/ethdev_driver.h > index cc2c75261c..74af878bb8 100644 > --- a/lib/ethdev/ethdev_driver.h > +++ b/lib/ethdev/ethdev_driver.h > @@ -183,11 +183,28 @@ typedef int (*eth_xstats_get_t)(struct rte_eth_dev *dev, > struct rte_eth_xstat *stats, unsigned int n); > /**< @internal Get extended stats of an Ethernet device. */ > > +/** > + * @internal > + * Get extended stats of an Ethernet device. > + * > + * @param dev > + * ethdev handle of port. > + * @param ids > + * IDs array to retrieve specific statistics. Must not be NULL. > + * @param values > + * A pointer to a table to be filled with device statistics values. > + * Must not be NULL. > + * @param n > + * Element count in @p ids and @p values. > + * > + * @return > + * - A number of filled in stats. > + * - A negative value on error. > + */ > typedef int (*eth_xstats_get_by_id_t)(struct rte_eth_dev *dev, > const uint64_t *ids, > uint64_t *values, > unsigned int n); > -/**< @internal Get extended stats of an Ethernet device. */ > > /** > * @internal > @@ -214,10 +231,28 @@ typedef int (*eth_xstats_get_names_t)(struct rte_eth_dev *dev, > struct rte_eth_xstat_name *xstats_names, unsigned int size); > /**< @internal Get names of extended stats of an Ethernet device. */ > > +/** > + * @internal > + * Get names of extended stats of an Ethernet device. > + * > + * @param dev > + * ethdev handle of port. > + * @param xstats_names > + * An rte_eth_xstat_name array of at least *size* elements to > + * be filled. Must not be NULL. > + * @param ids > + * IDs array to retrieve specific statistics. Must not be NULL. > + * @param size > + * Element count in @p ids and @p xstats_names. > + * > + * @return > + * - A number of filled in stats if both xstats_names and ids are not NULL. > + * - A number of available stats if both xstats_names and ids are NULL. > + * - A negative value on error. > + */ Isn't return also should be same with 'eth_xstats_get_by_id_t'?