From: Dongdong Liu <liudongdong3@huawei.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: <dev@dpdk.org>, <reshma.pattan@intel.com>, <thomas@monjalon.net>,
<ferruh.yigit@xilinx.com>, <andrew.rybchenko@oktetlabs.ru>,
"Min Hu (Connor)" <humin29@huawei.com>,
Maryam Tahhan <maryam.tahhan@intel.com>
Subject: Re: [PATCH v2 3/6] app/procinfo: add module info dump
Date: Wed, 21 Sep 2022 19:22:48 +0800 [thread overview]
Message-ID: <04273e59-7197-a05c-1985-e8a0a9e35686@huawei.com> (raw)
In-Reply-To: <20220920082229.17a642f4@hermes.local>
On 2022/9/20 23:22, Stephen Hemminger wrote:
> On Tue, 20 Sep 2022 18:51:44 +0800
> Dongdong Liu <liudongdong3@huawei.com> wrote:
>
>> +
>> + RTE_ETH_FOREACH_DEV(i) {
>> + /* Skip if port is not in mask */
>> + if ((enabled_port_mask & (1ul << i)) == 0)
>> + continue;
>> +
>> + if (!rte_eth_dev_is_valid_port(i))
>> + continue;
>
> There is no way RTE_ETH_FOREACH_DEV would iterate
> over an invalid port. If it did the macro would be seriously
> broken.
>
> That code is unnecessary.
Good point, will delete the code.
Thanks,
Dongdong
> .
>
next prev parent reply other threads:[~2022-09-21 11:22 UTC|newest]
Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-22 9:12 [PATCH 0/6] app/procinfo: add some extended features Dongdong Liu
2022-07-22 9:12 ` [PATCH 1/6] app/procinfo: add version dump Dongdong Liu
2022-09-19 9:23 ` Pattan, Reshma
2022-09-20 2:35 ` Dongdong Liu
2022-07-22 9:12 ` [PATCH 2/6] app/procinfo: add RSS RETA dump Dongdong Liu
2022-07-22 9:12 ` [PATCH 3/6] app/procinfo: add module info dump Dongdong Liu
2022-07-22 9:12 ` [PATCH 4/6] app/proc-info: add dump of Rx/Tx burst mode Dongdong Liu
2022-07-22 9:12 ` [PATCH 5/6] app/procinfo: fix some wrong doxygen syntax Dongdong Liu
2022-07-22 9:12 ` [PATCH 6/6] doc: add some extended features in procinfo guide Dongdong Liu
2022-07-22 10:03 ` [PATCH 0/6] app/procinfo: add some extended features David Marchand
2022-07-25 11:03 ` Dongdong Liu
2022-09-17 1:12 ` Dongdong Liu
2022-09-20 10:51 ` [PATCH v2 " Dongdong Liu
2022-09-20 10:51 ` [PATCH v2 1/6] app/procinfo: add version dump Dongdong Liu
2022-09-20 15:21 ` Stephen Hemminger
2022-09-21 11:11 ` Dongdong Liu
2022-09-20 10:51 ` [PATCH v2 2/6] app/procinfo: add RSS RETA dump Dongdong Liu
2022-09-20 15:24 ` Stephen Hemminger
2022-09-21 11:21 ` Dongdong Liu
2022-09-20 10:51 ` [PATCH v2 3/6] app/procinfo: add module info dump Dongdong Liu
2022-09-20 15:22 ` Stephen Hemminger
2022-09-21 11:22 ` Dongdong Liu [this message]
2022-09-20 10:51 ` [PATCH v2 4/6] app/proc-info: add dump of Rx/Tx burst mode Dongdong Liu
2022-09-20 10:51 ` [PATCH v2 5/6] app/procinfo: fix some wrong doxygen syntax Dongdong Liu
2022-09-20 10:51 ` [PATCH v2 6/6] doc: add some extended features in procinfo guide Dongdong Liu
2022-09-21 14:26 ` [PATCH v3 0/7] app/procinfo: add some extended features Dongdong Liu
2022-09-21 14:26 ` [PATCH v3 1/7] app/procinfo: add dpdk version dump Dongdong Liu
2022-09-23 9:11 ` Pattan, Reshma
2022-09-21 14:26 ` [PATCH v3 2/7] app/procinfo: add firmware " Dongdong Liu
2022-09-23 9:22 ` Pattan, Reshma
2022-09-24 8:03 ` Dongdong Liu
2022-09-21 14:26 ` [PATCH v3 3/7] app/procinfo: add RSS RETA dump Dongdong Liu
2022-09-23 9:42 ` Pattan, Reshma
2022-09-21 14:26 ` [PATCH v3 4/7] app/procinfo: add module info dump Dongdong Liu
2022-09-23 9:51 ` Pattan, Reshma
2022-09-24 8:07 ` Dongdong Liu
2022-09-21 14:26 ` [PATCH v3 5/7] app/procinfo: add dump of Rx/Tx burst mode Dongdong Liu
2022-09-23 10:02 ` Pattan, Reshma
2022-09-24 8:06 ` Dongdong Liu
2022-09-21 14:26 ` [PATCH v3 6/7] app/procinfo: fix some wrong doxygen syntax Dongdong Liu
2022-09-23 7:53 ` Pattan, Reshma
2022-09-24 8:12 ` Dongdong Liu
2022-09-21 14:26 ` [PATCH v3 7/7] doc: add some extended features in procinfo guide Dongdong Liu
2022-09-23 8:57 ` Pattan, Reshma
2022-09-24 8:13 ` [PATCH v7 0/7] app/procinfo: add some extended features Dongdong Liu
2022-09-24 8:13 ` [PATCH v7 1/7] app/procinfo: add dpdk version dump Dongdong Liu
2022-09-24 8:13 ` [PATCH v7 2/7] app/procinfo: add firmware " Dongdong Liu
2022-09-24 8:13 ` [PATCH v7 3/7] app/procinfo: add RSS RETA dump Dongdong Liu
2022-09-24 8:13 ` [PATCH v7 4/7] app/procinfo: add module eeprom info dump Dongdong Liu
2022-09-26 11:54 ` Pattan, Reshma
2022-09-24 8:13 ` [PATCH v7 5/7] app/procinfo: add dump of Rx/Tx burst mode Dongdong Liu
2022-09-24 8:13 ` [PATCH v7 6/7] app/procinfo: fix some wrong doxygen syntax Dongdong Liu
2022-09-26 12:09 ` Pattan, Reshma
2022-09-24 8:13 ` [PATCH v7 7/7] doc: add some extended features in procinfo guide Dongdong Liu
2022-09-24 8:21 ` [PATCH v7 0/7] app/procinfo: add some extended features Dongdong Liu
2022-10-08 9:39 ` [PATCH v8 0/8] " Dongdong Liu
2022-10-08 9:39 ` [PATCH v8 1/8] app/procinfo: add dpdk version dump Dongdong Liu
2022-10-08 9:39 ` [PATCH v8 2/8] app/procinfo: add firmware " Dongdong Liu
2022-10-08 9:39 ` [PATCH v8 3/8] app/procinfo: add RSS RETA dump Dongdong Liu
2022-10-08 9:39 ` [PATCH v8 4/8] app/procinfo: add module eeprom info dump Dongdong Liu
2022-10-08 9:39 ` [PATCH v8 5/8] app/procinfo: add dump of Rx/Tx burst mode Dongdong Liu
2022-10-08 9:39 ` [PATCH v8 6/8] app/procinfo: fix some wrong doxygen syntax Dongdong Liu
2022-10-08 9:39 ` [PATCH v8 7/8] app/procinfo: support descriptor dump Dongdong Liu
2022-10-08 9:39 ` [PATCH v8 8/8] doc: add some extended features in procinfo guide Dongdong Liu
2022-10-08 10:53 ` [PATCH v9 0/8] app/procinfo: add some extended features Dongdong Liu
2022-10-08 10:53 ` [PATCH v9 1/8] app/procinfo: add dpdk version dump Dongdong Liu
2022-10-08 10:53 ` [PATCH v9 2/8] app/procinfo: add firmware " Dongdong Liu
2022-10-08 10:53 ` [PATCH v9 3/8] app/procinfo: add RSS RETA dump Dongdong Liu
2022-10-08 10:53 ` [PATCH v9 4/8] app/procinfo: add module eeprom info dump Dongdong Liu
2022-10-08 10:53 ` [PATCH v9 5/8] app/procinfo: add dump of Rx/Tx burst mode Dongdong Liu
2022-10-08 10:53 ` [PATCH v9 6/8] app/procinfo: fix some wrong doxygen syntax Dongdong Liu
2022-10-08 10:53 ` [PATCH v9 7/8] app/procinfo: support descriptor dump Dongdong Liu
2022-10-10 9:08 ` Pattan, Reshma
2022-10-10 13:13 ` Dongdong Liu
2022-10-08 10:53 ` [PATCH v9 8/8] doc: add some extended features in procinfo guide Dongdong Liu
2022-10-11 11:18 ` [PATCH v10 0/8] app/procinfo: add some extended features Dongdong Liu
2022-10-11 11:18 ` [PATCH v10 1/8] app/procinfo: add dpdk version dump Dongdong Liu
2022-10-11 11:18 ` [PATCH v10 2/8] app/procinfo: add firmware " Dongdong Liu
2022-10-11 11:18 ` [PATCH v10 3/8] app/procinfo: add RSS RETA dump Dongdong Liu
2022-10-11 11:18 ` [PATCH v10 4/8] app/procinfo: add module eeprom info dump Dongdong Liu
2022-10-11 11:18 ` [PATCH v10 5/8] app/procinfo: add dump of Rx/Tx burst mode Dongdong Liu
2022-10-11 11:18 ` [PATCH v10 6/8] app/procinfo: fix some wrong doxygen syntax Dongdong Liu
2022-10-11 11:18 ` [PATCH v10 7/8] app/procinfo: support descriptor dump Dongdong Liu
2022-10-11 13:38 ` Pattan, Reshma
2022-10-11 11:18 ` [PATCH v10 8/8] doc: add some extended features in procinfo guide Dongdong Liu
2022-10-20 7:48 ` [PATCH v10 0/8] app/procinfo: add some extended features Dongdong Liu
2022-11-04 9:16 ` Dongdong Liu
2022-11-15 9:52 ` David Marchand
2022-11-15 11:00 ` Dongdong Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04273e59-7197-a05c-1985-e8a0a9e35686@huawei.com \
--to=liudongdong3@huawei.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@xilinx.com \
--cc=humin29@huawei.com \
--cc=maryam.tahhan@intel.com \
--cc=reshma.pattan@intel.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).