From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A3D97426D1; Fri, 6 Oct 2023 16:59:16 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5E645402C8; Fri, 6 Oct 2023 16:59:15 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 75CCB400D7 for ; Fri, 6 Oct 2023 16:59:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696604353; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LQP3hsgArVRpWIRU5Z7/FVBwB/jzfP2eSrpLsPF6Ee0=; b=fFCVdaOM0g0EDkzPfSkf6lUGHuAAXFpE/bhRZswFl+jIi90Up241ePSlZzETyE5rPdaH0q voYvfLiTePX8kqQJkduC95auChDzBD5cbwSUlldnDbthQR+WPWihhhaDgbnK9B5kLm5c11 zbUT7MhvRw09b2KkazJMV4Am38YLVeU= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-552-XluRfprzN-m7kmmPf8IORA-1; Fri, 06 Oct 2023 10:59:12 -0400 X-MC-Unique: XluRfprzN-m7kmmPf8IORA-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-40540179bcdso13950595e9.2 for ; Fri, 06 Oct 2023 07:59:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696604351; x=1697209151; h=content-transfer-encoding:in-reply-to:subject:from:references:cc:to :content-language:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=LQP3hsgArVRpWIRU5Z7/FVBwB/jzfP2eSrpLsPF6Ee0=; b=q1ghCbRAGMjJx7QdlVnd/utQY3zPhx+4DFc8dJiXQnPWyTxMgAop/LTbbRq531lICO YLt1bOmdYeO5iqFgxTGZuptm7tshKv16buvL6gK0cacPlzrL6UgYu3nBbF7sMrEJBMyg 8Xdc+agPaDA0DE544RSqEAcrVZTlamzxJCycZg7zdm/xu9uDDGIBs6BaduZUPGv76JHs eK5kigrHC2BlwlydNwrZi56ONj2JsQVJpu5ploGSYGKWXdJflWArMJM5AEMZyQhxu7Hx nlSnBf6e5xIx4VnsOpwmp30K9nQnGt5TESMX/FTaEX0Oow2mksErdtmjA4mzc+i9PSOQ t6og== X-Gm-Message-State: AOJu0YyOtnz7kIqQHsITiQBKHNqBBwSu57GFoE5d4zUIcoxJ+7O5H1CC NksPMJTNcgf3dK2VIY2Dl9RwbCTdN8dOC9uwqsX6reiJsTSH+YE6sXQYNzRdepRXjVsjnQHVMVd tMuw= X-Received: by 2002:a05:600c:c8b:b0:401:b2c7:34aa with SMTP id fj11-20020a05600c0c8b00b00401b2c734aamr8039119wmb.33.1696604351158; Fri, 06 Oct 2023 07:59:11 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEUomPUY9pgrpwcQqbaraLRpT4tcm+NFGc0QFpO5z72eCZOJGjR0EnIEGylt0LqVcZ5G+CWsQ== X-Received: by 2002:a05:600c:c8b:b0:401:b2c7:34aa with SMTP id fj11-20020a05600c0c8b00b00401b2c734aamr8039099wmb.33.1696604350821; Fri, 06 Oct 2023 07:59:10 -0700 (PDT) Received: from [192.168.0.36] ([78.19.74.205]) by smtp.gmail.com with ESMTPSA id e17-20020a05600c219100b0040646a708dasm3911587wme.15.2023.10.06.07.59.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Oct 2023 07:59:10 -0700 (PDT) Message-ID: <042a48be-b693-45f4-f4af-0c3a28b46a9b@redhat.com> Date: Fri, 6 Oct 2023 15:59:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 To: David Marchand , Stephen Hemminger Cc: dev@dpdk.org, Reshma Pattan , Quentin Armitage , Thomas Monjalon , Luca Boccassi , "Xueming(Steven) Li" , Christian Ehrhardt References: <20230921042349.104150-1-stephen@networkplumber.org> <20230921042349.104150-5-stephen@networkplumber.org> <20231004101325.5a7eefbe@hermes.local> From: Kevin Traynor Subject: Re: [PATCH 4/4] pcapng: move timestamp calculation into pdump In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 06/10/2023 10:10, David Marchand wrote: > On Wed, Oct 4, 2023 at 7:13 PM Stephen Hemminger > wrote: >> >> On Mon, 2 Oct 2023 10:15:25 +0200 >> David Marchand wrote: >> >>>> >>> >>> Bugzilla ID: 1291 ? >>> >>> This patch (and patch 3) updates some pcapng API, is it worth a RN update? >>> >>>> Fixes: c882eb544842 ("pcapng: fix timestamp wrapping in output files") >>> >>> Is it worth backporting? >>> I would say no, as some API update was needed to fix the issue. >>> But on the other hand, this is an experimental API, so I prefer to ask. >>> >>> >>>> Signed-off-by: Stephen Hemminger >> >> Good question. >> Is experimental API allowed to change in a stable release? > > I don't think this is cleary described in our ABI policy. > An experimental API may be changed at any time, but nothing is said > wrt backports. > > Breaking an API is always a pain, and for a LTS release it would > probably be badly accepted by users. > yes, I agree. IIRC, this arose sometime in the past with a branch that Luca was maintaining and I think the consensus among LTS maintainers was not to change experimental API on stable branches. > Cc: Kevin for his opinion. > > We may need a clarification on this topic in the doc. > > Perhaps it's not a "rule" since experimental API comes with no guarantee, but I can add something to the docs that it is a guideline not to break experimental API on stable branch.