* [dpdk-dev] [PATCH v1] net/tap: invoke probe finish for multiq failure
@ 2018-11-07 13:58 Vipin Varghese
2018-11-07 15:11 ` Wiles, Keith
0 siblings, 1 reply; 3+ messages in thread
From: Vipin Varghese @ 2018-11-07 13:58 UTC (permalink / raw)
To: dev, keith.wiles, ferruh.yigit; +Cc: amol.patel, Vipin Varghese
In scenarion for multiq or flowq setup failure rte_eth_dev_probing_finish
has to be invoked for successful device registration.
Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
---
---
drivers/net/tap/rte_eth_tap.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
index e7817e896..40911923d 100644
--- a/drivers/net/tap/rte_eth_tap.c
+++ b/drivers/net/tap/rte_eth_tap.c
@@ -1848,6 +1848,7 @@ eth_dev_tap_create(struct rte_vdev_device *vdev, char *tap_name,
TAP_LOG(ERR, "Remote feature requires flow support.");
goto error_exit;
}
+ rte_eth_dev_probing_finish(dev);
return 0;
error_remote:
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH v1] net/tap: invoke probe finish for multiq failure
2018-11-07 13:58 [dpdk-dev] [PATCH v1] net/tap: invoke probe finish for multiq failure Vipin Varghese
@ 2018-11-07 15:11 ` Wiles, Keith
2018-11-07 19:03 ` Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Wiles, Keith @ 2018-11-07 15:11 UTC (permalink / raw)
To: Varghese, Vipin; +Cc: dev, Yigit, Ferruh, Patel, Amol
> On Nov 7, 2018, at 1:58 PM, Varghese, Vipin <vipin.varghese@intel.com> wrote:
>
> In scenarion for multiq or flowq setup failure rte_eth_dev_probing_finish
> has to be invoked for successful device registration.
>
Acked-by: Keith Wiles <keith.wiles@intel.com>
> Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
> ---
> ---
> drivers/net/tap/rte_eth_tap.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
> index e7817e896..40911923d 100644
> --- a/drivers/net/tap/rte_eth_tap.c
> +++ b/drivers/net/tap/rte_eth_tap.c
> @@ -1848,6 +1848,7 @@ eth_dev_tap_create(struct rte_vdev_device *vdev, char *tap_name,
> TAP_LOG(ERR, "Remote feature requires flow support.");
> goto error_exit;
> }
> + rte_eth_dev_probing_finish(dev);
> return 0;
>
> error_remote:
> --
> 2.17.1
>
Regards,
Keith
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH v1] net/tap: invoke probe finish for multiq failure
2018-11-07 15:11 ` Wiles, Keith
@ 2018-11-07 19:03 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2018-11-07 19:03 UTC (permalink / raw)
To: Wiles, Keith, Varghese, Vipin; +Cc: dev, Patel, Amol
On 11/7/2018 3:11 PM, Wiles, Keith wrote:
>
>
>> On Nov 7, 2018, at 1:58 PM, Varghese, Vipin <vipin.varghese@intel.com> wrote:
>>
>> In scenarion for multiq or flowq setup failure rte_eth_dev_probing_finish
>> has to be invoked for successful device registration.
>>
>>
>> Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
>
> Acked-by: Keith Wiles <keith.wiles@intel.com>
Fixes: fbe90cdd776c ("ethdev: add probing finish function")
Cc: stable@dpdk.org
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-07 19:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-07 13:58 [dpdk-dev] [PATCH v1] net/tap: invoke probe finish for multiq failure Vipin Varghese
2018-11-07 15:11 ` Wiles, Keith
2018-11-07 19:03 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).