From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id E91474236B;
	Thu, 12 Oct 2023 05:04:34 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 6BC36402BA;
	Thu, 12 Oct 2023 05:04:34 +0200 (CEST)
Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])
 by mails.dpdk.org (Postfix) with ESMTP id 8A57D40279
 for <dev@dpdk.org>; Thu, 12 Oct 2023 05:04:33 +0200 (CEST)
Received: from dggpeml100024.china.huawei.com (unknown [172.30.72.56])
 by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4S5ZBp47s6zLqbW
 for <dev@dpdk.org>; Thu, 12 Oct 2023 11:00:34 +0800 (CST)
Received: from [10.67.121.161] (10.67.121.161) by
 dggpeml100024.china.huawei.com (7.185.36.115) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2507.31; Thu, 12 Oct 2023 11:04:30 +0800
Subject: Re: [PATCH v5 40/40] app/testpmd: add RSS hash algorithms display
To: Jie Hai <haijie1@huawei.com>, <dev@dpdk.org>, Aman Singh
 <aman.deep.singh@intel.com>, Yuying Zhang <yuying.zhang@intel.com>
CC: <lihuisong@huawei.com>, <liudongdong3@huawei.com>
References: <20230908080030.3837515-1-haijie1@huawei.com>
 <20231011092805.693171-1-haijie1@huawei.com>
 <20231011092805.693171-41-haijie1@huawei.com>
From: fengchengwen <fengchengwen@huawei.com>
Message-ID: <043d73eb-a6e5-46ee-bf88-d3356abd348b@huawei.com>
Date: Thu, 12 Oct 2023 11:04:30 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.11.0
MIME-Version: 1.0
In-Reply-To: <20231011092805.693171-41-haijie1@huawei.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.67.121.161]
X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To
 dggpeml100024.china.huawei.com (7.185.36.115)
X-CFilter-Loop: Reflected
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

Hi HaiJie,

On 2023/10/11 17:28, Jie Hai wrote:
> Add the command "show port X rss-hash algorithm" to display
> the RSS hash algorithms of port X. An example is shown:
> 
> testpmd> show port 0 rss-hash algorithm
> RSS algorithms:
>   toeplitz
> 
> Signed-off-by: Jie Hai <haijie1@huawei.com>
> ---
>  app/test-pmd/cmdline.c | 29 ++++++++++++++++++++++++-----
>  app/test-pmd/config.c  | 38 +++++++++++++++++++-------------------
>  app/test-pmd/testpmd.h |  2 +-
>  3 files changed, 44 insertions(+), 25 deletions(-)
> 
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
> index 679ca47b9401..d0eafd7f1254 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -174,8 +174,8 @@ static void cmd_help_long_parsed(void *parsed_result,
>  			" by masks on port X. size is used to indicate the"
>  			" hardware supported reta size\n\n"
>  
> -			"show port (port_id) rss-hash [key]\n"
> -			"    Display the RSS hash functions and RSS hash key of port\n\n"
> +			"show port (port_id) rss-hash [key | algorithm]\n"
> +			"    Display the RSS hash functions, RSS hash key and RSS hash algorithms of port\n\n"

Please update testpmd doc