DPDK patches and discussions
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Adrian Moreno <amorenoz@redhat.com>, dev@dpdk.org
Cc: tiwei.bie@intel.com, zhihong.wang@intel.com, huawei.xie@intel.com
Subject: Re: [dpdk-dev] [PATCH] vhost: Add dynamic logging system
Date: Thu, 9 Jan 2020 16:50:00 +0100	[thread overview]
Message-ID: <044fe113-82fe-d6b7-6d68-8cfc898046f2@redhat.com> (raw)
In-Reply-To: <283236ea-8d47-46d8-08ba-17aebcf607c5@redhat.com>



On 1/9/20 4:45 PM, Maxime Coquelin wrote:
> 
> 
> On 1/9/20 3:40 PM, Maxime Coquelin wrote:
>>
>>
>> On 12/4/19 4:07 PM, Adrian Moreno wrote:
>>> Currently there are a couple of limitations on the logging system: Most
>>> of the logs are compiled out and both datapath and controlpath logs
>>> share the same loglevel.
>>>
>>> This patch tries to help fix that situation by:
>>> - Splitting control plane and data plane logs
>>> - Making control plane logs dynamic while keeping data plane logs
>>> compiled out by default for log levels lower than the INFO.
>>>
>>> As a result, two macros are introduced:
>>> - VHOST_LOG_CONFIG(LEVEL, ...): Config path logging. Level can be
>>> dynamically controlled by "lib.vhost.config"
>>>
>>> - VHOST_LOG_DATA(LEVEL, ...): Data path logging. Level can be dynamically
>>> controlled by "lib.vhost.data". Every log macro with a level lower than
>>> RTE_LOG_DP_LEVEL (which defaults to RTE_LOG_INFO) will be compiled out.
>>>
>>> Signed-off-by: Adrian Moreno <amorenoz@redhat.com>
>>> Fixes: 1c01d52392d5 ("vhost: add debug print")
> 
> I propose to remove the Fixes line, as thinking at it again, it is more
> an improvement.
> 
> Also, I fixed the title to remove the upper case to "Add" so that it
> complies with the guidelines.
> 
> 
> Thanks,
> Maxime
> 
>>> Cc: huawei.xie@intel.com
>>> Cc: maxime.coquelin@redhat.com
>>> ---
>>>  lib/librte_vhost/iotlb.c      |  10 +-
>>>  lib/librte_vhost/socket.c     |  84 ++++++-------
>>>  lib/librte_vhost/vhost.c      |  34 ++++--
>>>  lib/librte_vhost/vhost.h      |  24 ++--
>>>  lib/librte_vhost/vhost_user.c | 218 +++++++++++++++++-----------------
>>>  lib/librte_vhost/virtio_net.c |  38 +++---
>>>  6 files changed, 214 insertions(+), 194 deletions(-)
>>>
>>
>> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>>
>> Thanks,
>> Maxime
>>

Applied to dpdk-next-virtio/master.

Thanks,
Maxime


  reply	other threads:[~2020-01-09 15:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-04 15:07 Adrian Moreno
2019-12-16  5:55 ` Tiwei Bie
2020-01-09 14:40 ` Maxime Coquelin
2020-01-09 15:45   ` Maxime Coquelin
2020-01-09 15:50     ` Maxime Coquelin [this message]
2020-01-09 16:36     ` Adrian Moreno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=044fe113-82fe-d6b7-6d68-8cfc898046f2@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=amorenoz@redhat.com \
    --cc=dev@dpdk.org \
    --cc=huawei.xie@intel.com \
    --cc=tiwei.bie@intel.com \
    --cc=zhihong.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).