From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 731D143C27; Fri, 8 Mar 2024 10:28:11 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 07B5840298; Fri, 8 Mar 2024 10:28:11 +0100 (CET) Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by mails.dpdk.org (Postfix) with ESMTP id BF98B40274 for ; Fri, 8 Mar 2024 10:28:08 +0100 (CET) Received: from mail.maildlp.com (unknown [172.19.162.254]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4TrglL2WKZzsWqM; Fri, 8 Mar 2024 17:26:06 +0800 (CST) Received: from kwepemd100004.china.huawei.com (unknown [7.221.188.31]) by mail.maildlp.com (Postfix) with ESMTPS id BD7EE18001C; Fri, 8 Mar 2024 17:28:06 +0800 (CST) Received: from [10.67.121.175] (10.67.121.175) by kwepemd100004.china.huawei.com (7.221.188.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.28; Fri, 8 Mar 2024 17:28:06 +0800 Message-ID: <0469d91d-658a-9ff9-ca3c-0a5f57bd9a1c@huawei.com> Date: Fri, 8 Mar 2024 17:28:05 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] net/hns3: support new device To: Ferruh Yigit , , Yisen Zhuang CC: , , References: <20240306092112.506493-1-haijie1@huawei.com> <72d40b88-0729-4aae-9fb5-fa84fb12ad79@amd.com> From: Jie Hai In-Reply-To: <72d40b88-0729-4aae-9fb5-fa84fb12ad79@amd.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.121.175] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemd100004.china.huawei.com (7.221.188.31) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2024/3/6 18:00, Ferruh Yigit wrote: > On 3/6/2024 9:21 AM, Jie Hai wrote: >> This patch adds new device to the driver. >> Hi, Ferruh, Thanks for your reivew. > > Just checking if a documentation update is rquired,hns3.rst has > following description, "network engine found in the HiSilicon Kunpeng > 920 SoC and Kunpeng 930 SoC", is this still holds with new device support? > The new device can be found on the latter SoC, which is HIP09 and HIP10. > Also you may want to update release notes to announce the new device > support. Yes, It will be updateed. > > Can you please give some more details in the commit log about the new > supported device, and if possible provide product links etc.. > OK. > > You may also request to backport this change to LTS (by adding stable > tag), assuming LTS code already supports these new devices. LTS > maintainers can decide to pick or not pick the patch to LTS release. > OK. >> Signed-off-by: Jie Hai >> --- >> drivers/net/hns3/hns3_cmd.c | 4 +++- >> drivers/net/hns3/hns3_ethdev.c | 2 ++ >> drivers/net/hns3/hns3_ethdev.h | 2 ++ >> 3 files changed, 7 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/net/hns3/hns3_cmd.c b/drivers/net/hns3/hns3_cmd.c >> index 2c1664485bef..001ff49b368b 100644 >> --- a/drivers/net/hns3/hns3_cmd.c >> +++ b/drivers/net/hns3/hns3_cmd.c >> @@ -545,7 +545,9 @@ hns3_set_dcb_capability(struct hns3_hw *hw) >> if (device_id == HNS3_DEV_ID_25GE_RDMA || >> device_id == HNS3_DEV_ID_50GE_RDMA || >> device_id == HNS3_DEV_ID_100G_RDMA_MACSEC || >> - device_id == HNS3_DEV_ID_200G_RDMA) >> + device_id == HNS3_DEV_ID_200G_RDMA || >> + device_id == HNS3_DEV_ID_100G_ROH || >> + device_id == HNS3_DEV_ID_200G_ROH) >> hns3_set_bit(hw->capability, HNS3_DEV_SUPPORT_DCB_B, 1); >> } >> >> diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c >> index b10d1216d2d1..9730b9a7e9f6 100644 >> --- a/drivers/net/hns3/hns3_ethdev.c >> +++ b/drivers/net/hns3/hns3_ethdev.c >> @@ -6649,6 +6649,8 @@ static const struct rte_pci_id pci_id_hns3_map[] = { >> { RTE_PCI_DEVICE(PCI_VENDOR_ID_HUAWEI, HNS3_DEV_ID_50GE_RDMA) }, >> { RTE_PCI_DEVICE(PCI_VENDOR_ID_HUAWEI, HNS3_DEV_ID_100G_RDMA_MACSEC) }, >> { RTE_PCI_DEVICE(PCI_VENDOR_ID_HUAWEI, HNS3_DEV_ID_200G_RDMA) }, >> + { RTE_PCI_DEVICE(PCI_VENDOR_ID_HUAWEI, HNS3_DEV_ID_100G_ROH) }, >> + { RTE_PCI_DEVICE(PCI_VENDOR_ID_HUAWEI, HNS3_DEV_ID_200G_ROH) }, >> { .vendor_id = 0, }, /* sentinel */ >> }; >> >> diff --git a/drivers/net/hns3/hns3_ethdev.h b/drivers/net/hns3/hns3_ethdev.h >> index 12d8299def39..e70c5fff2a45 100644 >> --- a/drivers/net/hns3/hns3_ethdev.h >> +++ b/drivers/net/hns3/hns3_ethdev.h >> @@ -28,7 +28,9 @@ >> #define HNS3_DEV_ID_25GE_RDMA 0xA222 >> #define HNS3_DEV_ID_50GE_RDMA 0xA224 >> #define HNS3_DEV_ID_100G_RDMA_MACSEC 0xA226 >> +#define HNS3_DEV_ID_100G_ROH 0xA227 >> #define HNS3_DEV_ID_200G_RDMA 0xA228 >> +#define HNS3_DEV_ID_200G_ROH 0xA22C >> #define HNS3_DEV_ID_100G_VF 0xA22E >> #define HNS3_DEV_ID_100G_RDMA_PFC_VF 0xA22F >> > > .