From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Stefan Baranoff <sbaranoff@gmail.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] Fwd: Memory Leak: PCAP TX to File
Date: Thu, 26 Oct 2017 17:24:01 -0700 [thread overview]
Message-ID: <046bab26-6128-f220-34e9-d5806976e47e@intel.com> (raw)
In-Reply-To: <CAHzKxpbykU5YfUbdkjt6s7N9a0d_4tpQJij0ek-yh-TNfVPqSA@mail.gmail.com>
On 10/26/2017 10:44 AM, Stefan Baranoff wrote:
> All,
>
> I think I've found a (very minor) memory leak in writing to a PCAP file. In
> drivers/net/pcap/rte_eth_pcap.c in open_single_tx_pcap around line 405 a
> pcap_t is allocated by pcap_open_dead but is never freed.
You are right.
> I see two obvious fixes:
> 1) Free the pcap_t immediately after either on pcap_dump_open success or
> failure
> 2) Set the pcap_t pointer internals->tx_queue[i]->tx->pcap so when the
> eth_dev_stop callback happens the pcap_t is freed.
Option 2 looks more proper, since eth_dev_stop() calls pcap_close() which frees
the pcap_t, so nothing special requires to cover the case,
But :),
open_single_tx_pcap() doesn't returns pcap_t back, so this function and
functions using this needs to be updated. I believe doesn't worth to this update
and as far as I can see freeing pcap_t immediately is safe,
So I would suggest lets go with option 1, it is simpler change.
Would you mind providing patch for this fix?
Thanks,
ferruh
>
> I believe the first is safe but am not a libpcap guru. Can someone please
> confirm this?
>
>
> Thanks,
> Stefan
>
prev parent reply other threads:[~2017-10-27 0:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAHzKxpb-d-naP+qJdG6DGa84z+DfcLSJkorH5K-j_+ebquOrDQ@mail.gmail.com>
2017-10-26 17:44 ` Stefan Baranoff
2017-10-26 21:56 ` Thomas Monjalon
2017-10-27 0:24 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=046bab26-6128-f220-34e9-d5806976e47e@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=sbaranoff@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).