From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from nbfkord-smmo02.seg.att.com (nbfkord-smmo02.seg.att.com [209.65.160.78]) by dpdk.org (Postfix) with ESMTP id D38695681 for ; Fri, 18 Nov 2016 17:50:41 +0100 (CET) Received: from unknown [193.34.186.16] (EHLO webmail.solarflare.com) by nbfkord-smmo02.seg.att.com(mxl_mta-7.2.4-7) with ESMTP id 1613f285.2b92b8686940.1433719.00-2497.3227157.nbfkord-smmo02.seg.att.com (envelope-from ); Fri, 18 Nov 2016 16:50:41 +0000 (UTC) X-MXL-Hash: 582f316101202bf7-948becfd3747be246c234b93e4b3b1440acc5e00 Received: from unknown [193.34.186.16] (EHLO webmail.solarflare.com) by nbfkord-smmo02.seg.att.com(mxl_mta-7.2.4-7) over TLS secured channel with ESMTP id e513f285.0.1433714.00-2370.3227146.nbfkord-smmo02.seg.att.com (envelope-from ); Fri, 18 Nov 2016 16:50:39 +0000 (UTC) X-MXL-Hash: 582f315f01324d10-45346940f96010da2348a56affeb93d4ba317799 Received: from [192.168.38.17] (84.52.89.52) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Fri, 18 Nov 2016 16:50:33 +0000 To: Thomas Monjalon References: <7987614.kmGMHz0qWb@xps13> <2de43e28-37f8-86f5-b45f-2e598137b3dc@solarflare.com> <1838661.tWJoShD1UF@xps13> CC: From: Andrew Rybchenko Message-ID: <048eabcf-7175-7500-88c4-ffeaa813c4a3@solarflare.com> Date: Fri, 18 Nov 2016 19:50:29 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [84.52.89.52] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.000.1202-22706.003 X-TM-AS-Result: No--13.919700-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-AnalysisOut: [v=2.1 cv=UI/baXry c=1 sm=1 tr=0 a=8P+NB+fYZDP74ap4g4d9Kw==] X-AnalysisOut: [:17 a=RB3BGLmKESwA:10 a=L24OOQBejmoA:10 a=NqsJdyEQX_EQFkDP] X-AnalysisOut: [XQsA:9 a=pILNOxqGKmIA:10 a=zRKbQ67AAAAA:8 a=1uRIz2DN5GPKxZ] X-AnalysisOut: [dFqLsA:9 a=CsCBa8SNz8gMKvtp:21 a=_W_S_7VecoQA:10 a=PA03WX8] X-AnalysisOut: [tBzeizutn5_OT:22] X-Spam: [F=0.2000000000; CM=0.500; S=0.200(2015072901)] X-MAIL-FROM: X-SOURCE-IP: [193.34.186.16] Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] Solarflare PMD submission question X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Nov 2016 16:50:42 -0000 On 10/28/2016 05:43 PM, Andrew Rybchenko wrote: > On 10/28/2016 03:33 PM, Thomas Monjalon wrote: >> 2016-10-28 13:50, Andrew Rybchenko: >>> The only thing which comes to my mind is to split libefx import on >>> subsystem >>> basis (few files per subsystem). It is artificial and added files will >>> be abandoned >>> until the patch which adds them into build. It could be something like: >>> 1. External interfaces definition >>> 2. Internal interfaces definition >>> 3. Registers definition (hardware interface) >>> 4. Management CPU interface definition (it is one file, but still >>> big >>> 650K) >>> 5. Management CPU interface implementation >>> and so on for NIC global controls, interrupts, event queue, transmit, >>> receive, >>> filtering etc. >> Yes it is artificial. >> The most valuable would be a transversal logical split, kind of feature >> per feature, in order to explain how the device works. > > I'm not the main author of the libefx and personally would consider it > very useful. > From the other hand I understand that it is a huge amount of work to > make it. > >> Such commit is also the opportunity to explain acronyms and so on. > > Good. We'll go this way and 'll do my best to make it useful to > understand > overall structure of the code and how the device works. Now we have a split of the base driver import in big feature steps. The base driver is split into 28 patches. Just only 1 patch exceeds 300K boundary (which add MCDI definitions header). Before submitting 56 patches I'd like to double-check that checkpatch.pl errors (for example, because of assignments in the 'if' condition, parenthesis around return value) is not a show-stopper for base driver import. Andrew.