From: Igor Ryzhov <iryzhov@nfware.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: Remy Horton <remy.horton@intel.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] rte_ether: Driver-specific stats getting overwritten
Date: Thu, 14 Jul 2016 16:51:49 +0300 [thread overview]
Message-ID: <04EE3350-421C-47F9-9D6F-A1D4992FD932@nfware.com> (raw)
In-Reply-To: <1954062.51W9tGj6hj@xps13>
Hello.
How about deleting rx_nombuf from rte_eth_stats?
Do you think this counter is necessary? It just shows enormous numbers in case of a lack of processing speed.
But we already have imissed counter which shows real number of packets, dropped for the same reason.
> 14 июля 2016 г., в 16:37, Thomas Monjalon <thomas.monjalon@6wind.com> написал(а):
>
> 2016-07-14 14:29, Remy Horton:
>> 'noon,
>>
>> In rte_eth_stats_get() after doing the driver callout to populate struct
>> rte_eth_stats, the rx_nombuf member is overwritten with
>> dev->data->rx_mbuf_alloc_failed even though some drivers will have
>> filled rx_nombuf with a value from elsewhere. This makes assignment of
>> rx_nombuf from within the driver callout redundant. Is this intentional?
>
> Yes it is strange and has always been like that.
> Why not moving the assignment before calling the driver callback?
next prev parent reply other threads:[~2016-07-14 13:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-14 13:29 Remy Horton
2016-07-14 13:37 ` Thomas Monjalon
2016-07-14 13:51 ` Igor Ryzhov [this message]
2016-07-14 15:50 ` Remy Horton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04EE3350-421C-47F9-9D6F-A1D4992FD932@nfware.com \
--to=iryzhov@nfware.com \
--cc=dev@dpdk.org \
--cc=remy.horton@intel.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).