From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f68.google.com (mail-lf0-f68.google.com [209.85.215.68]) by dpdk.org (Postfix) with ESMTP id 0F2E437A4 for ; Thu, 14 Jul 2016 15:51:51 +0200 (CEST) Received: by mail-lf0-f68.google.com with SMTP id 33so5430998lfw.3 for ; Thu, 14 Jul 2016 06:51:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nfware-com.20150623.gappssmtp.com; s=20150623; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=j9DUtyY3pBFjjwY1GtfdeJtC7ieopbHzTA2BuOQm8Ro=; b=Ant7yHhVQh09wvmiQQJ2y6qxnvJR0+gaq3oD16IHnBbDmebHROW5H2d9IMRyEbdzxP MnhxtsvWw6DlhwK4lkEEoNM8VkBNDYMDUxfPTv2AyLHZVtshbHEvlbk7HTHyBmxP9ZJY KRKJYxmx3ovLmbUmcuOy99M5uOZnGVAHqo9DXUKqtqljRzr138yXjokJSNTfTYI78h00 gDMrBzQq/LnmURbv9xRCAMpOkKkhoy6adj7rDnEe6AQiuzZhOgWSVeG3umsywHL0ZPiB Rxrf7n3Uyb5JboRM/jBs+GhymSKXsazGpknZnYn6Fush3vieq6eIMzWcneS4wIxJ1Sjj 8wbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=j9DUtyY3pBFjjwY1GtfdeJtC7ieopbHzTA2BuOQm8Ro=; b=l8S7dGS/yoyEvky2+MiCgl5JxzsGhL5d5TKp65NUyVuPagws6BMd3/zlIHehLs3L+R n96LxgYIDZMT/8O6n6o7806fV3c/oZw1aOADOd4kCniKbJZnaZhzaZTAp+Ng23mKbN3v 7SVv2HcKfhSnDc+pA4cAqUX4Mzm890Arv+GvUZeAQZybQQhlrv9tKRypYeVVwg8MEcsp hj2cMppL3vaBorF33MLDm+MR8HEjld9aIg72Uf1ziw+q6StTgyeXR51ZCEURZZd7ksLm 1SiRIUWtkqAyvjhLBswLBDa74rz4XQOuvHsr6JH/aVBzCDfqAldj07RlAMEHQsk17n9J DaYQ== X-Gm-Message-State: ALyK8tLzfyXqZOvJFFXuSwGbQvwx1uA3YX5Ip8Sgo6DR01Z5b8BG4t1NpWx8ezHy6NakEg== X-Received: by 10.25.33.134 with SMTP id h128mr6379670lfh.82.1468504310688; Thu, 14 Jul 2016 06:51:50 -0700 (PDT) Received: from [172.20.100.10] (vpn.arccn.ru. [95.182.74.2]) by smtp.gmail.com with ESMTPSA id 204sm761682ljf.6.2016.07.14.06.51.49 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 14 Jul 2016 06:51:50 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) From: Igor Ryzhov In-Reply-To: <1954062.51W9tGj6hj@xps13> Date: Thu, 14 Jul 2016 16:51:49 +0300 Cc: Remy Horton , dev@dpdk.org Content-Transfer-Encoding: quoted-printable Message-Id: <04EE3350-421C-47F9-9D6F-A1D4992FD932@nfware.com> References: <1195a38d-8615-03d2-22eb-04f6b071d38b@intel.com> <1954062.51W9tGj6hj@xps13> To: Thomas Monjalon X-Mailer: Apple Mail (2.3124) Subject: Re: [dpdk-dev] rte_ether: Driver-specific stats getting overwritten X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jul 2016 13:51:51 -0000 Hello. How about deleting rx_nombuf from rte_eth_stats? Do you think this counter is necessary? It just shows enormous numbers = in case of a lack of processing speed. But we already have imissed counter which shows real number of packets, = dropped for the same reason. > 14 =D0=B8=D1=8E=D0=BB=D1=8F 2016 =D0=B3., =D0=B2 16:37, Thomas = Monjalon =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0= =BB(=D0=B0): >=20 > 2016-07-14 14:29, Remy Horton: >> 'noon, >>=20 >> In rte_eth_stats_get() after doing the driver callout to populate = struct=20 >> rte_eth_stats, the rx_nombuf member is overwritten with=20 >> dev->data->rx_mbuf_alloc_failed even though some drivers will have=20 >> filled rx_nombuf with a value from elsewhere. This makes assignment = of=20 >> rx_nombuf from within the driver callout redundant. Is this = intentional? >=20 > Yes it is strange and has always been like that. > Why not moving the assignment before calling the driver callback?