From: Igor Russkikh <Igor.Russkikh@aquantia.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>,
"pbhagavatula@marvell.com" <pbhagavatula@marvell.com>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
Sachin Saxena <sachin.saxena@nxp.com>,
Akhil Goyal <akhil.goyal@nxp.com>,
Pavel Belous <Pavel.Belous@aquantia.com>,
Ravi Kumar <ravi1.kumar@amd.com>, Rasesh Mody <rmody@marvell.com>,
Shahed Shaikh <shshaikh@marvell.com>,
Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,
Marcin Wojtas <mw@semihalf.com>,
Michal Krawczyk <mk@semihalf.com>,
Guy Tzalik <gtzalik@amazon.com>,
Evgeny Schemeilin <evgenys@amazon.com>,
Igor Chauskin <igorch@amazon.com>,
John Daley <johndale@cisco.com>,
Hyong Youb Kim <hyonkim@cisco.com>,
"Wei Hu (Xavier)" <xavier.huwei@huawei.com>,
"Min Hu (Connor)" <humin29@huawei.com>,
Yisen Zhuang <yisen.zhuang@huawei.com>,
Beilei Xing <beilei.xing@intel.com>,
Qi Zhang <qi.z.zhang@intel.com>,
Jingjing Wu <jingjing.wu@intel.com>,
Wenzhuo Lu <wenzhuo.lu@intel.com>,
Qiming Yang <qiming.yang@intel.com>,
Alejandro Lucero <alejandro.lucero@netronome.com>,
Jerin Jacob <jerinj@marvell.com>,
Maciej Czekaj <mczekaj@marvell.com>,
Rosen Xu <rosen.xu@intel.com>,
Tianfei zhang <tianfei.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 2/3] drivers: use RTE_DIM instead of ARRAY_SIZE
Date: Fri, 11 Oct 2019 09:03:39 +0000 [thread overview]
Message-ID: <04a79fa3-b259-f7d2-dcde-23f599fc3a81@aquantia.com> (raw)
In-Reply-To: <50d82fa2-dc4f-e438-4617-4bd213ee65d5@solarflare.com>
>
> [snip]
>
>> drivers/net/sfc/base/ef10_ev.c | 4 +--
>> drivers/net/sfc/base/ef10_filter.c | 12 ++++----
>> drivers/net/sfc/base/ef10_mac.c | 18 +++++------
>> drivers/net/sfc/base/ef10_nic.c | 4 +--
>> drivers/net/sfc/base/ef10_nvram.c | 6 ++--
>> drivers/net/sfc/base/efx.h | 3 --
>> drivers/net/sfc/base/efx_port.c | 2 +-
>> drivers/net/sfc/base/efx_rx.c | 2 +-
>> drivers/net/sfc/base/siena_mac.c | 2 +-
>> drivers/net/sfc/base/siena_nic.c | 20 ++++++-------
>> drivers/net/sfc/base/siena_nvram.c | 6 ++--
>
> NACK
> No changes in net/sfc/base please. It is the base driver
> which is used on other platforms. So, it can't use DPDK
> specific macros.
>
Hi Pravan,
>
> drivers/net/atlantic/atl_hw_regs.h | 1 -
> drivers/net/atlantic/hw_atl/hw_atl_utils.c | 4 +--
> .../net/atlantic/hw_atl/hw_atl_utils_fw2x.c | 2 +-
We also tend to share these modules with linux and other codebases.
Less diffs we have to review is better.
Why not keep ARRAY_SIZE as a widely used compat alternative?
Regards,
Igor
next prev parent reply other threads:[~2019-10-11 9:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 4:07 [dpdk-dev] [PATCH 1/3] app/test: " pbhagavatula
2019-10-11 4:07 ` [dpdk-dev] [PATCH 2/3] drivers: " pbhagavatula
2019-10-11 4:37 ` Hemant Agrawal
2019-10-11 9:32 ` Ananyev, Konstantin
2019-10-11 13:48 ` Ferruh Yigit
2019-10-11 6:14 ` Andrew Rybchenko
2019-10-11 9:03 ` Igor Russkikh [this message]
2019-10-11 9:00 ` Hyong Youb Kim (hyonkim)
2019-10-11 4:07 ` [dpdk-dev] [PATCH 3/3] bitrate: " pbhagavatula
2019-10-11 14:20 ` [dpdk-dev] [PATCH 1/3] app/test: " Eads, Gage
2019-10-17 12:09 ` [dpdk-dev] [PATCH v2 1/2] " pbhagavatula
2019-10-17 12:10 ` [dpdk-dev] [PATCH v2 2/2] bitrate: " pbhagavatula
2019-10-27 13:36 ` David Marchand
2019-10-27 13:35 ` [dpdk-dev] [PATCH v2 1/2] app/test: " David Marchand
2019-10-14 6:58 [dpdk-dev] [PATCH 2/3] drivers: " Pavan Nikhilesh Bhagavatula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04a79fa3-b259-f7d2-dcde-23f599fc3a81@aquantia.com \
--to=igor.russkikh@aquantia.com \
--cc=Pavel.Belous@aquantia.com \
--cc=akhil.goyal@nxp.com \
--cc=alejandro.lucero@netronome.com \
--cc=arybchenko@solarflare.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=evgenys@amazon.com \
--cc=gtzalik@amazon.com \
--cc=hemant.agrawal@nxp.com \
--cc=humin29@huawei.com \
--cc=hyonkim@cisco.com \
--cc=igorch@amazon.com \
--cc=jerinj@marvell.com \
--cc=jingjing.wu@intel.com \
--cc=johndale@cisco.com \
--cc=mczekaj@marvell.com \
--cc=mk@semihalf.com \
--cc=mw@semihalf.com \
--cc=pbhagavatula@marvell.com \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=rahul.lakkireddy@chelsio.com \
--cc=ravi1.kumar@amd.com \
--cc=rmody@marvell.com \
--cc=rosen.xu@intel.com \
--cc=sachin.saxena@nxp.com \
--cc=shshaikh@marvell.com \
--cc=tianfei.zhang@intel.com \
--cc=wenzhuo.lu@intel.com \
--cc=xavier.huwei@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).