From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 63168A00C2; Wed, 22 Apr 2020 16:02:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4312D1D65E; Wed, 22 Apr 2020 16:02:48 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id AE5491D656 for ; Wed, 22 Apr 2020 16:02:45 +0200 (CEST) IronPort-SDR: xQIHNV5hHY4pRAlYcHMIzKQHWHTcAOrlEaeyHqulXmYmwjPVyjZqFlKOONi7GCcwm8l+O3Bu8A EQzGuDwnt1MQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2020 07:02:44 -0700 IronPort-SDR: U+CCRGbXcAz5zvufd9+KhaUXJLYftFBIVTOnd8pB5aSgxhL2ucwouQlFi1mQN5C48+OSTtnS7Q L/cpKVWuJGGw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,414,1580803200"; d="scan'208";a="300927441" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by FMSMGA003.fm.intel.com with ESMTP; 22 Apr 2020 07:02:44 -0700 Received: from shsmsx603.ccr.corp.intel.com (10.109.6.143) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 22 Apr 2020 07:02:44 -0700 Received: from shsmsx603.ccr.corp.intel.com (10.109.6.143) by SHSMSX603.ccr.corp.intel.com (10.109.6.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 22 Apr 2020 22:02:41 +0800 Received: from shsmsx603.ccr.corp.intel.com ([10.109.6.143]) by SHSMSX603.ccr.corp.intel.com ([10.109.6.143]) with mapi id 15.01.1713.004; Wed, 22 Apr 2020 22:02:41 +0800 From: "Wang, Haiyue" To: Thomas Monjalon CC: "dev@dpdk.org" , "Burakov, Anatoly" , "vattunuru@marvell.com" , "jerinj@marvell.com" , "alex.williamson@redhat.com" , "david.marchand@redhat.com" Thread-Topic: [PATCH v9 2/2] eal: support for VFIO-PCI VF token Thread-Index: AQHWGGTUzKFTW0qqkUmVaLlDu+RgaqiER7aAgADj8fA= Date: Wed, 22 Apr 2020 14:02:41 +0000 Message-ID: <04b0759780024eb29796fe23df085f92@intel.com> References: <20200305043311.17065-1-vattunuru@marvell.com> <20200422050804.66781-1-haiyue.wang@intel.com> <20200422050804.66781-3-haiyue.wang@intel.com> <3138550.usfYGdeWWP@thomas> In-Reply-To: <3138550.usfYGdeWWP@thomas> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v9 2/2] eal: support for VFIO-PCI VF token X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon > Sent: Wednesday, April 22, 2020 16:24 > To: Wang, Haiyue > Cc: dev@dpdk.org; Burakov, Anatoly ; vattunuru= @marvell.com; > jerinj@marvell.com; alex.williamson@redhat.com; david.marchand@redhat.com > Subject: Re: [PATCH v9 2/2] eal: support for VFIO-PCI VF token >=20 > 22/04/2020 07:08, Haiyue Wang: > > --- a/devtools/libabigail.abignore > > +++ b/devtools/libabigail.abignore > > +[suppress_function] > > + name =3D rte_vfio_setup_device >=20 > There is no comment to justify ignoring this symbol. >=20 > The current policy is to reject any change in libabigail.abignore > which could be better handled with (unfinished) rte_internal mark. >=20 >=20 While updating the vfio patch, also doing the ABI things. Found that: 1). [suppress_function] name =3D rte_vfio_setup_device can make CI happy, but not scale. 2). rte_internal is beautiful, but make CI cry : https://patchwork.dpdk.org= /patch/69109/ 1 Removed function: [D] 'function int rte_vfio_setup_device(const char*, const char*, int*, v= fio_device_info*)' {rte_vfio_setup_device@@DPDK_20.0}