From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id 7FD731BDFF for ; Fri, 6 Jul 2018 08:34:23 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EE344E9002; Fri, 6 Jul 2018 06:34:22 +0000 (UTC) Received: from [10.36.112.10] (unknown [10.36.112.10]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 66BC92026D68; Fri, 6 Jul 2018 06:34:21 +0000 (UTC) To: Tiwei Bie Cc: zhihong.wang@intel.com, jfreimann@redhat.com, dev@dpdk.org, mst@redhat.com, jasowang@redhat.com, wexu@redhat.com References: <20180705210741.17974-1-maxime.coquelin@redhat.com> <20180705210741.17974-2-maxime.coquelin@redhat.com> <20180706025249.GA13855@debian> From: Maxime Coquelin Message-ID: <04bb224e-258e-df2c-7d15-b3108345c4d2@redhat.com> Date: Fri, 6 Jul 2018 08:34:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180706025249.GA13855@debian> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Fri, 06 Jul 2018 06:34:22 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Fri, 06 Jul 2018 06:34:22 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] [PATCH v8 01/15] vhost: add virtio packed virtqueue defines X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Jul 2018 06:34:23 -0000 On 07/06/2018 04:52 AM, Tiwei Bie wrote: > On Thu, Jul 05, 2018 at 11:07:27PM +0200, Maxime Coquelin wrote: >> From: Jens Freimann >> >> Signed-off-by: Jens Freimann >> --- >> lib/librte_vhost/vhost.h | 20 ++++++++++++++++++++ >> 1 file changed, 20 insertions(+) >> >> diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h >> index 79e3117d2..4fc804bd8 100644 >> --- a/lib/librte_vhost/vhost.h >> +++ b/lib/librte_vhost/vhost.h >> @@ -192,6 +192,26 @@ struct vhost_msg { >> #define VIRTIO_F_VERSION_1 32 >> #endif >> >> +/* Declare packed ring related bits for older kernels */ >> +#ifndef VIRTIO_F_RING_PACKED >> + >> +#define VIRTIO_F_RING_PACKED 34 >> + >> +#define VRING_DESC_F_NEXT 1 >> +#define VRING_DESC_F_WRITE 2 >> +#define VRING_DESC_F_INDIRECT 4 >> + >> +#define VRING_DESC_F_AVAIL (1ULL << 7) >> +#define VRING_DESC_F_USED (1ULL << 15) >> + >> +struct vring_desc_packed { > > Maybe vring_packed_desc will be more consistent with > vring_packed_desc_event and vring_packed. Jason also > planned to change the name to vring_packed_desc [1]. > > [1] https://lkml.org/lkml/2018/7/4/36 Thanks for the reminder, I fixed it in the series. Regards, Maxime > > Best regards, > Tiwei Bie > >> + uint64_t addr; >> + uint32_t len; >> + uint16_t id; >> + uint16_t flags; >> +}; >> +#endif >> + >> /* >> * Available and used descs are in same order >> */ >> -- >> 2.14.4 >>