From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B3CC6A0524; Fri, 31 Jan 2020 23:03:24 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F21A61C0DC; Fri, 31 Jan 2020 23:03:23 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 639AB1C0D7 for ; Fri, 31 Jan 2020 23:03:21 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Jan 2020 14:03:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,387,1574150400"; d="scan'208,217";a="253461965" Received: from unknown (HELO [10.241.225.72]) ([10.241.225.72]) by fmsmga004.fm.intel.com with ESMTP; 31 Jan 2020 14:03:20 -0800 To: Dmitry Kozliuk , dev@dpdk.org References: <20200113215534.10084-1-pallavi.kadam@intel.com> <20200131000307.10608-1-pallavi.kadam@intel.com> <20200131000307.10608-4-pallavi.kadam@intel.com> <20200131090433.1aa037ff@Sovereign> From: Pallavi Kadam Message-ID: <04ee9d71-7728-71b1-5045-0d51cdeff0a0@intel.com> Date: Fri, 31 Jan 2020 14:03:20 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: <20200131090433.1aa037ff@Sovereign> Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v6 03/10] eal: include filesystem implementation for windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Dmitry, Thank you for reviewing the code and for your comments. On 1/30/2020 10:04 PM, Dmitry Kozliuk wrote: > Hello Pallavi, > >> +#include "eal_internal_cfg.h" >> + >> +/* sets up platform-specific runtime data dir */ >> +int >> +eal_create_runtime_dir(void); >> + >> +/* returns runtime dir */ >> +const char * >> +eal_get_runtime_dir(void); > Any reason not to #include "eal_filesystem.h"? Do you mean, we can exclude "eal_filesystem.h" in the current patchset? If so, you are correct. This file was required before to include eal_runtime_config_path() when compiling with VS/ ICC, I think. But, now 'common' version of eal_filesystem.h can be used for Windows. For other function definitions, we can always #include "eal_filesystem.h" if require later. > >> + >> +static inline const char * >> +eal_runtime_config_path(void) >> +{ >> + static char buffer[PATH_MAX]; /* static so auto-zeroed */ >> + char Directory[PATH_MAX]; > Should be "directory" according to the style guide. Thanks, will be sending out new version and excluding this file as mentioned above. > >> + >> + GetTempPathA(sizeof(Directory), Directory); >> + snprintf(buffer, sizeof(buffer)-1, RUNTIME_CONFIG_FMT, Directory, > Style guide requires spaces around binary "-". > >> +static inline const char * >> +eal_hugepage_info_path(void) >> +{ >> + static char buffer[PATH_MAX]; /* static so auto-zeroed */ >> + TCHAR Directory[PATH_MAX]; > Should be "directory", see above.