From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B3F33A052A; Tue, 2 Feb 2021 18:50:09 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9F93B240380; Tue, 2 Feb 2021 18:50:09 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id BB269240376 for ; Tue, 2 Feb 2021 18:50:07 +0100 (CET) IronPort-SDR: erZGlhshADGF01FZBgweAWLlAuizGNaoOnsNpUttrO2CmV2gzs4iGg1m7mPBNsAuX0LU1QJ5JO Dyaxc8vHGW3g== X-IronPort-AV: E=McAfee;i="6000,8403,9883"; a="177391084" X-IronPort-AV: E=Sophos;i="5.79,396,1602572400"; d="scan'208";a="177391084" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2021 09:49:46 -0800 IronPort-SDR: 4reGCjGJTnSgsD1o16KkfkpLxonNixjdthXASPOmmAs/y6YC0iJTxwAJ9cnQi/4Z1y4mKj13Ff CAusBz+Em4kA== X-IronPort-AV: E=Sophos;i="5.79,396,1602572400"; d="scan'208";a="391595860" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.226.112]) ([10.213.226.112]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2021 09:49:45 -0800 To: Jiawen Wu , dev@dpdk.org References: <20210122094800.197748-1-jiawenwu@trustnetic.com> <20210122094800.197748-8-jiawenwu@trustnetic.com> From: Ferruh Yigit Message-ID: <05352152-6157-bfd8-9f02-89f45cda0a9d@intel.com> Date: Tue, 2 Feb 2021 17:49:44 +0000 MIME-Version: 1.0 In-Reply-To: <20210122094800.197748-8-jiawenwu@trustnetic.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v1 07/20] net/txgbe: add Rx and Tx unit init for VF device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/22/2021 9:47 AM, Jiawen Wu wrote: > Configure VF device with RX port. Initialize receive and transmit unit, > set the receive and transmit functions. And support to check the > status of RX and TX descriptors. > > Signed-off-by: Jiawen Wu <...> > @@ -13,6 +17,9 @@ L3 checksum offload = P > L4 checksum offload = P > Inner L3 checksum = P > Inner L4 checksum = P > +Packet type parsing = Y Can you please move this where '.dev_supported_ptypes_get' dev_ops set. <...> > +static int > +txgbevf_dev_configure(struct rte_eth_dev *dev) > +{ > + struct rte_eth_conf *conf = &dev->data->dev_conf; > + struct txgbe_adapter *adapter = TXGBE_DEV_ADAPTER(dev); > + > + PMD_INIT_LOG(DEBUG, "Configured Virtual Function port id: %d", > + dev->data->port_id); > + > + if (dev->data->dev_conf.rxmode.mq_mode & ETH_MQ_RX_RSS_FLAG) > + dev->data->dev_conf.rxmode.offloads |= DEV_RX_OFFLOAD_RSS_HASH; > + > + /* > + * VF has no ability to enable/disable HW CRC > + * Keep the persistent behavior the same as Host PF > + */ > +#ifndef RTE_LIBRTE_TXGBE_PF_DISABLE_STRIP_CRC > + if (conf->rxmode.offloads & DEV_RX_OFFLOAD_KEEP_CRC) { > + PMD_INIT_LOG(NOTICE, "VF can't disable HW CRC Strip"); > + conf->rxmode.offloads &= ~DEV_RX_OFFLOAD_KEEP_CRC; > + } > +#else > + if (!(conf->rxmode.offloads & DEV_RX_OFFLOAD_KEEP_CRC)) { > + PMD_INIT_LOG(NOTICE, "VF can't enable HW CRC Strip"); > + conf->rxmode.offloads |= DEV_RX_OFFLOAD_KEEP_CRC; > + } > +#endif Is this macro used, if so can you please document it in the driver doc?