From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 07667A0A02; Thu, 25 Mar 2021 13:47:26 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E2CD44067B; Thu, 25 Mar 2021 13:47:25 +0100 (CET) Received: from dal3relay102.mxroute.com (dal3relay102.mxroute.com [64.40.27.102]) by mails.dpdk.org (Postfix) with ESMTP id B149540147 for ; Thu, 25 Mar 2021 13:47:23 +0100 (CET) Received: from filter004.mxroute.com ([149.28.56.236] filter004.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by dal3relay102.mxroute.com (ZoneMTA) with ESMTPSA id 178696cc7f1000362f.001 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Thu, 25 Mar 2021 12:47:20 +0000 X-Zone-Loop: c94d9d6b12af6f3135c1ca627588f19f39cd52a0f4ab X-Originating-IP: [149.28.56.236] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=yHBAelI026ByxHnO/QRK3q5Qxp3iWAlGhncXFzPQAig=; b=Y6WtCtfeq94/ZvTeGBQOHsbYiO YwQtFHM3MmdQG723FqF+yWpkO2PpAMqmZwX2f4c5uvlXzRUFtrcZ4OHx150QcWRks7CfWpxu2XbJ7 aQyzuT40hID0GAbKpxw9b9NdssAoRvnID5OPE5MdsFYKDweBvAuqNCzL8w79YdSx6AR70T3aN1dEQ 2aYT7MYSjumqe1ESIlcL1LT8gpIK+8hCDo8jGcwxsfeu4uBdbv7fiEo8lxM2KMb8K2OVcZmJJ9hk2 0KX2UFBDHBR+8KjMJQSlbG7mKT4Kgfs6WLCS/whgha7K94uvZ/T9Qf4X5Biqq4gRHteQggHt5Slcz xZxfN6Zg==; To: Jerin Jacob , Thomas Monjalon Cc: Pavan Nikhilesh , Jerin Jacob , dpdk-dev , Harman Kalra , Nithin Dabilpuram , David Marchand References: <20210225170238.15581-1-pbhagavatula@marvell.com> <11975004.s7UMkAiPBC@thomas> <5cb9bec3-6d4e-7867-e8d7-9c3d55ec78ef@ashroe.eu> <5442273.ffSK4IfYTI@thomas> From: "Kinsella, Ray" Message-ID: <0564d636-3088-9b3e-1226-2767996d7f2a@ashroe.eu> Date: Thu, 25 Mar 2021 12:47:16 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AuthUser: mdr@ashroe.eu Subject: Re: [dpdk-dev] [PATCH 1/7] common/octeontx: enable build only on 64bit Linux X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 25/03/2021 12:46, Jerin Jacob wrote: > On Thu, Mar 25, 2021 at 4:33 PM Thomas Monjalon wrote: >> >> 25/03/2021 11:58, Kinsella, Ray: >>> On 25/03/2021 10:46, Thomas Monjalon wrote: >>>> 25/03/2021 11:42, Thomas Monjalon: >>>>> 24/03/2021 11:55, Jerin Jacob: >>>>>> On Thu, Feb 25, 2021 at 10:33 PM wrote: >>>>>>> >>>>>>> From: Pavan Nikhilesh >>>>>>> >>>>>>> Due to Linux kernel dependency, only enable build for 64bit Linux. >>>>>>> >>>>>>> Signed-off-by: Pavan Nikhilesh >>>>>> >>>>>> Series Acked-by: Jerin Jacob >>>>> >>>>> I've reorganized the commits per family of drivers, >>>>> so it makes more sense than grouping per driver class >>>>> with "common/octeontx" for title for all: >>>>> >>>>> net/thunderx: enable build only on 64-bit Linux >>>>> common/octeontx: enable build only on 64-bit Linux >>>>> common/octeontx2: enable build only on 64-bit Linux >>>>> >>>>> and applied. >>>> >>>> Actually not applied yet. >>>> I'm not sure what to do for the ABI check which is broken >>>> because some drivers are not compiled anymore in 32-bit build. >>>> I've workarounded locally by removing the dump files in the reference build. >>>> Should we add an exception in libabigail.abignore? >>>> >>> In the past we said that depreciating HW support would be considered to be same as an ABI Breakage. >>> >>> From the policy ... >>> "Updates to the minimum hardware requirements, which drop support for hardware which was previously supported, should be treated as an ABI change." >> >> So the patches should wait 21.11. >> Everybody agree? > > Looks good to me to postpone. > > @Ray Kinsella @Thomas Monjalon @McDaniel, Timothy @David Marchand @Neil Horman > > Currently, I merged DLB v1 driver removal patch to next-eventdev. Is > this ABI breakge[1]? > > http://patches.dpdk.org/project/dpdk/patch/20210316210812.15614-1-timothy.mcdaniel@intel.com/ > > [1] > From the policy ... > "Updates to the minimum hardware requirements, which drop support for > hardware which was previously supported, should be treated as an ABI > change." +1