From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A7E1645954; Tue, 10 Sep 2024 11:19:08 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8422D427B6; Tue, 10 Sep 2024 11:19:08 +0200 (CEST) Received: from mail-ej1-f54.google.com (mail-ej1-f54.google.com [209.85.218.54]) by mails.dpdk.org (Postfix) with ESMTP id 52D88402A1 for ; Tue, 10 Sep 2024 11:19:07 +0200 (CEST) Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-a8d24f98215so405054866b.1 for ; Tue, 10 Sep 2024 02:19:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; s=google; t=1725959947; x=1726564747; darn=dpdk.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=qqo9ps+sHUEi45MFVgqX0q9NNMveKfN2yGI3p3YOMmw=; b=UPvGuFYKnvOUVE+1HNWiIHjRR2m0T9RC3tp5aEtqKT4bCrAFE2PlfhnMlfTAEvl4ak TJpmRLf7rx2TWFcjStw7GtcfIbZTBd7RewCFm796VLzUrqW37quyO6L0DB2zg2BwxN3j daay3wEdZYmzCPHmrPH/d7vt4HoXHD4+3NV4Avv6Tjxwy2Y3taDeNp8a60J2QeJ3ockG ldIKmJbEk2V4boBo0x1P5IhxPjvCAQCB/isAfnL9smOLkPZQRH78FAGXcpFdsj/MA0LR 2wQ60asBYRP5MYxjlVpjH+jfMs2VJnj5DZbCYB93w2ACTlOqoaXMPY3nhI3t2DLOw7bI QUIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725959947; x=1726564747; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=qqo9ps+sHUEi45MFVgqX0q9NNMveKfN2yGI3p3YOMmw=; b=IPvJf8n0tMiUpECFMFi/X3DIdpGRdUKLHVjESRWkoWJbaZTQFdk+bJwG4R0QaR98Vx vrZWkSQn8ViFoql+GYaUQX3JnRED/uLiQMk5WEoYViZIkiPV86lJVWkfB0OLF5/cEX7Z 1kKL0+Rn3XnpzNrwuMvdfCjo0uR84gAAKfn4V30TK74/l/Bk8sRQwRYiMNpg5//pGojj pleg6eWJ7QwBVF8RJsQLXzk5bGXZmVF9+iBiMj8/89WSpmp364TFGbCqCs4mnZMd31o3 4fG4LwkrVfECBVHfDiJH8d7rD+Ws5fcC31lGkMmLOuCL124CfikHG3YWw0mnjLO8UzSi /WJg== X-Gm-Message-State: AOJu0Yyy5kEIUNMXXs2LEwguWcupuo6NGHwyzc2s5mpe9kIakz06XWWs Scqfkiy4uEv20a32EEe9T3u65NXxGxNKFIB1ReOqAPfQ0gaHPHjHXkf/fgCJud4= X-Google-Smtp-Source: AGHT+IHMEgL/NElDIQIFb4UFyavKAm8TEIcrLn+8bNmh23QnpH+Hfm8RXSzP8ylPrvBzDGFaAqKDQQ== X-Received: by 2002:a17:907:97d1:b0:a7a:9144:e23b with SMTP id a640c23a62f3a-a8ffaad83abmr8842866b.19.1725959946702; Tue, 10 Sep 2024 02:19:06 -0700 (PDT) Received: from [10.12.0.236] (81.89.53.154.host.vnet.sk. [81.89.53.154]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a8d25d40cebsm450711566b.200.2024.09.10.02.19.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Sep 2024 02:19:06 -0700 (PDT) Message-ID: <05a03b0a-5e1e-4e93-a187-b34ba12cca04@pantheon.tech> Date: Tue, 10 Sep 2024 11:19:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] dts: Testbed And Node Configuration Split To: Nicholas Pratte , dmarx@iol.unh.edu, luca.vizzarro@arm.com, Honnappa.Nagarahalli@arm.com, paul.szczepanek@arm.com, probb@iol.unh.edu, jspewock@iol.unh.edu, yoan.picchi@foss.arm.com Cc: dev@dpdk.org References: <20240610193410.17968-2-npratte@iol.unh.edu> <20240703145749.23416-2-npratte@iol.unh.edu> Content-Language: en-US From: =?UTF-8?Q?Juraj_Linke=C5=A1?= In-Reply-To: <20240703145749.23416-2-npratte@iol.unh.edu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > create mode 100644 dts/execution_conf.yaml As Jeremy mentioned, this is a duplicate. I guess this patch needs to be rebased as it mentions executions all over the place. > create mode 100644 dts/node_conf.yaml > create mode 100644 dts/testbed_conf.yaml And this should be named test_run_conf.yaml or testrun_conf.yaml (it's not just testbed conf, but also other things used in test runs). Or maybe we can come up with an abbreviation or initialism for test run. > diff --git a/dts/framework/config/__init__.py b/dts/framework/config/__init__.py > index df60a5030e..2322f3d996 100644 > --- a/dts/framework/config/__init__.py > +++ b/dts/framework/config/__init__.py > @@ -573,29 +573,39 @@ def from_dict(cls, d: ConfigurationDict) -> Self: > return cls(test_runs=test_runs) > > > -def load_config(config_file_path: Path) -> Configuration: > +def load_config(node_config_file_path: Path, exec_config_file_path: Path) -> Configuration: > """Load DTS test run configuration from a file. > > - Load the YAML test run configuration file > + Load both the YAML testbed and execution configuration files > and :download:`the configuration file schema `, > - validate the test run configuration file, and create a test run configuration object. > + validate both configuration files to create a test run configuration object. Now that you're removed the last "and" the sentence feels like it's missing something. If we add then to "then validate both" then it sounds fine. > diff --git a/dts/framework/config/conf_yaml_schema.json b/dts/framework/config/conf_yaml_schema.json > index f02a310bb5..1962ed05dd 100644 > --- a/dts/framework/config/conf_yaml_schema.json > +++ b/dts/framework/config/conf_yaml_schema.json > @@ -211,192 +211,192 @@ > + "oneOf": [ Again, as mentioned in the other comment, splitting the schema would make more sense. We'd probably have to make some doc modifications (in guides/tools/dts.rtst)