From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3BAE041CEC; Mon, 20 Feb 2023 16:37:18 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2DBFF4307A; Mon, 20 Feb 2023 16:37:18 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 691F543079 for ; Mon, 20 Feb 2023 16:37:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676907435; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eZRJw14wrTrdAP9EKSjBCkzO8gHmTir5Rt33PbU887I=; b=K7KbjHsW3JtBrOLrQ2BzA5hkP3c9ejYFSfMwv1F5r66DSrj2aBXw1IJSfQIkBqVrXDla+N X5MpUYipAvDoIDXn7FZ4Rjo0Elq3WHt8RKJRRyo3ptHcn2l0o73jwSk64r1KPdgNNo/BIv h+YOSJp11OjSwffMeRn3fklT06yXcs4= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-83-eXViPjQ6MHyy-5nDBFb7nQ-1; Mon, 20 Feb 2023 10:37:12 -0500 X-MC-Unique: eXViPjQ6MHyy-5nDBFb7nQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9189618E6C41; Mon, 20 Feb 2023 15:37:11 +0000 (UTC) Received: from [10.39.208.21] (unknown [10.39.208.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2FB512166B26; Mon, 20 Feb 2023 15:37:10 +0000 (UTC) Message-ID: <05a1bd2a-411c-4757-57ce-372c1f897001@redhat.com> Date: Mon, 20 Feb 2023 16:37:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2 2/2] baseband/acc: add check for empty queue To: Hernan Vargas , dev@dpdk.org, gakhil@marvell.com, trix@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com, john.mcnamara@intel.com References: <20230208020001.181055-1-hernan.vargas@intel.com> <20230208020001.181055-3-hernan.vargas@intel.com> From: Maxime Coquelin In-Reply-To: <20230208020001.181055-3-hernan.vargas@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Hernan, On 2/8/23 03:00, Hernan Vargas wrote: > Add optimization to return early if there are no available descriptors > in ring to dequeue. > > Signed-off-by: Hernan Vargas > --- > drivers/baseband/acc/rte_acc100_pmd.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c > index baab459436..9941754aa0 100644 > --- a/drivers/baseband/acc/rte_acc100_pmd.c > +++ b/drivers/baseband/acc/rte_acc100_pmd.c > @@ -4106,10 +4106,9 @@ acc100_dequeue_ldpc_enc(struct rte_bbdev_queue_data *q_data, > int ret, cbm; > struct rte_bbdev_enc_op *op; > > -#ifdef RTE_LIBRTE_BBDEV_DEBUG > - if (unlikely(ops == 0)) > + if (avail == 0) > return 0; > -#endif > + Again, this is doing more than advertised. The patch intent is about returning early if no available descriptors, but here you also remove some debug checks. At least please mention in in the commit message & title. > op = acc_op_tail(q, 0); > if (unlikely(ops == NULL || op == NULL)) > return 0; Thanks, Maxime