From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Iremonger, Bernard" <bernard.iremonger@intel.com>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>,
"Lipiec, Herakliusz" <herakliusz.lipiec@intel.com>,
"Govindharajan, Hariprasad" <hariprasad.govindharajan@intel.com>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: guarantee that array access is in range
Date: Wed, 19 Feb 2020 14:41:58 +0000 [thread overview]
Message-ID: <05becbcf-f6e2-570c-f137-e9a3a1467eee@intel.com> (raw)
In-Reply-To: <DM6PR11MB3914BDD2167A1EC4D08F7AA6EF100@DM6PR11MB3914.namprd11.prod.outlook.com>
On 2/19/2020 2:02 PM, Iremonger, Bernard wrote:
>
>
>> -----Original Message-----
>> From: Yigit, Ferruh <ferruh.yigit@intel.com>
>> Sent: Wednesday, February 19, 2020 12:40 PM
>> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing
>> <jingjing.wu@intel.com>; Iremonger, Bernard
>> <bernard.iremonger@intel.com>; Lipiec, Herakliusz
>> <herakliusz.lipiec@intel.com>; Govindharajan, Hariprasad
>> <hariprasad.govindharajan@intel.com>; Burakov, Anatoly
>> <anatoly.burakov@intel.com>
>> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>
>> Subject: [PATCH] app/testpmd: guarantee that array access is in range
>>
>> Coverity complains about out of bound access, which is a false positive.
>>
>> The return value of the 'parse_port_list()' can't be bigger than 'maxsize'
>> because of the logic in the function. ('value >= (int)maxsize'
>> check and 'marked[]' usage.)
>>
>> But this is not explicitly clear, causing coverity warning and same question can
>> be rise by reviews later.
>>
>> Adding a redundant check to highlight the access is in range, this is done by
>> replacing existing redundant check.
>>
>> This is also good to protect against out out bound access in case
>> 'parse_port_list()' behaviour changes later unexpectedly.
>>
>> Coverity issue: 354229
>> Fixes: 2df00d562d20 ("app/testpmd: add --portlist option")
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
>
Applied to dpdk-next-net/master, thanks.
prev parent reply other threads:[~2020-02-19 14:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-19 12:40 Ferruh Yigit
2020-02-19 13:30 ` Lipiec, Herakliusz
2020-02-19 14:02 ` Iremonger, Bernard
2020-02-19 14:41 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05becbcf-f6e2-570c-f137-e9a3a1467eee@intel.com \
--to=ferruh.yigit@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=hariprasad.govindharajan@intel.com \
--cc=herakliusz.lipiec@intel.com \
--cc=jingjing.wu@intel.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).