From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3F215A09E4; Thu, 22 Apr 2021 11:06:19 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B4272413E6; Thu, 22 Apr 2021 11:06:18 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 8B1E34069D for ; Thu, 22 Apr 2021 11:06:17 +0200 (CEST) IronPort-SDR: asZWkF9V1SpdTACd8+GjubW/B5DxmORNy5PmhOj5RwL2QWk14Wg65GVNMcs5NOx5jHt7Ho35S0 IkZ2YCzopTNA== X-IronPort-AV: E=McAfee;i="6200,9189,9961"; a="193734666" X-IronPort-AV: E=Sophos;i="5.82,242,1613462400"; d="scan'208";a="193734666" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2021 02:06:16 -0700 IronPort-SDR: QZ9VeRn8MVEd2CP63+UO71IGIiVEqBucHHFRuoV1VV1FC6pVBQMxoU7O+6RgAxIQ8TcyPpD1eP 7U/5VEtPjVzg== X-IronPort-AV: E=Sophos;i="5.82,242,1613462400"; d="scan'208";a="384708736" Received: from spmccann-mobl.ger.corp.intel.com (HELO [10.213.222.135]) ([10.213.222.135]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Apr 2021 02:06:15 -0700 To: Richael Zhuang , dev@dpdk.org Cc: nd@arm.com, David Hunt References: <20210422061540.23304-1-richael.zhuang@arm.com> <20210422061540.23304-2-richael.zhuang@arm.com> From: "Burakov, Anatoly" Message-ID: <05d09823-3b20-0192-b03c-9f086b041b36@intel.com> Date: Thu, 22 Apr 2021 10:06:11 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210422061540.23304-2-richael.zhuang@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v1 1/1] power: add support for cppc cpufreq X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 22-Apr-21 7:15 AM, Richael Zhuang wrote: > Currently in DPDK only acpi_cpufreq and pstate_cpufreq drivers are > supported, which are both not available on arm64 platforms. Add > support for cppc_cpufreq driver which works on most arm64 platforms. > > Signed-off-by: Richael Zhuang > --- Just a general note: this looks like a copy-paste of pstate code. Which is perfectly fine, except that we can do better than copying some faults of the pstate code to other drivers. I've submitted a patch [1] attempting to fix some of the pressing issues and code duplication in pstate driver, but i'm sure with a fresh driver, you can do even better :) [1] http://patches.dpdk.org/project/dpdk/patch/20210402092701.258316-1-anatoly.burakov@intel.com/ -- Thanks, Anatoly