From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DE30F423EE; Mon, 16 Jan 2023 10:16:15 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 862AF40A7D; Mon, 16 Jan 2023 10:16:15 +0100 (CET) Received: from mail-qv1-f44.google.com (mail-qv1-f44.google.com [209.85.219.44]) by mails.dpdk.org (Postfix) with ESMTP id 47ED140042 for ; Mon, 16 Jan 2023 10:16:14 +0100 (CET) Received: by mail-qv1-f44.google.com with SMTP id q10so19172801qvt.10 for ; Mon, 16 Jan 2023 01:16:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/HEG70dYem5jxv77tYrvy/urS50LwSrkksAXRO3iT9o=; b=LO8EENWVn7fflQ1fdj7SU1QlS3U1BwkUGux+7Q5QJSwEjLt+lkH3vdxTM2h3oLh9UW zeR6iiXVYRdyHcDLgrsSwQzlwyHVrc5fuga4ge21m1Rtco03p6AkWOT0JAqUacvEDbsU 7qFXPIBp//IcpW/b0aif7jdZx5KNup3JfglcD4uno4zxX3wuVgQiMLtIG06xCxtriHws OquCt78N+KCECz9pLPxmNQ61u30Kmz5JhWwp0FfGVjJd9M2TMsaGjV9yq/bUc6qhnjxO m2C0dt8jTsl1NVm8BoFK3aTEULoA9WIqLHJYtvUe26r9XsgulURWpTZ/6WZWnqpgubbP 4Lcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/HEG70dYem5jxv77tYrvy/urS50LwSrkksAXRO3iT9o=; b=j45/2sUj4XorDzZkUOw6CPSNPKJ6vTdT5nDXgDGItbBW9SPopnRST1E2fzRoF1d1Ri Zc2U8PdZ6CHGTU2ovPli77WTd5tfr+KC8ROF7WWb3im05JvIpzOt2kdPYNnh2EiIqtQA S5gfel0Vhd8wEQKtVQKC+9YV5jPvoPYf8pl34nUpq+HAujHnYkynZemEjk5rM5d5hZak hQgTZ/R5nv/27L1jYlexyB1pJK/U5JsxzzffPAZHdGxwAdWCAh39pdZpJCxnlPJp5NzP fchLLKtYnd5lSBg58eC5UO7avhHVjMfrLYGykFNmz4rR4Iw1x19ml1hAxLv09dhthK04 0UxA== X-Gm-Message-State: AFqh2kogUCApiNFxMMYeMmOfm5JtgM2kX5Ir2cWA8im6pMvLaAXaE5Gp QuQ9JbCJ/VJyiRxaR4GjDH032HmaHYWoMw== X-Google-Smtp-Source: AMrXdXseKsHvv6HgHO5O7l9yKz07fHs34aZaUk75RrltapMuGU96T1g8x4JUlwlyyDfFmyIjTpkRZA== X-Received: by 2002:a05:6214:14a4:b0:534:9dc8:f92a with SMTP id bo4-20020a05621414a400b005349dc8f92amr13744182qvb.34.1673860573545; Mon, 16 Jan 2023 01:16:13 -0800 (PST) Received: from [10.249.152.179] (nat-216-240-30-25.netapp.com. [216.240.30.25]) by smtp.gmail.com with ESMTPSA id o24-20020a05620a229800b006fec1c0754csm17549303qkh.87.2023.01.16.01.16.12 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Jan 2023 01:16:13 -0800 (PST) Message-ID: <06022658-d0ae-30b7-8835-0660efddcc49@gmail.com> Date: Mon, 16 Jan 2023 09:16:08 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] ipsec: remove unneccessary null check Content-Language: en-US To: dev@dpdk.org References: <20230113184426.68063-1-stephen@networkplumber.org> From: "Zhang, Fan" In-Reply-To: <20230113184426.68063-1-stephen@networkplumber.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/13/2023 6:44 PM, Stephen Hemminger wrote: > The function rte_ring_free() accepts NULL as vaild input > like free() and other functions. > > Found with null_free_check.cocci. > > Fixes: 16d6ebb65d59 ("crypto/ipsec_mb: fix null checks") > Cc: kai.ji@intel.com > Signed-off-by: Stephen Hemminger > --- > drivers/crypto/ipsec_mb/ipsec_mb_ops.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/crypto/ipsec_mb/ipsec_mb_ops.c b/drivers/crypto/ipsec_mb/ipsec_mb_ops.c > index 71e02cd0513d..3e52f9567401 100644 > --- a/drivers/crypto/ipsec_mb/ipsec_mb_ops.c > +++ b/drivers/crypto/ipsec_mb/ipsec_mb_ops.c > @@ -139,15 +139,12 @@ int > ipsec_mb_qp_release(struct rte_cryptodev *dev, uint16_t qp_id) > { > struct ipsec_mb_qp *qp = dev->data->queue_pairs[qp_id]; > - struct rte_ring *r = NULL; > > if (!qp) > return 0; > > if (rte_eal_process_type() == RTE_PROC_PRIMARY) { > - r = rte_ring_lookup(qp->name); > - if (r) > - rte_ring_free(r); > + rte_ring_free(rte_ring_lookup(qp->name)); > > #if IMB_VERSION(1, 1, 0) > IMB_VERSION_NUM > if (qp->mb_mgr) Acked-by: Fan Zhang