From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3EA35A3160 for ; Fri, 11 Oct 2019 15:48:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DB6821EAEA; Fri, 11 Oct 2019 15:48:34 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id BDDA11EADD for ; Fri, 11 Oct 2019 15:48:33 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Oct 2019 06:48:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,284,1566889200"; d="scan'208";a="346030265" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.237.221.10]) ([10.237.221.10]) by orsmga004.jf.intel.com with ESMTP; 11 Oct 2019 06:48:24 -0700 To: "Ananyev, Konstantin" , Hemant Agrawal , "pbhagavatula@marvell.com" , Sachin Saxena , Akhil Goyal , Igor Russkikh , Pavel Belous , Ravi Kumar , Rasesh Mody , Shahed Shaikh , Rahul Lakkireddy , Marcin Wojtas , Michal Krawczyk , Guy Tzalik , Evgeny Schemeilin , Igor Chauskin , John Daley , Hyong Youb Kim , "Wei Hu (Xavier)" , "Min Hu (Connor)" , Yisen Zhuang , "Xing, Beilei" , "Zhang, Qi Z" , "Wu, Jingjing" , "Lu, Wenzhuo" , "Yang, Qiming" , Alejandro Lucero , Andrew Rybchenko , Jerin Jacob , Maciej Czekaj , "Xu, Rosen" , "Zhang, Tianfei" Cc: "dev@dpdk.org" References: <20191011040709.8344-1-pbhagavatula@marvell.com> <20191011040709.8344-2-pbhagavatula@marvell.com> <2601191342CEEE43887BDE71AB97725801919757C3@irsmsx105.ger.corp.intel.com> From: Ferruh Yigit Openpgp: preference=signencrypt Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEAFiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl1meboFCQlupOoACgkQ+TPrQ98T YR9ACBAAv2tomhyxY0Tp9Up7mNGLfEdBu/7joB/vIdqMRv63ojkwr9orQq5V16V/25+JEAD0 60cKodBDM6HdUvqLHatS8fooWRueSXHKYwJ3vxyB2tWDyZrLzLI1jxEvunGodoIzUOtum0Ce gPynnfQCelXBja0BwLXJMplM6TY1wXX22ap0ZViC0m714U5U4LQpzjabtFtjT8qOUR6L7hfy YQ72PBuktGb00UR/N5UrR6GqB0x4W41aZBHXfUQnvWIMmmCrRUJX36hOTYBzh+x86ULgg7H2 1499tA4o6rvE13FiGccplBNWCAIroAe/G11rdoN5NBgYVXu++38gTa/MBmIt6zRi6ch15oLA Ln2vHOdqhrgDuxjhMpG2bpNE36DG/V9WWyWdIRlz3NYPCDM/S3anbHlhjStXHOz1uHOnerXM 1jEjcsvmj1vSyYoQMyRcRJmBZLrekvgZeh7nJzbPHxtth8M7AoqiZ/o/BpYU+0xZ+J5/szWZ aYxxmIRu5ejFf+Wn9s5eXNHmyqxBidpCWvcbKYDBnkw2+Y9E5YTpL0mS0dCCOlrO7gca27ux ybtbj84aaW1g0CfIlUnOtHgMCmz6zPXThb+A8H8j3O6qmPoVqT3qnq3Uhy6GOoH8Fdu2Vchh TWiF5yo+pvUagQP6LpslffufSnu+RKAagkj7/RSuZV25Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXWZ5wAUJB3FgggAKCRD5M+tD3xNhH2O+D/9OEz62YuJQLuIuOfL67eFTIB5/1+0j8Tsu o2psca1PUQ61SZJZOMl6VwNxpdvEaolVdrpnSxUF31kPEvR0Igy8HysQ11pj8AcgH0a9FrvU /8k2Roccd2ZIdpNLkirGFZR7LtRw41Kt1Jg+lafI0efkiHKMT/6D/P1EUp1RxOBNtWGV2hrd 0Yg9ds+VMphHHU69fDH02SwgpvXwG8Qm14Zi5WQ66R4CtTkHuYtA63sS17vMl8fDuTCtvfPF HzvdJLIhDYN3Mm1oMjKLlq4PUdYh68Fiwm+boJoBUFGuregJFlO3hM7uHBDhSEnXQr5mqpPM 6R/7Q5BjAxrwVBisH0yQGjsWlnysRWNfExAE2sRePSl0or9q19ddkRYltl6X4FDUXy2DTXa9 a+Fw4e1EvmcF3PjmTYs9IE3Vc64CRQXkhujcN4ZZh5lvOpU8WgyDxFq7bavFnSS6kx7Tk29/ wNJBp+cf9qsQxLbqhW5kfORuZGecus0TLcmpZEFKKjTJBK9gELRBB/zoN3j41hlEl7uTUXTI JQFLhpsFlEdKLujyvT/aCwP3XWT+B2uZDKrMAElF6ltpTxI53JYi22WO7NH7MR16Fhi4R6vh FHNBOkiAhUpoXRZXaCR6+X4qwA8CwHGqHRBfYFSU/Ulq1ZLR+S3hNj2mbnSx0lBs1eEqe2vh cA== Message-ID: <0617334c-bc44-3adb-4ca8-4ced701f3714@intel.com> Date: Fri, 11 Oct 2019 14:48:23 +0100 MIME-Version: 1.0 In-Reply-To: <2601191342CEEE43887BDE71AB97725801919757C3@irsmsx105.ger.corp.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 2/3] drivers: use RTE_DIM instead of ARRAY_SIZE X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/11/2019 10:32 AM, Ananyev, Konstantin wrote: > > >> Hi Pavan, >> >>> >>> From: Pavan Nikhilesh >>> >>> Use RTE_DIM instead of re-defining ARRAY_SIZE. >>> >>> Signed-off-by: Pavan Nikhilesh >>> --- >>> drivers/bus/dpaa/base/qbman/qman.c | 6 ++-- >>> drivers/bus/dpaa/include/compat.h | 5 ---- >>> drivers/crypto/dpaa2_sec/hw/compat.h | 8 ----- >>> drivers/crypto/dpaa2_sec/hw/rta/jump_cmd.h | 6 ++-- >>> drivers/crypto/dpaa2_sec/hw/rta/nfifo_cmd.h | 2 +- >>> drivers/net/atlantic/atl_hw_regs.h | 1 - >>> drivers/net/atlantic/hw_atl/hw_atl_utils.c | 4 +-- >>> .../net/atlantic/hw_atl/hw_atl_utils_fw2x.c | 2 +- >>> drivers/net/axgbe/axgbe_common.h | 3 -- >>> drivers/net/axgbe/axgbe_dev.c | 2 +- >>> drivers/net/bnx2x/bnx2x.c | 6 ++-- >>> drivers/net/bnx2x/bnx2x.h | 6 ---- >>> drivers/net/bnx2x/ecore_init.h | 8 ++--- >>> drivers/net/bnx2x/ecore_sp.c | 2 +- >>> drivers/net/bnx2x/elink.c | 14 ++++----- >>> drivers/net/bnx2x/elink.h | 1 - >>> drivers/net/cxgbe/base/t4_hw.c | 16 +++++----- >>> drivers/net/cxgbe/base/t4vf_hw.c | 4 +-- >>> drivers/net/cxgbe/cxgbe_compat.h | 2 -- >>> drivers/net/cxgbe/cxgbe_flow.c | 4 +-- >>> drivers/net/cxgbe/cxgbe_main.c | 10 +++---- >>> drivers/net/cxgbe/sge.c | 2 +- >>> drivers/net/ena/ena_ethdev.c | 8 ++--- >>> drivers/net/enic/base/vnic_dev.c | 4 +-- >>> drivers/net/enic/base/vnic_devcmd.h | 2 -- >>> drivers/net/hns3/hns3_cmd.c | 2 +- >>> drivers/net/hns3/hns3_ethdev.h | 2 -- >>> drivers/net/hns3/hns3_flow.c | 18 +++++------ >>> drivers/net/i40e/base/i40e_diag.c | 2 +- >>> drivers/net/i40e/base/i40e_osdep.h | 2 -- >>> drivers/net/iavf/base/iavf_osdep.h | 2 -- >>> drivers/net/ice/base/ice_fdir.c | 2 +- >>> drivers/net/ice/base/ice_flex_pipe.c | 2 +- >>> drivers/net/ice/base/ice_flow.c | 2 +- >>> drivers/net/ice/base/ice_osdep.h | 1 - >>> drivers/net/ice/base/ice_switch.c | 2 +- >>> .../net/nfp/nfpcore/nfp-common/nfp_platform.h | 4 --- >>> drivers/net/nfp/nfpcore/nfp_cppcore.c | 2 +- >>> drivers/net/nfp/nfpcore/nfp_nsp.c | 2 +- >>> drivers/net/nfp/nfpcore/nfp_nsp_eth.c | 4 +-- >>> drivers/net/sfc/base/ef10_ev.c | 4 +-- >>> drivers/net/sfc/base/ef10_filter.c | 12 ++++---- >>> drivers/net/sfc/base/ef10_mac.c | 18 +++++------ >>> drivers/net/sfc/base/ef10_nic.c | 4 +-- >>> drivers/net/sfc/base/ef10_nvram.c | 6 ++-- >>> drivers/net/sfc/base/efx.h | 3 -- >>> drivers/net/sfc/base/efx_port.c | 2 +- >>> drivers/net/sfc/base/efx_rx.c | 2 +- >>> drivers/net/sfc/base/siena_mac.c | 2 +- >>> drivers/net/sfc/base/siena_nic.c | 20 ++++++------- >>> drivers/net/sfc/base/siena_nvram.c | 6 ++-- >>> drivers/net/thunderx/base/nicvf_hw.c | 30 +++++++++---------- >>> drivers/net/thunderx/base/nicvf_hw.h | 2 -- >>> .../raw/ifpga/base/osdep_rte/osdep_generic.h | 2 -- >>> 54 files changed, 120 insertions(+), 170 deletions(-) >>> >>> diff --git a/drivers/bus/dpaa/base/qbman/qman.c >>> b/drivers/bus/dpaa/base/qbman/qman.c >>> index e43fc65ef..019be95e2 100644 >>> --- a/drivers/bus/dpaa/base/qbman/qman.c >>> +++ b/drivers/bus/dpaa/base/qbman/qman.c >>> @@ -1956,7 +1956,7 @@ int qman_query_wq(u8 query_dedicated, struct >>> qm_mcr_querywq *wq) >>> int i, array_len; >>> >>> wq->channel.id = be16_to_cpu(mcr->querywq.channel.id); >>> - array_len = ARRAY_SIZE(mcr->querywq.wq_len); >>> + array_len = RTE_DIM(mcr->querywq.wq_len); >> >> [Hemant] some of these files are common Flibs and they are shared with other projects (Linux/uboot) etc. It will be more appropriate to >> map the ARRAY_SIZE to RTE_DIM in compat.h instead of changing this code inline. >> This way we need not to maintain diff from the common HW lib codes. > > +1 to this suggestion > What about dropping the drivers patch form this patchset but continue with others?