From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E9D25A0C4D; Mon, 4 Oct 2021 20:15:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 75FB54139A; Mon, 4 Oct 2021 20:15:50 +0200 (CEST) Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by mails.dpdk.org (Postfix) with ESMTP id C8035412BD for ; Mon, 4 Oct 2021 20:15:48 +0200 (CEST) Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 194Hbf75025737; Mon, 4 Oct 2021 14:15:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=ye6nCVa5cgx3VjuahCYWIPoGM8zIcAH1dsl4Q3FVN0A=; b=bRtG7sToKuUDV4NyrBgwRdteOUbWOr0sLzgnZFGBaaofVUwKk443iLl2vbQ+2QhFG/Bv xhU/Zeu0Htdh2z0E/x+bLRfXiU8PjJo6JWwZ1duvaU+HwjS84DKPB8lUjtdrZ1N/n/xS BbiW+GDJaLzDceSv2MveqSkG+a5ZHRSXHgUmy9uKGrEVEdu1lwU43jrQwai2Lo3+ldmv NEWSOxngTrQJevqKsMekIi8qBJfLzSx4yUf/3q7agYaqia2Oqgd09BH3DY7OEQtMmhJ3 RiGdr3Ofcqg9QnvIXuDVtgh7zbHGqOxLAoyu7vs/0qzmPJwPf7s9h+65qZofR/fYQP98 yQ== Received: from ppma03dal.us.ibm.com (b.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.11]) by mx0b-001b2d01.pphosted.com with ESMTP id 3bg6688umy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 04 Oct 2021 14:15:47 -0400 Received: from pps.filterd (ppma03dal.us.ibm.com [127.0.0.1]) by ppma03dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 194IC7Zi030548; Mon, 4 Oct 2021 18:15:47 GMT Received: from b01cxnp23034.gho.pok.ibm.com (b01cxnp23034.gho.pok.ibm.com [9.57.198.29]) by ppma03dal.us.ibm.com with ESMTP id 3bef2av7ku-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 04 Oct 2021 18:15:47 +0000 Received: from b01ledav006.gho.pok.ibm.com (b01ledav006.gho.pok.ibm.com [9.57.199.111]) by b01cxnp23034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 194IFkjW27984248 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 4 Oct 2021 18:15:46 GMT Received: from b01ledav006.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 464C5AC062; Mon, 4 Oct 2021 18:15:46 +0000 (GMT) Received: from b01ledav006.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 28BB4AC05E; Mon, 4 Oct 2021 18:15:45 +0000 (GMT) Received: from Davids-MBP.untrusted.randomparity.org (unknown [9.163.18.113]) by b01ledav006.gho.pok.ibm.com (Postfix) with ESMTP; Mon, 4 Oct 2021 18:15:45 +0000 (GMT) To: Sean Morrissey , Anatoly Burakov , Jerin Jacob , Sunil Kumar Kori , =?UTF-8?Q?Mattias_R=c3=b6nnblom?= , Harry van Haaren , Harman Kalra , Bruce Richardson , Konstantin Ananyev Cc: dev@dpdk.org References: <20211004101058.2396458-1-sean.morrissey@intel.com> <20211004101058.2396458-6-sean.morrissey@intel.com> From: David Christensen Message-ID: <0636eec5-9799-0281-4e98-39186b57fa31@linux.vnet.ibm.com> Date: Mon, 4 Oct 2021 11:15:44 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211004101058.2396458-6-sean.morrissey@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 3eZDEIR1wEmUmqIIT7SdehhGU2Cj4hSj X-Proofpoint-ORIG-GUID: 3eZDEIR1wEmUmqIIT7SdehhGU2Cj4hSj X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.182.1,Aquarius:18.0.790,Hydra:6.0.391,FMLib:17.0.607.475 definitions=2021-10-04_05,2021-10-04_01,2020-04-07_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 mlxscore=0 malwarescore=0 spamscore=0 priorityscore=1501 suspectscore=0 clxscore=1011 impostorscore=0 bulkscore=0 lowpriorityscore=0 adultscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109230001 definitions=main-2110040125 Subject: Re: [dpdk-dev] [PATCH v1 5/5] lib/eal: remove unneeded header includes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/4/21 3:10 AM, Sean Morrissey wrote: > These header includes have been flagged by the iwyu_tool > and removed. > > Signed-off-by: Sean Morrissey > --- > lib/eal/common/eal_common_dev.c | 5 ----- > lib/eal/common/eal_common_devargs.c | 1 - > lib/eal/common/eal_common_errno.c | 4 ---- > lib/eal/common/eal_common_fbarray.c | 3 --- > lib/eal/common/eal_common_hexdump.c | 3 --- > lib/eal/common/eal_common_launch.c | 6 ------ > lib/eal/common/eal_common_lcore.c | 6 ------ > lib/eal/common/eal_common_log.c | 2 -- > lib/eal/common/eal_common_memalloc.c | 3 --- > lib/eal/common/eal_common_memory.c | 5 ----- > lib/eal/common/eal_common_memzone.c | 4 ---- > lib/eal/common/eal_common_options.c | 2 -- > lib/eal/common/eal_common_proc.c | 2 -- > lib/eal/common/eal_common_string_fns.c | 2 -- > lib/eal/common/eal_common_tailqs.c | 11 ----------- > lib/eal/common/eal_common_thread.c | 3 --- > lib/eal/common/eal_common_timer.c | 6 ------ > lib/eal/common/eal_common_trace.c | 1 - > lib/eal/common/hotplug_mp.h | 1 - > lib/eal/common/malloc_elem.c | 6 ------ > lib/eal/common/malloc_heap.c | 5 ----- > lib/eal/common/malloc_mp.c | 1 - > lib/eal/common/malloc_mp.h | 2 -- > lib/eal/common/rte_malloc.c | 6 ------ > lib/eal/common/rte_random.c | 3 --- > lib/eal/common/rte_service.c | 6 ------ > lib/eal/include/rte_version.h | 2 -- > lib/eal/linux/eal.c | 10 ---------- > lib/eal/linux/eal_alarm.c | 7 ------- > lib/eal/linux/eal_cpuflags.c | 2 -- > lib/eal/linux/eal_debug.c | 5 ----- > lib/eal/linux/eal_dev.c | 4 ---- > lib/eal/linux/eal_hugepage_info.c | 8 -------- > lib/eal/linux/eal_interrupts.c | 8 -------- > lib/eal/linux/eal_lcore.c | 7 ------- > lib/eal/linux/eal_log.c | 11 +---------- > lib/eal/linux/eal_memalloc.c | 8 -------- > lib/eal/linux/eal_memory.c | 9 --------- > lib/eal/linux/eal_thread.c | 5 ----- > lib/eal/linux/eal_timer.c | 15 --------------- > lib/eal/linux/eal_vfio_mp_sync.c | 1 - > lib/eal/unix/eal_file.c | 1 - > lib/eal/unix/rte_thread.c | 1 - > lib/eal/x86/rte_cycles.c | 1 - > 44 files changed, 1 insertion(+), 203 deletions(-) Build errors generated on POWER build with gcc 8.3.1-5 (RHEL 8.4): [64/2593] Compiling C object 'lib/76b5a35@@rte_eal@sta/eal_common_eal_common_lcore.c.o'. ../lib/eal/common/eal_common_lcore.c: In function ‘rte_lcore_index’: ../lib/eal/common/eal_common_lcore.c:27:6: warning: implicit declaration of function ‘unlikely’ [-Wimplicit-function-declaration] if (unlikely(lcore_id >= RTE_MAX_LCORE)) ^~~~~~~~ ../lib/eal/common/eal_common_lcore.c:27:6: warning: nested extern declaration of ‘unlikely’ [-Wnested-externs] [436/2593] Linking target lib/librte_eal.so.22.0. FAILED: lib/librte_eal.so.22.0 Failure can be fixed in one of two ways: 1) Leave #include in lib/eal/common/eal_common_lcore.c 2) Replace #include with in lib/eal/common/eal_common_lcore.c Dave