From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0011945B5E; Thu, 17 Oct 2024 14:05:13 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 91D5A40279; Thu, 17 Oct 2024 14:05:13 +0200 (CEST) Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by mails.dpdk.org (Postfix) with ESMTP id 3BA344021E for ; Thu, 17 Oct 2024 14:05:12 +0200 (CEST) Received: from mail.maildlp.com (unknown [172.19.163.174]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4XTmj45Y4pzQrtT; Thu, 17 Oct 2024 20:04:24 +0800 (CST) Received: from kwepemm600004.china.huawei.com (unknown [7.193.23.242]) by mail.maildlp.com (Postfix) with ESMTPS id 48993140135; Thu, 17 Oct 2024 20:05:10 +0800 (CST) Received: from [10.67.121.59] (10.67.121.59) by kwepemm600004.china.huawei.com (7.193.23.242) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Thu, 17 Oct 2024 20:05:09 +0800 Message-ID: <065db1f6-1fd7-4fc5-57ee-3e875b7211a8@huawei.com> Date: Thu, 17 Oct 2024 20:05:09 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH v1 1/2] power: fix power library with --lcores To: Sivaprasad Tummala , , , , , , , , CC: References: <20240724130336.1076462-1-sivaprasad.tummala@amd.com> <20241017110247.1051770-1-sivaprasad.tummala@amd.com> From: "lihuisong (C)" In-Reply-To: <20241017110247.1051770-1-sivaprasad.tummala@amd.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.121.59] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemm600004.china.huawei.com (7.193.23.242) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Good job. With belows to change, Acked-by: Huisong Li 在 2024/10/17 19:02, Sivaprasad Tummala 写道: > This commit fixes an issue in the power library > related to using lcores mapped to different > physical cores (--lcores option in EAL). > > Previously, the power library incorrectly accessed > CPU sysfs attributes for power management, treating > lcore IDs as CPU IDs. > e.g. with --lcores '1@128', lcore_id '1' was interpreted > as CPU_id instead of '128'. > > This patch corrects the cpu_id based on lcore and CPU > mappings. It also constraints power management support > for lcores mapped to multiple physical cores/threads. > > When multiple lcores are mapped to the same physical core, > invoking frequency scaling APIs on any lcore will apply the > changes effectively. > > Signed-off-by: Sivaprasad Tummala > --- > lib/power/power_acpi_cpufreq.c | 7 ++++++- > lib/power/power_amd_pstate_cpufreq.c | 7 ++++++- > lib/power/power_common.c | 23 +++++++++++++++++++++++ > lib/power/power_common.h | 2 +- > lib/power/power_cppc_cpufreq.c | 7 ++++++- > lib/power/power_pstate_cpufreq.c | 7 ++++++- > 6 files changed, 48 insertions(+), 5 deletions(-) > > diff --git a/lib/power/power_acpi_cpufreq.c b/lib/power/power_acpi_cpufreq.c > index 81996e1c13..259bc8a263 100644 > --- a/lib/power/power_acpi_cpufreq.c > +++ b/lib/power/power_acpi_cpufreq.c > @@ -258,7 +258,12 @@ power_acpi_cpufreq_init(unsigned int lcore_id) > return -1; > } > > - pi->lcore_id = lcore_id; > + if (check_lcore_and_set_cpu(lcore_id, &pi->lcore_id) < 0) { > + POWER_LOG(ERR, > + "Cannot get cpu id mapped for lcore %u", lcore_id); > + return -1; > + } > + > /* Check and set the governor */ > if (power_set_governor_userspace(pi) < 0) { > POWER_LOG(ERR, "Cannot set governor of lcore %u to " > diff --git a/lib/power/power_amd_pstate_cpufreq.c b/lib/power/power_amd_pstate_cpufreq.c > index 090a0d96cb..9bfb271bb7 100644 > --- a/lib/power/power_amd_pstate_cpufreq.c > +++ b/lib/power/power_amd_pstate_cpufreq.c > @@ -376,7 +376,12 @@ power_amd_pstate_cpufreq_init(unsigned int lcore_id) > return -1; > } > > - pi->lcore_id = lcore_id; > + if (check_lcore_and_set_cpu(lcore_id, &pi->lcore_id) < 0) { > + POWER_LOG(ERR, > + "Cannot get cpu id mapped for lcore %u", lcore_id); > + return -1; > + } > + > /* Check and set the governor */ > if (power_set_governor_userspace(pi) < 0) { > POWER_LOG(ERR, "Cannot set governor of lcore %u to " > diff --git a/lib/power/power_common.c b/lib/power/power_common.c > index 590986d5ef..a8d5cd1c50 100644 > --- a/lib/power/power_common.c > +++ b/lib/power/power_common.c > @@ -9,6 +9,7 @@ > > #include > #include > +#include > > #include "power_common.h" > > @@ -204,3 +205,25 @@ power_set_governor(unsigned int lcore_id, const char *new_governor, > > return ret; > } > + > +int check_lcore_and_set_cpu(uint32_t lcore_id, uint32_t *cpu_id) How about the following function name? It is probably more common for other power library like PM QoS which is upstreaming. --> int power_get_lcore_mapped_cpu_id(lcore_id) negative on failure >=0 on success > +{ > + rte_cpuset_t lcore_cpus; > + uint32_t cpu; > + > + lcore_cpus = rte_lcore_cpuset(lcore_id); > + if (CPU_COUNT(&lcore_cpus) != 1) { > + POWER_LOG(ERR, > + "Power library does not support lcore %u mapping to %u cpus", > + lcore_id, CPU_COUNT(&lcore_cpus)); > + return -1; > + } > + > + for (cpu = 0; cpu < CPU_SETSIZE; cpu++) { > + if (CPU_ISSET(cpu, &lcore_cpus)) > + break; > + } > + *cpu_id = cpu; > + > + return 0; > +} <...>