From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 6FEAF32A5 for ; Wed, 7 Dec 2016 12:13:58 +0100 (CET) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga105.fm.intel.com with ESMTP; 07 Dec 2016 03:13:57 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,310,1477983600"; d="scan'208";a="39743156" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.29]) ([10.237.220.29]) by orsmga005.jf.intel.com with ESMTP; 07 Dec 2016 03:13:56 -0800 To: Tomasz Kulasek , dev@dpdk.org References: <1477486575-25148-1-git-send-email-tomaszx.kulasek@intel.com> <1479922585-8640-1-git-send-email-tomaszx.kulasek@intel.com> <1479922585-8640-7-git-send-email-tomaszx.kulasek@intel.com> Cc: konstantin.ananyev@intel.com, olivier.matz@6wind.com From: Ferruh Yigit Message-ID: <067ddc1b-5b28-47fe-8947-84a218357488@intel.com> Date: Wed, 7 Dec 2016 11:13:55 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <1479922585-8640-7-git-send-email-tomaszx.kulasek@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v12 6/6] testpmd: use Tx preparation in csum engine X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Dec 2016 11:13:59 -0000 On 11/23/2016 5:36 PM, Tomasz Kulasek wrote: > Added "csum txprep (on|off)" command which allows to switch to the > tx path using Tx preparation API. > > By default unchanged implementation is used. > > Using Tx preparation path, pseudo header calculation for udp/tcp/tso > packets from application, and used Tx preparation API for > packet preparation and verification. > > Adding additional step to the csum engine costs about 3-4% of performance > drop, on my setup with ixgbe driver. It's caused mostly by the need > of reaccessing and modification of packet data. > > Signed-off-by: Tomasz Kulasek > Acked-by: Konstantin Ananyev > --- > app/test-pmd/cmdline.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++ > app/test-pmd/csumonly.c | 33 ++++++++++++++++++++++++------- > app/test-pmd/testpmd.c | 5 +++++ > app/test-pmd/testpmd.h | 2 ++ > 4 files changed, 82 insertions(+), 7 deletions(-) > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > index 63b55dc..373fc59 100644 <...> > +cmdline_parse_inst_t cmd_csum_txprep = { > + .f = cmd_csum_txprep_parsed, > + .data = NULL, > + .help_str = "enable/disable tx preparation path for csum engine: " > + "csum txprep on|off", Can you please format help string as: "cmd fixed_string fixed|string|options : Description" see commit 26faac80327f above becomes: "csum txprep on|off: Enable/Disable tx preparation path for csum engine" <...>