From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id 360A41B3BF
 for <dev@dpdk.org>; Fri, 13 Oct 2017 02:28:39 +0200 (CEST)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by fmsmga105.fm.intel.com with ESMTP; 12 Oct 2017 17:28:39 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.43,368,1503385200"; d="scan'208";a="909461164"
Received: from unknown (HELO [10.241.225.21]) ([10.241.225.21])
 by FMSMGA003.fm.intel.com with ESMTP; 12 Oct 2017 17:28:38 -0700
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, "Kavanagh, Mark B" <mark.b.kavanagh@intel.com>,
 Markus Theil <markus.theil@tu-ilmenau.de>
References: <1503336825-7700-1-git-send-email-markus.theil@tu-ilmenau.de>
 <1504613046-7259-1-git-send-email-markus.theil@tu-ilmenau.de>
 <1504613046-7259-5-git-send-email-markus.theil@tu-ilmenau.de>
 <DC5AD7FA266D86499789B1BCAEC715F8D3A269DD@IRSMSX101.ger.corp.intel.com>
 <abe87772-5edc-8361-8eab-d677ee7a4046@intel.com>
 <CAOaVG164WXRV+iW0ajaeek6u=Wa4kp4PtWFBoiBSkLdhRCzRnA@mail.gmail.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <067e0aad-5733-6d25-09c7-d6d820b4adc5@intel.com>
Date: Fri, 13 Oct 2017 01:28:38 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <CAOaVG164WXRV+iW0ajaeek6u=Wa4kp4PtWFBoiBSkLdhRCzRnA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH v7 5/6] igb_uio: use kernel functions for
 masking MSI-X
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Oct 2017 00:28:40 -0000

On 10/12/2017 10:15 PM, Stephen Hemminger wrote:
> Are the symbols exported?

No!

They started to be exported in v4.5. I will update accordingly.

Thanks,
ferruh

> 
> On Oct 12, 2017 13:58, "Ferruh Yigit" <ferruh.yigit@intel.com
> <mailto:ferruh.yigit@intel.com>> wrote:
> 
>     On 10/12/2017 11:50 AM, Kavanagh, Mark B wrote:
>     > Hi,
>     >
>     > This commit renders igb_uio unusable on Fedora 20, kernel version
>     3.19.8-100.fc20.x86_64.
>     >
>     > During the build (make -j 20), a warning is issued for igb_uio
>     regarding a missing symbol (pci_msi_unmask):
>     >       WARNING: "pci_msi_unmask_irq"
>     [/home/<redacted>/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/igb_uio/igb_uio.ko]
>     undefined!
>     >       WARNING: "pci_msi_mask_irq"
>     [/home/<redacted>/x86_64-native-linuxapp-gcc/build/lib/librte_eal/linuxapp/igb_uio/igb_uio.ko]
>     undefined!
>     >
> 
>     Hi Mark,
> 
>     I can see vanilla 3.19.8 has pci_msi_unmask_irq and pci_msi_mask_irq.
> 
>     Also I checked Fedora 3.19.8-100.fc20.x86_64 source code, they are still
>     there.
> 
>     Not sure why getting this error.
> 
>     > Subsequently, the module is may not be loaded on account of same.
>     > (from dmesg):
>     >       [673425.712110] igb_uio: Unknown symbol pci_msi_unmask_irq
>     (err 0)
>     >       [673425.712124] igb_uio: Unknown symbol pci_msi_mask_irq (err 0)
>     >
>     > Thanks,
>     > Mark
> 
>