From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C5D81A0032; Sun, 17 Jul 2022 15:08:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5E0D140695; Sun, 17 Jul 2022 15:08:25 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id AE5D340687 for ; Sun, 17 Jul 2022 15:08:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1658063302; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1y/ZtFne17Lmf7iWT6b2yH0ug7OZAdIT24MQc7A1h1Y=; b=dlP7hZuxiDeH7IZZ7STuVahuBiL9+m2QCWK3v7sXF0bMVXMjlMmL04g53wcG6Z1KJv4zVb 0/P329QKdq/J3VEVyukglYumRgF3P6VpZcMdBE7VxtJQEjBI5iNXKMUr+FC0TuY0R6vM2j v4GzHp+s6c2GjAUldwdEApXBKIzVw9A= Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-185-UiS6emwfOma0Q0IpM-eb0g-1; Sun, 17 Jul 2022 09:08:21 -0400 X-MC-Unique: UiS6emwfOma0Q0IpM-eb0g-1 Received: by mail-qk1-f197.google.com with SMTP id k9-20020a05620a414900b006b58d6a89f2so7376452qko.2 for ; Sun, 17 Jul 2022 06:08:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=1y/ZtFne17Lmf7iWT6b2yH0ug7OZAdIT24MQc7A1h1Y=; b=UZz/5GnoRMrLq7dXiWa1lddz76tQQUFXLZcAakxRxFDGotiof2OHVPHjFp+zRDxGV/ yohDwiD091zuCGFRiiSTYhlqd49UPqEznyRMuyjdpw2dnDIH7JnvvAoX1r+p0xKxOv1C cuVuOFsG4Lg49Ta4/vnPrZPTK0v7HG/R5BOh9Xzxl8BYg0ffTqRSpM4s1+lmzxNL3h7M PMd0+11vEgkO5Gmk7OSkcCSx5KmUuKNGRb8bHdqaHpf4arOGChE9gHXvcRmFQ0e7tizH oeqVLhOHN06Bw7Uy8yY2ddbCmrig9fiStLXjImK8nrVYRdH9IyXlUdKpfGbgs4CSa+bv 9hLg== X-Gm-Message-State: AJIora82LhQJPtMqxOakdMC7WMBu5eoKTNZeTY9S4603njfEIIX0SyBh yYONUWm04VxP5Um2fPXnUmqoha4cL6EvkxkA5VrQOPlOG493JzrXsFdyPSzWgmQK7JMIYSGL96G PilQ= X-Received: by 2002:a05:620a:270d:b0:6b5:d076:1c55 with SMTP id b13-20020a05620a270d00b006b5d0761c55mr6499128qkp.43.1658063300965; Sun, 17 Jul 2022 06:08:20 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sOf19NyzbBn5t6F/1aBoM/0gk4cXi+DmEKKOQ6H+0VDucrjTXBjIAD/C969WSm9PMm9y31nA== X-Received: by 2002:a05:620a:270d:b0:6b5:d076:1c55 with SMTP id b13-20020a05620a270d00b006b5d0761c55mr6499111qkp.43.1658063300733; Sun, 17 Jul 2022 06:08:20 -0700 (PDT) Received: from localhost.localdomain (024-205-208-113.res.spectrum.com. [24.205.208.113]) by smtp.gmail.com with ESMTPSA id k7-20020a05620a414700b006b5e5ebfff8sm1135167qko.62.2022.07.17.06.08.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 17 Jul 2022 06:08:20 -0700 (PDT) Subject: Re: [PATCH v1 00/10] baseband/acc200 To: "Vargas, Hernan" , Maxime Coquelin , "Chautru, Nicolas" , "dev@dpdk.org" , "thomas@monjalon.net" , "gakhil@marvell.com" , "hemant.agrawal@nxp.com" Cc: "mdr@ashroe.eu" , "Richardson, Bruce" , "david.marchand@redhat.com" , "stephen@networkplumber.org" References: <1657238503-143836-1-git-send-email-nicolas.chautru@intel.com> <9087aa5a-6ba8-5df2-8a68-63926843ff7e@redhat.com> From: Tom Rix Message-ID: <067e2806-4c47-c897-0b71-84e5deb8a249@redhat.com> Date: Sun, 17 Jul 2022 06:08:17 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=trix@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 7/14/22 11:49 AM, Vargas, Hernan wrote: > Hi Tom, Maxime, > > Could you please review the v5 series that Nic submitted last week? > https://patches.dpdk.org/project/dpdk/list/?series=23912 > > Thanks, > Hernan Hernan, For this patch series for the acc200, will you be able to refactor it so acc has a common base ? Or will this be on hold until Nic is back ? Tom > > > -----Original Message----- > From: Maxime Coquelin > Sent: Tuesday, July 12, 2022 8:49 AM > To: Chautru, Nicolas ; dev@dpdk.org; thomas@monjalon.net; gakhil@marvell.com; hemant.agrawal@nxp.com; trix@redhat.com; Vargas, Hernan > Cc: mdr@ashroe.eu; Richardson, Bruce ; david.marchand@redhat.com; stephen@networkplumber.org > Subject: Re: [PATCH v1 00/10] baseband/acc200 > > Hi Nicolas, Hernan, > > (Adding Hernan in the recipients list) > > On 7/8/22 02:01, Nicolas Chautru wrote: >> This is targeting 22.11 and includes the PMD for the integrated >> accelerator on Intel Xeon SPR-EEC. >> There is a dependency on that parallel serie still in-flight which >> extends the bbdev api >> https://patches.dpdk.org/project/dpdk/list/?series=23894 >> >> I will be offline for a few weeks for the summer break but Hernan will >> cover for me during that time if required. >> >> Thanks >> Nic >> >> Nicolas Chautru (10): >> baseband/acc200: introduce PMD for ACC200 >> baseband/acc200: add HW register definitions >> baseband/acc200: add info get function >> baseband/acc200: add queue configuration >> baseband/acc200: add LDPC processing functions >> baseband/acc200: add LTE processing functions >> baseband/acc200: add support for FFT operations >> baseband/acc200: support interrupt >> baseband/acc200: add device status and vf2pf comms >> baseband/acc200: add PF configure companion function >> >> MAINTAINERS | 3 + >> app/test-bbdev/meson.build | 3 + >> app/test-bbdev/test_bbdev_perf.c | 76 + >> doc/guides/bbdevs/acc200.rst | 244 ++ >> doc/guides/bbdevs/index.rst | 1 + >> drivers/baseband/acc200/acc200_pf_enum.h | 468 +++ >> drivers/baseband/acc200/acc200_pmd.h | 690 ++++ >> drivers/baseband/acc200/acc200_vf_enum.h | 89 + >> drivers/baseband/acc200/meson.build | 8 + >> drivers/baseband/acc200/rte_acc200_cfg.h | 115 + >> drivers/baseband/acc200/rte_acc200_pmd.c | 5403 ++++++++++++++++++++++++++++++ >> drivers/baseband/acc200/version.map | 10 + >> drivers/baseband/meson.build | 1 + >> 13 files changed, 7111 insertions(+) >> create mode 100644 doc/guides/bbdevs/acc200.rst >> create mode 100644 drivers/baseband/acc200/acc200_pf_enum.h >> create mode 100644 drivers/baseband/acc200/acc200_pmd.h >> create mode 100644 drivers/baseband/acc200/acc200_vf_enum.h >> create mode 100644 drivers/baseband/acc200/meson.build >> create mode 100644 drivers/baseband/acc200/rte_acc200_cfg.h >> create mode 100644 drivers/baseband/acc200/rte_acc200_pmd.c >> create mode 100644 drivers/baseband/acc200/version.map >> > Comparing ACC200 & ACC100 header files, I understand ACC200 is an evolution of the ACC10x family. The FEC bits are really close, ACC200 main addition seems to be FFT acceleration which could be handled in ACC10x driver based on device ID. > > I think both drivers have to be merged in order to avoid code duplication. That's how other families of devices (e.g. i40e) are handled. > > Thanks, > Maxime >