From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2BE2C424CA; Fri, 21 Jun 2024 11:10:15 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AC3A0402F1; Fri, 21 Jun 2024 11:10:14 +0200 (CEST) Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) by mails.dpdk.org (Postfix) with ESMTP id CF8154026A for ; Fri, 21 Jun 2024 11:10:11 +0200 (CEST) Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-a63359aaaa6so249059366b.2 for ; Fri, 21 Jun 2024 02:10:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; s=google; t=1718961011; x=1719565811; darn=dpdk.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=OSeo1ERMxzLeRWGbz3F/lqvMns+McgQQe5WdfX6Thn0=; b=nEUwy8uz46ZESkxV/N5KNzgqlC09oQgDB4V9rl3N2pXT1/7/IwTdqUUD+rVZ1fQKHC L+DSKWOuiTgf0uhcHKhI/MC3OvWelHIP+jDrFlWhbCo7ZrkON5IO6jYV80W50pWwHCY9 3EJnsPzdnkOp49z2RUcku5Ycvs2WeHtuwHv6NCpVVjs4bv6yK4R++mSosx1PSBpCQ2Ri YOE0neCE4YXtzTEXtZCJuIxWPGApMK05EeTxruJWWvPotLGo9JC6I+A1nJYosY/piMup V3J77HMKhLxHPRcdu5UJPAWCqQ0B7YmKcBEUTi4Y7oDEszUbf/189bF584PDHsX+QBkR sTzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718961011; x=1719565811; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OSeo1ERMxzLeRWGbz3F/lqvMns+McgQQe5WdfX6Thn0=; b=vWvDOT3D2DFaWCJ60wZNM18M6DY8r39PcvHTsk3lEEzaRmSALOROxiit0aaUZkUd0K Zxai24k52L1ZA6LWkUcp+gS5jFjCj4lzSULJbckiP8067vCTu3fAzrCb0Bs3m0vm99ap d1IrrRvZx0QObC088b3Xx+BP8xXHzYsfA/3PNt8Gubz1W2OmlYsOIi6tatZomOpYe/Hz cmHZOYmuycZ0oQDWBEUy/Z17fiD7GOxbZPJAhswQ1dFMA5Ysnh72Guvan3you1KZ90G6 e+mPCzvIsNRQg/UJdGd42uenK1ZsH+gtJjEKiD/IYGRv9xJ+EGOiKzrTY2Y3I1ietNuO +h3w== X-Gm-Message-State: AOJu0YxQXLX4PVav+W/tF/XVB3S8g5WmGsezSr2Vv9WlX6UalmQNlqSq QSBPEVdfZp4ekVyNn77dogPhqFYwqZRZasbNGa7GCIC5kaQyjMOSAZKpLJKmU38= X-Google-Smtp-Source: AGHT+IHz2RJx5mUyrINlpE4jTfoiao/ol/gGYa8vdZh0gBa4mqQ7H6afSqxprQbTDrLUv/bI8eDV2A== X-Received: by 2002:a17:906:2602:b0:a6f:4de6:79f with SMTP id a640c23a62f3a-a6fab648b9emr376408866b.40.1718961011558; Fri, 21 Jun 2024 02:10:11 -0700 (PDT) Received: from [192.168.1.113] ([84.245.121.236]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a6fcf428b57sm61508166b.28.2024.06.21.02.10.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Jun 2024 02:10:11 -0700 (PDT) Message-ID: <0692ad26-08fa-4fdd-87be-79ce770f3f9c@pantheon.tech> Date: Fri, 21 Jun 2024 11:10:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/3] dts: Improve output gathering in interactive shells To: jspewock@iol.unh.edu, yoan.picchi@foss.arm.com, thomas@monjalon.net, Luca.Vizzarro@arm.com, wathsala.vithanage@arm.com, Honnappa.Nagarahalli@arm.com, paul.szczepanek@arm.com, npratte@iol.unh.edu, probb@iol.unh.edu Cc: dev@dpdk.org References: <20240501161623.26672-1-jspewock@iol.unh.edu> <20240620173609.15375-1-jspewock@iol.unh.edu> <20240620173609.15375-2-jspewock@iol.unh.edu> Content-Language: en-US From: =?UTF-8?Q?Juraj_Linke=C5=A1?= In-Reply-To: <20240620173609.15375-2-jspewock@iol.unh.edu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 20. 6. 2024 19:36, jspewock@iol.unh.edu wrote: > From: Jeremy Spewock > > The current implementation of consuming output from interactive shells > relies on being able to find an expected prompt somewhere within the > output buffer after sending the command. This is useful in situations > where the prompt does not appear in the output itself, but in some > practical cases (such as the starting of an XML-RPC server for scapy) > the prompt exists in one of the commands sent to the shell and this can > cause the command to exit early and creates a race condition between the > server starting and the first command being sent to the server. > > This patch addresses this problem by searching for a line that strictly > ends with the provided prompt, rather than one that simply contains it, > so that the detection that a command is finished is more consistent. It > also adds a catch to detect when a command times out before finding the > prompt or the underlying SSH session dies so that the exception can be > wrapped into a more explicit one and be more consistent with the > non-interactive shells. > > Bugzilla ID: 1359 > Fixes: 88489c0501af ("dts: add smoke tests") > > Signed-off-by: Jeremy Spewock Reviewed-by: Juraj Linkeš