From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 0C244A0613
for <public@inbox.dpdk.org>; Fri, 27 Sep 2019 16:03:56 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id C6FE21BEAE;
Fri, 27 Sep 2019 16:03:55 +0200 (CEST)
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
by dpdk.org (Postfix) with ESMTP id CD13A4C99
for <dev@dpdk.org>; Fri, 27 Sep 2019 16:03:53 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga004.jf.intel.com ([10.7.209.38])
by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
27 Sep 2019 07:03:52 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.64,555,1559545200"; d="scan'208";a="341804342"
Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204])
by orsmga004.jf.intel.com with ESMTP; 27 Sep 2019 07:03:52 -0700
Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by
FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS)
id 14.3.439.0; Fri, 27 Sep 2019 07:03:52 -0700
Received: from lcsmsx154.ger.corp.intel.com (10.186.165.229) by
fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS)
id 14.3.439.0; Fri, 27 Sep 2019 07:03:51 -0700
Received: from hasmsx114.ger.corp.intel.com ([169.254.14.116]) by
LCSMSX154.ger.corp.intel.com ([169.254.7.161]) with mapi id 14.03.0439.000;
Fri, 27 Sep 2019 17:03:49 +0300
From: "Baran, MarcinX" <marcinx.baran@intel.com>
To: "Richardson, Bruce" <bruce.richardson@intel.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "Modrak, PawelX" <pawelx.modrak@intel.com>
Thread-Topic: [dpdk-dev] [PATCH v5 4/6] examples/ioat: add two threads
configuration
Thread-Index: AQHVb4aLSJQy6HGBgES1MSUGxO1Aq6c/JcoAgABzv3A=
Date: Fri, 27 Sep 2019 14:03:49 +0000
Message-ID: <06CDC4676D44784DA2DF9423D4B672BE15ECCCC0@HASMSX114.ger.corp.intel.com>
References: <20190919093850.460-1-marcinx.baran@intel.com>
<20190920073714.1314-1-marcinx.baran@intel.com>
<20190920073714.1314-5-marcinx.baran@intel.com>
<20190927100854.GD1847@bricha3-MOBL.ger.corp.intel.com>
In-Reply-To: <20190927100854.GD1847@bricha3-MOBL.ger.corp.intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
dlp-product: dlpe-windows
dlp-version: 11.2.0.6
dlp-reaction: no-action
x-originating-ip: [10.184.70.11]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v5 4/6] examples/ioat: add two threads
configuration
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
-----Original Message-----
From: Bruce Richardson <bruce.richardson@intel.com>=20
Sent: Friday, September 27, 2019 12:09 PM
To: Baran, MarcinX <marcinx.baran@intel.com>
Cc: dev@dpdk.org; Modrak, PawelX <pawelx.modrak@intel.com>
Subject: Re: [dpdk-dev] [PATCH v5 4/6] examples/ioat: add two threads confi=
guration
On Fri, Sep 20, 2019 at 09:37:12AM +0200, Marcin Baran wrote:
> From: Pawel Modrak <pawelx.modrak@intel.com>
>=20
> Added possibility to use two lcores: first for packet receiving and=20
> copying, second for packets sending.
>=20
> Signed-off-by: Pawel Modrak <pawelx.modrak@intel.com>
> Signed-off-by: Marcin Baran <marcinx.baran@intel.com>
> ---
> examples/ioat/ioatfwd.c | 92=20
> ++++++++++++++++++++++++++++++-----------
> 1 file changed, 67 insertions(+), 25 deletions(-)
>=20
> diff --git a/examples/ioat/ioatfwd.c b/examples/ioat/ioatfwd.c index=20
> c66ce7e49..4c51db6bd 100644
> --- a/examples/ioat/ioatfwd.c
> +++ b/examples/ioat/ioatfwd.c
> @@ -161,7 +161,6 @@ ioat_enqueue_packets(struct rte_mbuf **pkts,
> rte_mempool_put_bulk(ioat_pktmbuf_pool, (void *)&pkts_copy[i],
> nb_rx - i);
> =20
> -
> return ret;
> }
> =20
> @@ -226,8 +225,8 @@ ioat_tx_port(struct rxtx_port_config *tx_config)
> struct rte_mbuf *mbufs_dst[MAX_PKT_BURST];
> =20
> if (copy_mode =3D=3D COPY_MODE_IOAT_NUM) {
> - /* Deque the mbufs from IOAT device. */
> for (i =3D 0; i < tx_config->nb_queues; i++) {
> + /* Deque the mbufs from IOAT device. */
> nb_dq =3D rte_ioat_completed_copies(
> tx_config->ioat_ids[i], MAX_PKT_BURST,
> (void *)mbufs_src, (void *)mbufs_dst); @@ -256,31 +255,64 @@=20
> ioat_tx_port(struct rxtx_port_config *tx_config)
> nb_dq - nb_tx);
> }
> } else {
> - /* Deque the mbufs from rx_to_tx_ring. */
> - nb_dq =3D rte_ring_dequeue_burst(tx_config->rx_to_tx_ring,
> - (void *)mbufs_dst, MAX_PKT_BURST, NULL);
> -
> - if (nb_dq =3D=3D 0)
> - return;
> -
> - /* Update macs if enabled */
> - if (mac_updating) {
> - for (i =3D 0; i < nb_dq; i++)
> - update_mac_addrs(mbufs_dst[i],
> - tx_config->rxtx_port);
> - }
> + for (i =3D 0; i < tx_config->nb_queues; i++) {
This commit refers to adding support for 2 threads rather than 1, but this =
change seems related to having multiple queues rather than threads. Shoudl =
it be in a previous patch?
/Bruce
[Marcin] Moved the change to 2nd patch for v6.