Re: [dpdk-dev] [PATCH v5 5/6] examples/ioat: add stats printing for each port

["Baran, MarcinX" <marcinx.baran@intel.com>]

-----Original Message-----
From: Bruce Richardson <bruce.richardson@intel.com> 
Sent: Friday, September 27, 2019 12:13 PM
To: Baran, MarcinX <marcinx.baran@intel.com>
Cc: dev@dpdk.org; Modrak, PawelX <pawelx.modrak@intel.com>
Subject: Re: [dpdk-dev] [PATCH v5 5/6] examples/ioat: add stats printing for each port

On Fri, Sep 20, 2019 at 09:37:13AM +0200, Marcin Baran wrote:
> Added printing stats of ports each second.
> The stats printing is done using master core.
> The information provided informs about packets received, dropped and 
> send as well as statistics of rawdev devices.
> 
> Signed-off-by: Marcin Baran <marcinx.baran@intel.com>
> Signed-off-by: Pawel Modrak <pawelx.modrak@intel.com>
> ---
>  examples/ioat/ioatfwd.c | 245 
> +++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 241 insertions(+), 4 deletions(-)
> 
> diff --git a/examples/ioat/ioatfwd.c b/examples/ioat/ioatfwd.c index 
> 4c51db6bd..c6b994832 100644
> --- a/examples/ioat/ioatfwd.c
> +++ b/examples/ioat/ioatfwd.c
> @@ -48,10 +48,27 @@ struct rxtx_transmission_config {
>  	uint16_t nb_lcores;
>  };
>  

<snip stats code>

> @@ -363,7 +587,7 @@ ioat_usage(const char *prgname)
>  		"      When enabled:\n"
>  		"       - The source MAC address is replaced by the TX port MAC address\n"
>  		"       - The destination MAC address is replaced by 02:00:00:00:00:TX_PORT_ID\n"
> -		"  -c --copy-type CT: type of copy: sw|rawdev\n"
> +		"  -c --copy-type CT: type of copy: sw|hw\n"
>  		"  -s --ring-size RS: size of IOAT rawdev ring for hardware copy mode or rte_ring for software copy mode\n",
>  		prgname);
>  }
This change is not relevant to this patch, and should be corrected in the original patch of the series. Try to avoid adding a line and then modifying it in a subsequent patch in the same set.

/Bruce

[Marcin] Moved change to first patch.