From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1E1D5A0471 for ; Thu, 18 Jul 2019 15:09:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DC2CE14E8; Thu, 18 Jul 2019 15:09:38 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 617A414E8 for ; Thu, 18 Jul 2019 15:09:36 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Jul 2019 06:09:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,278,1559545200"; d="scan'208";a="187787807" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga001.fm.intel.com with ESMTP; 18 Jul 2019 06:09:29 -0700 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 18 Jul 2019 06:09:29 -0700 Received: from HASMSX110.ger.corp.intel.com (10.184.198.28) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 18 Jul 2019 06:09:28 -0700 Received: from HASMSX109.ger.corp.intel.com ([169.254.3.134]) by HASMSX110.ger.corp.intel.com ([169.254.6.153]) with mapi id 14.03.0439.000; Thu, 18 Jul 2019 16:09:26 +0300 From: "Kusztal, ArkadiuszX" To: Shally Verma , "Nowak, DamianX" , "dev@dpdk.org" CC: "akhil.goyal@nxp.com" , "Trahe, Fiona" Thread-Topic: [PATCH v4 00/11] Rework API for RSA algorithm in asymmetric crypto Thread-Index: AQHVPJ7MCJmafdx+TEqtnC5Rl7CGYabP4iKAgAAgFYCAAEfJQA== Date: Thu, 18 Jul 2019 13:09:25 +0000 Message-ID: <06EE24DD0B19E248B53F6DC8657831551B281083@hasmsx109.ger.corp.intel.com> References: <20190717125111.11288-1-arkadiuszx.kusztal@intel.com> <6976F642F4CB7B4C9D17DE41C99F326055D090CE@hasmsx107.ger.corp.intel.com> In-Reply-To: Accept-Language: pl-PL, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.184.70.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v4 00/11] Rework API for RSA algorithm in asymmetric crypto X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > > > > > Split into smaller commits, in order from least disputable ones. > > > Open things beside this: > > > 1. Creating padding struct > > > 2. Padding parameters (seedlen, optional label etc) 3. Leading > > > zeroes questions. > > > 4. Random number requirements. > > > 5. Capabilities. > > > 6. Verify signature field when none padding. > > > > > > v4: > > > - change API comments from length -> array allocation to avoid > > > ambiguity > > > > > > v3: > > > - split into smaller patches > > > - removed padding struct changes > > > - rebased against patches from CRT patches from Ayuj Verma > > > > > > v2: > > > - Field for singature verification when padding none selected was > > > added > > > - Removed details from RFC > > > - Simplified padding struct > > > - Added padding none test case > > > > > > This patchset depends on following patches: > > > [1] > > > test/crypto: move rsa enqueue/dequeue into separate functions > > > (http://patchwork.dpdk.org/patch/56342/) > > > [2] > > > test/crypto: add tests for RSA key type CRT > > > (http://patchwork.dpdk.org/patch/56343/) > > > > > > Arek Kusztal (11): > > > cryptodev: change RSA API comments about primes > > > cryptodev: add cipher field to RSA op > > > crypto/openssl: add cipher field to openssl RSA implementation > > > test: add cipher field to RSA test > > > cryptodev: add information about message format when signing with > RSA > > > cryptodev: remove RSA PKCS1 BT0 padding > > > openssl: remove RSA PKCS1_5 BT0 padding > > > test: remove RSA PKCS1_5 BT0 padding from test cases > > > cryptodev: add RSA padding none description > > > test: add pkcs1_5 padding simulation > > > test: add RSA PKCS1_5 padding case when no padding selected > > > > > > app/test/test_cryptodev_asym.c | 53 ++++++++++++++++++++--= ---- > > > app/test/test_cryptodev_asym_util.h | 54 > > > +++++++++++++++++++++++++++ > > > drivers/crypto/openssl/rte_openssl_pmd.c | 12 +++--- > > > lib/librte_cryptodev/rte_crypto_asym.h | 64 > > > ++++++++++++++++++++++++-------- > > > 4 files changed, 149 insertions(+), 34 deletions(-) > > > > > > -- > > > 2.1.0 > > > > Series-acked-by: Damian Nowak > I had ack'd some. But others which are Nack'd , we need more time for the= m. > So, from my end, which are Ack'd good to go but other need to wait. As I generally agree that we need far more time to get all things done, I w= ould like to know what is current situation: We should apply 1) Cipher field 2) Remove BT0 We should still discuss (possibly 19.11) 1) Signature input format 2) None padding Is this correct? >=20 > Thanks > Shally