From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 1B741A046B
for <public@inbox.dpdk.org>; Thu, 25 Jul 2019 10:35:49 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 858081C2A8;
Thu, 25 Jul 2019 10:35:48 +0200 (CEST)
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
by dpdk.org (Postfix) with ESMTP id BA1A81C2A7
for <dev@dpdk.org>; Thu, 25 Jul 2019 10:35:46 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga008.jf.intel.com ([10.7.209.65])
by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
25 Jul 2019 01:35:44 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.64,306,1559545200"; d="scan'208";a="164112094"
Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205])
by orsmga008.jf.intel.com with ESMTP; 25 Jul 2019 01:35:44 -0700
Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by
fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS)
id 14.3.439.0; Thu, 25 Jul 2019 01:35:44 -0700
Received: from lcsmsx152.ger.corp.intel.com (10.186.165.231) by
fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS)
id 14.3.439.0; Thu, 25 Jul 2019 01:35:43 -0700
Received: from HASMSX109.ger.corp.intel.com ([169.254.3.134]) by
LCSMSX152.ger.corp.intel.com ([169.254.4.180]) with mapi id 14.03.0439.000;
Thu, 25 Jul 2019 11:35:40 +0300
From: "Kusztal, ArkadiuszX" <arkadiuszx.kusztal@intel.com>
To: Shally Verma <shallyv@marvell.com>, "Nowak, DamianX"
<damianx.nowak@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "Trahe, Fiona" <fiona.trahe@intel.com>, Ayuj Verma <ayverma@marvell.com>,
Sunila Sahu <ssahu@marvell.com>, Kanaka Durga Kotamarthy
<kkotamarthy@marvell.com>, Anoob Joseph <anoobj@marvell.com>, "Narayana
Prasad Raju Athreya" <pathreya@marvell.com>
Thread-Topic: [dpdk-dev] [PATCH v5 1/1] test: new test structure for
asymmetric crypto
Thread-Index: AQHU5IKFVp7P4HphXkK8vll685vq76bbkpHggAApGCA=
Date: Thu, 25 Jul 2019 08:35:40 +0000
Message-ID: <06EE24DD0B19E248B53F6DC8657831551B282BC2@hasmsx109.ger.corp.intel.com>
References: <20190326141549.16125-1-damianx.nowak@intel.com>
<20190327094521.16414-1-damianx.nowak@intel.com>
<20190327094521.16414-2-damianx.nowak@intel.com>
<BN6PR1801MB2052753482415DD93F5CD023ADC10@BN6PR1801MB2052.namprd18.prod.outlook.com>
In-Reply-To: <BN6PR1801MB2052753482415DD93F5CD023ADC10@BN6PR1801MB2052.namprd18.prod.outlook.com>
Accept-Language: pl-PL, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
dlp-product: dlpe-windows
dlp-version: 11.0.600.7
dlp-reaction: no-action
x-originating-ip: [10.184.70.11]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH v5 1/1] test: new test structure for
asymmetric crypto
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
> -----Original Message-----
> From: Shally Verma [mailto:shallyv@marvell.com]
> Sent: Thursday, July 25, 2019 9:18 AM
> To: Nowak, DamianX <damianx.nowak@intel.com>; dev@dpdk.org
> Cc: Trahe, Fiona <fiona.trahe@intel.com>; Kusztal, ArkadiuszX
> <arkadiuszx.kusztal@intel.com>; Ayuj Verma <ayverma@marvell.com>;
> Sunila Sahu <ssahu@marvell.com>; Kanaka Durga Kotamarthy
> <kkotamarthy@marvell.com>; Anoob Joseph <anoobj@marvell.com>;
> Narayana Prasad Raju Athreya <pathreya@marvell.com>
> Subject: RE: [dpdk-dev] [PATCH v5 1/1] test: new test structure for
> asymmetric crypto
>=20
> Hi Damian, Fiona, Arek
>=20
> Though am bit late to come back to this. But I have question on mod_exp t=
est
> vector.
> Please see below.
>=20
> > -----Original Message-----
> > From: dev <dev-bounces@dpdk.org> On Behalf Of Damian Nowak
> > Sent: Wednesday, March 27, 2019 3:15 PM
> > To: dev@dpdk.org
> > Cc: fiona.trahe@intel.com; arkadiuszx.kusztal@intel.com; Damian Nowak
> > <damianx.nowak@intel.com>
> > Subject: [dpdk-dev] [PATCH v5 1/1] test: new test structure for
> > asymmetric crypto
> >
> > This patch adds new test structure for modexp and modinv for
> > asymmetric cryptography
> >
> > Signed-off-by: Damian Nowak <damianx.nowak@intel.com>
> > ---
> > app/test/test_cryptodev.h | 1 +
> > app/test/test_cryptodev_asym.c | 318 ++++++++++
> > app/test/test_cryptodev_mod_test_vectors.h | 967
> > +++++++++++++++++++++++++++++
> > 3 files changed, 1286 insertions(+)
> >
> ...
>=20
> > REGISTER_TEST_COMMAND(cryptodev_openssl_asym_autotest,
> > test_cryptodev_openssl_asym);
> > +
> > +REGISTER_TEST_COMMAND(cryptodev_qat_asym_autotest,
> > test_cryptodev_qat_asym);
> > diff --git a/app/test/test_cryptodev_mod_test_vectors.h
> > b/app/test/test_cryptodev_mod_test_vectors.h
> > index a25c676..c66f4b1 100644
> > --- a/app/test/test_cryptodev_mod_test_vectors.h
> > +++ b/app/test/test_cryptodev_mod_test_vectors.h
> > @@ -1,10 +1,977 @@
> > /* SPDX-License-Identifier: BSD-3-Clause
> > * Copyright(c) 2018 Cavium Networks
> > + * Copyright (c) 2019 Intel Corporation
> > */
> >
> > #ifndef TEST_CRYPTODEV_MOD_TEST_VECTORS_H_
> > #define TEST_CRYPTODEV_MOD_TEST_VECTORS_H_
> >
> > +#define DATA_SIZE 512
> > +
> ...
>=20
> > +static const struct
> > +modex_test_data modex_test_case[] =3D { {
> > + .description =3D "Modular Exponentiation "
> > + "(mod=3D128, base=3D20, exp=3D3, res=3D128)",
> > + .xform_type =3D RTE_CRYPTO_ASYM_XFORM_MODEX,
> ...
> > + .modulus =3D {
> > + .data =3D {
> > + 0xb3, 0xa1, 0xaf, 0xb7, 0x13, 0x08, 0x00, 0x0a,
> There's already a testvector mod_p[] in file with leading 0. Where as I s=
ee
> this one duplicate of that but without leading 0.
> Could you tell me if you ever tested with mod_p[] with leading 0 and if y=
our
> qat PMD passed that?
[AK] - Hi Shally,
The problem with this vector is that it has 1024bit long number but sizeof(=
mod_p) Is 129 bytes (1032 bit).
It is no problem for QAT to get correct result, but test will fail because =
QAT PMD will return 129 bytes of date (with leading zero, number right-shif=
ted) so comparison will fail. This is the same question as padding NONE for=
RSA. Should we trim zeroes, or shouldn't we.
>=20
> > + 0x35, 0xdc, 0x2b, 0x20, 0x8d, 0xa1, 0xb5, 0xce,
> > + 0x47, 0x8a, 0xc3, 0x80, 0xf4, 0x7d, 0x4a, 0xa2,
> > + 0x62, 0xfd, 0x61, 0x7f, 0xb5, 0xa8, 0xde, 0x0a,
> > + 0x17, 0x97, 0xa0, 0xbf, 0xdf, 0x56, 0x5a, 0x3d,
> > + 0x51, 0x56, 0x4f, 0x70, 0x70, 0x3f, 0x63, 0x6a,
> > + 0x44, 0x5b, 0xad, 0x84, 0x0d, 0x3f, 0x27, 0x6e,
> > + 0x3b, 0x34, 0x91, 0x60, 0x14, 0xb9, 0xaa, 0x72,
> > + 0xfd, 0xa3, 0x64, 0xd2, 0x03, 0xa7, 0x53, 0x87,
> > + 0x9e, 0x88, 0x0b, 0xc1, 0x14, 0x93, 0x1a, 0x62,
> > + 0xff, 0xb1, 0x5d, 0x74, 0xcd, 0x59, 0x63, 0x18,
> > + 0x11, 0x3d, 0x4f, 0xba, 0x75, 0xd4, 0x33, 0x4e,
> > + 0x23, 0x6b, 0x7b, 0x57, 0x44, 0xe1, 0xd3, 0x03,
> > + 0x13, 0xa6, 0xf0, 0x8b, 0x60, 0xb0, 0x9e, 0xee,
> > + 0x75, 0x08, 0x9d, 0x71, 0x63, 0x13, 0xcb, 0xa6,
> > + 0x81, 0x92, 0x14, 0x03, 0x22, 0x2d, 0xde, 0x55
> > + },
> > + .len =3D 128
> > + },
> > + .result_len =3D 128
> > +},
> ....
> > /* modular operation test data */
> > uint8_t base[] =3D {
> > 0xF8, 0xBA, 0x1A, 0x55, 0xD0, 0x2F, 0x85,
> > --
> > 2.7.4