From: Ferruh Yigit <ferruh.yigit@intel.com>
To: selwin.sebastian@amd.com, dev@dpdk.org
Cc: asomalap@amd.com
Subject: Re: [dpdk-dev] [PATCH v1] net/axgbe: add support for utility APIs
Date: Mon, 8 Jun 2020 10:41:30 +0100 [thread overview]
Message-ID: <06cfeee7-46ac-3939-6bef-2a494e56bf53@intel.com> (raw)
In-Reply-To: <20200601135703.18815-1-selwin.sebastian@amd.com>
On 6/1/2020 2:57 PM, selwin.sebastian@amd.com wrote:
> From: Selwin Sebastian <selwin.sebastian@amd.com>
>
> Add support for rx, tx queue utility APIs
> Add support for 'fw_revision_get' API
>
> Signed-off-by: Selwin Sebastian <selwin.sebastian@amd.com>
Hi Selwin,
Can you please split this patch into three patches,
1) rx/tx queue start/stop
Please add "Queue start/stop" support in 'axgbe.ini' in this patch
2) Fw version get, and announce "FW version" in .ini file
3) Runtime Rx/Tx queue setup capability, and announce "Runtime Rx queue setup" &
"Runtime Tx queue setup" in .ini file
<...>
> @@ -565,6 +565,95 @@ int axgbe_dev_tx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx,
> return 0;
> }
>
> +int axgbe_dev_tx_queue_start(struct rte_eth_dev *eth_dev,
> + uint16_t queue_idx)
> +{
According coding convention return type should be in above line, this file has
both syntax which is worst. Is there any reason to comply to coding convention
sometimes but not comply other times?
prev parent reply other threads:[~2020-06-08 9:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-01 13:57 selwin.sebastian
2020-06-04 4:48 ` Somalapuram, Amaranath
2020-06-08 9:41 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06cfeee7-46ac-3939-6bef-2a494e56bf53@intel.com \
--to=ferruh.yigit@intel.com \
--cc=asomalap@amd.com \
--cc=dev@dpdk.org \
--cc=selwin.sebastian@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).