DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Dekel Peled <dekelp@mellanox.com>,
	"wenzhuo.lu@intel.com" <wenzhuo.lu@intel.com>,
	"jingjing.wu@intel.com" <jingjing.wu@intel.com>,
	"bernard.iremonger@intel.com" <bernard.iremonger@intel.com>
Cc: Matan Azrad <matan@mellanox.com>, "dev@dpdk.org" <dev@dpdk.org>,
	Ori Kam <orika@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: enhance GTP support
Date: Mon, 6 Apr 2020 12:16:13 +0100	[thread overview]
Message-ID: <06db2d1f-7e5f-d652-a449-6c8696b2d253@intel.com> (raw)
In-Reply-To: <AM4PR0501MB22912C6BA514973A161BC4A4B6C20@AM4PR0501MB2291.eurprd05.prod.outlook.com>

On 4/6/2020 12:05 PM, Dekel Peled wrote:
> Hi Ferruh,
> 
> Is this patch ready to be applied in next-net?

Hi Dekel,

Most probably I can check it today..

> 
> Regards,
> Dekel
> 
>> -----Original Message-----
>> From: Dekel Peled <dekelp@mellanox.com>
>> Sent: Sunday, March 29, 2020 12:21 PM
>> To: wenzhuo.lu@intel.com; jingjing.wu@intel.com;
>> bernard.iremonger@intel.com
>> Cc: Matan Azrad <matan@mellanox.com>; dev@dpdk.org; Ori Kam
>> <orika@mellanox.com>
>> Subject: RE: [dpdk-dev] [PATCH v2] app/testpmd: enhance GTP support
>>
>> Hi,
>>
>> Can this patch be applied?
>>
>> Regards,
>> Dekel
>>
>>> -----Original Message-----
>>> From: Ori Kam <orika@mellanox.com>
>>> Sent: Wednesday, March 25, 2020 10:28 AM
>>> To: Dekel Peled <dekelp@mellanox.com>; wenzhuo.lu@intel.com;
>>> jingjing.wu@intel.com; bernard.iremonger@intel.com
>>> Cc: Matan Azrad <matan@mellanox.com>; dev@dpdk.org
>>> Subject: RE: [dpdk-dev] [PATCH v2] app/testpmd: enhance GTP support
>>>
>>>
>>>
>>>> -----Original Message-----
>>>> From: dev <dev-bounces@dpdk.org> On Behalf Of Dekel Peled
>>>> Sent: Wednesday, March 25, 2020 10:13 AM
>>>> To: Ori Kam <orika@mellanox.com>; wenzhuo.lu@intel.com;
>>>> jingjing.wu@intel.com; bernard.iremonger@intel.com
>>>> Cc: Matan Azrad <matan@mellanox.com>; dev@dpdk.org
>>>> Subject: [dpdk-dev] [PATCH v2] app/testpmd: enhance GTP support
>>>>
>>>> This patch adds CLI option to enter the v_pt_rsv_flags value for GTP
>>>> flow pattern item.
>>>> It also adds GTP as valid item in raw_encap and raw_decap setting.
>>>>
>>>> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
>>>> ---
>>>> v2: remove redundant hton flag.
>>>> ---
>>>>  app/test-pmd/cmdline_flow.c | 15 +++++++++++++--
>>>>  1 file changed, 13 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/app/test-pmd/cmdline_flow.c
>>>> b/app/test-pmd/cmdline_flow.c index a781545..4877ac6 100644
>>>> --- a/app/test-pmd/cmdline_flow.c
>>>> +++ b/app/test-pmd/cmdline_flow.c
>>>> @@ -170,6 +170,7 @@ enum index {
>>>>  	ITEM_FUZZY,
>>>>  	ITEM_FUZZY_THRESH,
>>>>  	ITEM_GTP,
>>>> +	ITEM_GTP_FLAGS,
>>>>  	ITEM_GTP_MSG_TYPE,
>>>>  	ITEM_GTP_TEID,
>>>>  	ITEM_GTPC,
>>>> @@ -938,6 +939,7 @@ struct parse_action_priv {  };
>>>>
>>>>  static const enum index item_gtp[] = {
>>>> +	ITEM_GTP_FLAGS,
>>>>  	ITEM_GTP_MSG_TYPE,
>>>>  	ITEM_GTP_TEID,
>>>>  	ITEM_NEXT,
>>>> @@ -2347,12 +2349,18 @@ static int comp_set_raw_index(struct context
>>>> *, const struct token *,
>>>>  		.next = NEXT(item_gtp),
>>>>  		.call = parse_vc,
>>>>  	},
>>>> +	[ITEM_GTP_FLAGS] = {
>>>> +		.name = "v_pt_rsv_flags",
>>>> +		.help = "GTP flags",
>>>> +		.next = NEXT(item_gtp, NEXT_ENTRY(UNSIGNED),
>>>> item_param),
>>>> +		.args = ARGS(ARGS_ENTRY(struct rte_flow_item_gtp,
>>>> +					v_pt_rsv_flags)),
>>>> +	},
>>>>  	[ITEM_GTP_MSG_TYPE] = {
>>>>  		.name = "msg_type",
>>>>  		.help = "GTP message type",
>>>>  		.next = NEXT(item_gtp, NEXT_ENTRY(UNSIGNED),
>>> item_param),
>>>> -		.args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_gtp,
>>>> -					     msg_type)),
>>>> +		.args = ARGS(ARGS_ENTRY(struct rte_flow_item_gtp,
>>>> msg_type)),
>>>>  	},
>>>>  	[ITEM_GTP_TEID] = {
>>>>  		.name = "teid",
>>>> @@ -6604,6 +6612,9 @@ static int comp_set_raw_index(struct context
>>>> *, const struct token *,
>>>>  			size = sizeof(struct rte_flow_item_ah);
>>>>  			proto = 0x33;
>>>>  			break;
>>>> +		case RTE_FLOW_ITEM_TYPE_GTP:
>>>> +			size = sizeof(struct rte_flow_item_gtp);
>>>> +			break;
>>>>  		case RTE_FLOW_ITEM_TYPE_PFCP:
>>>>  			size = sizeof(struct rte_flow_item_pfcp);
>>>>  			break;
>>>> --
>>>> 1.8.3.1
>>>
>>> Acked-by: Ori Kam <orika@mellanox.com> Thanks, Ori


  reply	other threads:[~2020-04-06 11:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-16  8:14 [dpdk-dev] [PATCH] " Dekel Peled
2020-03-24  9:58 ` Ori Kam
2020-03-24 12:39   ` Dekel Peled
2020-03-25  8:12 ` [dpdk-dev] [PATCH v2] " Dekel Peled
2020-03-25  8:27   ` Ori Kam
2020-03-29  9:20     ` Dekel Peled
2020-04-06 11:05       ` Dekel Peled
2020-04-06 11:16         ` Ferruh Yigit [this message]
2020-04-06 15:41     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=06db2d1f-7e5f-d652-a449-6c8696b2d253@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=bernard.iremonger@intel.com \
    --cc=dekelp@mellanox.com \
    --cc=dev@dpdk.org \
    --cc=jingjing.wu@intel.com \
    --cc=matan@mellanox.com \
    --cc=orika@mellanox.com \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).