From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 29A91A0577; Mon, 6 Apr 2020 13:16:21 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2FBFB1BED8; Mon, 6 Apr 2020 13:16:20 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id C336CF12 for ; Mon, 6 Apr 2020 13:16:17 +0200 (CEST) IronPort-SDR: QsRHh/qTEI8o1t+vwKpG1uo1PiANZ5QXCMcASuaBDGbXame2xdZG8nAVCMdUxnPYsMvrebuH/l J5+b2j9jDqKw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Apr 2020 04:16:16 -0700 IronPort-SDR: rb6kh3BTLXXi89BEsHp0Hbcam/XolixaXXdtU8mnXdf0bFYwvTB0adU0TgYPEquEZx9h8DF8RF UH4fJ7GpoaQA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,350,1580803200"; d="scan'208";a="424323560" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.251.92.43]) ([10.251.92.43]) by orsmga005.jf.intel.com with ESMTP; 06 Apr 2020 04:16:14 -0700 To: Dekel Peled , "wenzhuo.lu@intel.com" , "jingjing.wu@intel.com" , "bernard.iremonger@intel.com" Cc: Matan Azrad , "dev@dpdk.org" , Ori Kam References: <239bc0ae9191ddc12fec65742949710d13185b85.1584346077.git.dekelp@mellanox.com> <849037cfb86ddbce85675606f8a81090044e97e1.1585123614.git.dekelp@mellanox.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEAFiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl1meboFCQlupOoACgkQ+TPrQ98T YR9ACBAAv2tomhyxY0Tp9Up7mNGLfEdBu/7joB/vIdqMRv63ojkwr9orQq5V16V/25+JEAD0 60cKodBDM6HdUvqLHatS8fooWRueSXHKYwJ3vxyB2tWDyZrLzLI1jxEvunGodoIzUOtum0Ce gPynnfQCelXBja0BwLXJMplM6TY1wXX22ap0ZViC0m714U5U4LQpzjabtFtjT8qOUR6L7hfy YQ72PBuktGb00UR/N5UrR6GqB0x4W41aZBHXfUQnvWIMmmCrRUJX36hOTYBzh+x86ULgg7H2 1499tA4o6rvE13FiGccplBNWCAIroAe/G11rdoN5NBgYVXu++38gTa/MBmIt6zRi6ch15oLA Ln2vHOdqhrgDuxjhMpG2bpNE36DG/V9WWyWdIRlz3NYPCDM/S3anbHlhjStXHOz1uHOnerXM 1jEjcsvmj1vSyYoQMyRcRJmBZLrekvgZeh7nJzbPHxtth8M7AoqiZ/o/BpYU+0xZ+J5/szWZ aYxxmIRu5ejFf+Wn9s5eXNHmyqxBidpCWvcbKYDBnkw2+Y9E5YTpL0mS0dCCOlrO7gca27ux ybtbj84aaW1g0CfIlUnOtHgMCmz6zPXThb+A8H8j3O6qmPoVqT3qnq3Uhy6GOoH8Fdu2Vchh TWiF5yo+pvUagQP6LpslffufSnu+RKAagkj7/RSuZV25Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXWZ5wAUJB3FgggAKCRD5M+tD3xNhH2O+D/9OEz62YuJQLuIuOfL67eFTIB5/1+0j8Tsu o2psca1PUQ61SZJZOMl6VwNxpdvEaolVdrpnSxUF31kPEvR0Igy8HysQ11pj8AcgH0a9FrvU /8k2Roccd2ZIdpNLkirGFZR7LtRw41Kt1Jg+lafI0efkiHKMT/6D/P1EUp1RxOBNtWGV2hrd 0Yg9ds+VMphHHU69fDH02SwgpvXwG8Qm14Zi5WQ66R4CtTkHuYtA63sS17vMl8fDuTCtvfPF HzvdJLIhDYN3Mm1oMjKLlq4PUdYh68Fiwm+boJoBUFGuregJFlO3hM7uHBDhSEnXQr5mqpPM 6R/7Q5BjAxrwVBisH0yQGjsWlnysRWNfExAE2sRePSl0or9q19ddkRYltl6X4FDUXy2DTXa9 a+Fw4e1EvmcF3PjmTYs9IE3Vc64CRQXkhujcN4ZZh5lvOpU8WgyDxFq7bavFnSS6kx7Tk29/ wNJBp+cf9qsQxLbqhW5kfORuZGecus0TLcmpZEFKKjTJBK9gELRBB/zoN3j41hlEl7uTUXTI JQFLhpsFlEdKLujyvT/aCwP3XWT+B2uZDKrMAElF6ltpTxI53JYi22WO7NH7MR16Fhi4R6vh FHNBOkiAhUpoXRZXaCR6+X4qwA8CwHGqHRBfYFSU/Ulq1ZLR+S3hNj2mbnSx0lBs1eEqe2vh cA== Message-ID: <06db2d1f-7e5f-d652-a449-6c8696b2d253@intel.com> Date: Mon, 6 Apr 2020 12:16:13 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: enhance GTP support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/6/2020 12:05 PM, Dekel Peled wrote: > Hi Ferruh, > > Is this patch ready to be applied in next-net? Hi Dekel, Most probably I can check it today.. > > Regards, > Dekel > >> -----Original Message----- >> From: Dekel Peled >> Sent: Sunday, March 29, 2020 12:21 PM >> To: wenzhuo.lu@intel.com; jingjing.wu@intel.com; >> bernard.iremonger@intel.com >> Cc: Matan Azrad ; dev@dpdk.org; Ori Kam >> >> Subject: RE: [dpdk-dev] [PATCH v2] app/testpmd: enhance GTP support >> >> Hi, >> >> Can this patch be applied? >> >> Regards, >> Dekel >> >>> -----Original Message----- >>> From: Ori Kam >>> Sent: Wednesday, March 25, 2020 10:28 AM >>> To: Dekel Peled ; wenzhuo.lu@intel.com; >>> jingjing.wu@intel.com; bernard.iremonger@intel.com >>> Cc: Matan Azrad ; dev@dpdk.org >>> Subject: RE: [dpdk-dev] [PATCH v2] app/testpmd: enhance GTP support >>> >>> >>> >>>> -----Original Message----- >>>> From: dev On Behalf Of Dekel Peled >>>> Sent: Wednesday, March 25, 2020 10:13 AM >>>> To: Ori Kam ; wenzhuo.lu@intel.com; >>>> jingjing.wu@intel.com; bernard.iremonger@intel.com >>>> Cc: Matan Azrad ; dev@dpdk.org >>>> Subject: [dpdk-dev] [PATCH v2] app/testpmd: enhance GTP support >>>> >>>> This patch adds CLI option to enter the v_pt_rsv_flags value for GTP >>>> flow pattern item. >>>> It also adds GTP as valid item in raw_encap and raw_decap setting. >>>> >>>> Signed-off-by: Dekel Peled >>>> --- >>>> v2: remove redundant hton flag. >>>> --- >>>> app/test-pmd/cmdline_flow.c | 15 +++++++++++++-- >>>> 1 file changed, 13 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/app/test-pmd/cmdline_flow.c >>>> b/app/test-pmd/cmdline_flow.c index a781545..4877ac6 100644 >>>> --- a/app/test-pmd/cmdline_flow.c >>>> +++ b/app/test-pmd/cmdline_flow.c >>>> @@ -170,6 +170,7 @@ enum index { >>>> ITEM_FUZZY, >>>> ITEM_FUZZY_THRESH, >>>> ITEM_GTP, >>>> + ITEM_GTP_FLAGS, >>>> ITEM_GTP_MSG_TYPE, >>>> ITEM_GTP_TEID, >>>> ITEM_GTPC, >>>> @@ -938,6 +939,7 @@ struct parse_action_priv { }; >>>> >>>> static const enum index item_gtp[] = { >>>> + ITEM_GTP_FLAGS, >>>> ITEM_GTP_MSG_TYPE, >>>> ITEM_GTP_TEID, >>>> ITEM_NEXT, >>>> @@ -2347,12 +2349,18 @@ static int comp_set_raw_index(struct context >>>> *, const struct token *, >>>> .next = NEXT(item_gtp), >>>> .call = parse_vc, >>>> }, >>>> + [ITEM_GTP_FLAGS] = { >>>> + .name = "v_pt_rsv_flags", >>>> + .help = "GTP flags", >>>> + .next = NEXT(item_gtp, NEXT_ENTRY(UNSIGNED), >>>> item_param), >>>> + .args = ARGS(ARGS_ENTRY(struct rte_flow_item_gtp, >>>> + v_pt_rsv_flags)), >>>> + }, >>>> [ITEM_GTP_MSG_TYPE] = { >>>> .name = "msg_type", >>>> .help = "GTP message type", >>>> .next = NEXT(item_gtp, NEXT_ENTRY(UNSIGNED), >>> item_param), >>>> - .args = ARGS(ARGS_ENTRY_HTON(struct rte_flow_item_gtp, >>>> - msg_type)), >>>> + .args = ARGS(ARGS_ENTRY(struct rte_flow_item_gtp, >>>> msg_type)), >>>> }, >>>> [ITEM_GTP_TEID] = { >>>> .name = "teid", >>>> @@ -6604,6 +6612,9 @@ static int comp_set_raw_index(struct context >>>> *, const struct token *, >>>> size = sizeof(struct rte_flow_item_ah); >>>> proto = 0x33; >>>> break; >>>> + case RTE_FLOW_ITEM_TYPE_GTP: >>>> + size = sizeof(struct rte_flow_item_gtp); >>>> + break; >>>> case RTE_FLOW_ITEM_TYPE_PFCP: >>>> size = sizeof(struct rte_flow_item_pfcp); >>>> break; >>>> -- >>>> 1.8.3.1 >>> >>> Acked-by: Ori Kam Thanks, Ori