From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C3DE0A0C46; Fri, 18 Jun 2021 10:27:17 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4DB5240150; Fri, 18 Jun 2021 10:27:17 +0200 (CEST) Received: from de-smtp-delivery-102.mimecast.com (de-smtp-delivery-102.mimecast.com [194.104.111.102]) by mails.dpdk.org (Postfix) with ESMTP id 9B6AF40150 for ; Thu, 17 Jun 2021 10:25:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=mimecast20200619; t=1623918300; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bfSuOV5f0kQJLj0jP2R0Ax8IAS3t7lUlz8UjdeB1r5I=; b=W34DiKe7LR6OyCIkCic7bmvJNKTuf6ZAoKPV/sbLndIdzwGswIImx0vOX+OHKv9bosHMwx SwSb8PDripZPY6/JUUBaC8spbGMQ/f7sxlMrHAbCtHar4GU3Fj1SQMCBhSdFOxEVJR2/d5 tGXHpvikGqkatX45foadRc1oo3JG87o= Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01lp2051.outbound.protection.outlook.com [104.47.0.51]) (Using TLS) by relay.mimecast.com with ESMTP id de-mta-4-9AFO3hc3P4Cy340Ujgz77A-1; Thu, 17 Jun 2021 10:24:58 +0200 X-MC-Unique: 9AFO3hc3P4Cy340Ujgz77A-1 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AD94hbcRQI2lJMlDiRB5SHXxJRrRGLZJ+JbPrAbn1cYOpdBBC5qiBReIzh8ZiJfBpEFxVPXCG04M6yy8PR0im5PLpuse+ynJv1IcYulinTXsukJkPDiDG7/IvlxXfjlmefIr62EbQDMvNb5qTDs75kz9TW3S+lYUwQ2SvnTPE+XSdSVUk/K4d3FL3ldTNTXA9VrWZ4zl2OT4wP+lnq+41F2IsLpA8OXqjP/06MhHNMNojVrOQ/iCd0cWTbvPM0FifT09gflvSzNRX8drGuRvx2sZnVjt2DnZUOdUuHZvGZ1XN+2KHjR/S0b8uOpXhSh5nkb4qTxqnJ2xzyIP30BC/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bfSuOV5f0kQJLj0jP2R0Ax8IAS3t7lUlz8UjdeB1r5I=; b=QPADp2xHfwS/4GKHf0Hzf7EbHb5zEHV+UBMcq/5x34alRixq6hNCZAbRu8dXFjcthXmbG7mg2NI+Smp35c5NmygpYENbYcuU5TWe/MR3S+xfPovNjGpwT+sIgC+rxrIOdoMddeolT1V3J7upCS9Wf7oCXnP/j4oNVFQpmZ06g3bj9RlTL3iiSRDudq/J7o98PssGTrSqcPb95V34e0KuWXbDs/WY+aXhMGJ4tjgS6jhaeZwgQns9EzOdCdVWK/X+0epq08bWV7bxkCGWAm/ARF6KOIjS7EmQJWU+PfJuJHFiwmm+rYHFfA3qLrTXERD3eFT1o9dHZDWSP7drd56QxQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none Authentication-Results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=suse.com; Received: from VI1PR04MB3085.eurprd04.prod.outlook.com (2603:10a6:802:6::17) by VI1PR0401MB2271.eurprd04.prod.outlook.com (2603:10a6:800:29::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.24; Thu, 17 Jun 2021 08:24:54 +0000 Received: from VI1PR04MB3085.eurprd04.prod.outlook.com ([fe80::618f:84e9:dd0d:ea34]) by VI1PR04MB3085.eurprd04.prod.outlook.com ([fe80::618f:84e9:dd0d:ea34%4]) with mapi id 15.20.4242.019; Thu, 17 Jun 2021 08:24:54 +0000 To: Thomas Monjalon , Ferruh Yigit , Christian Ehrhardt Cc: dev , dpdk stable , Thomas Bogendoerfer , "jcaamano@suse.com" , "snmohan83@gmail.com" , "ndas@suse.de" References: <20210602143317.2333707-1-christian.ehrhardt@canonical.com> <1708042.2qKnxoAoZE@thomas> From: Marco Varlese Message-ID: <06e1242e-5970-36e9-cb0a-358639168616@suse.com> Date: Thu, 17 Jun 2021 10:24:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 In-Reply-To: <1708042.2qKnxoAoZE@thomas> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [94.101.56.30] X-ClientProxiedBy: ZR0P278CA0122.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:20::19) To VI1PR04MB3085.eurprd04.prod.outlook.com (2603:10a6:802:6::17) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from linux.local (94.101.56.30) by ZR0P278CA0122.CHEP278.PROD.OUTLOOK.COM (2603:10a6:910:20::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4242.15 via Frontend Transport; Thu, 17 Jun 2021 08:24:53 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0bb12160-65e7-4ada-d34a-08d93169628a X-MS-TrafficTypeDiagnostic: VI1PR0401MB2271: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eYZDSOlC/4F8cRU0xosdt5YCW3TBMgb+kepF9xCZP2ZpH+dofrdw/P6Lq1NPy3n025VLfoeOzk0QVW1RO/tjrLgtTauqBS/5ULd6FD3CyET2IOOwRTT/BwMaMYw+WMonFiAfSYcjtPYQlcRQzYG1ZKjl5w9IoymrRAEx2oL1kc0Fu2MxngOTqvblNzFupy3164RsCUxI1dsb8orwshLLH1sJkT8Slvwsjia/Lk5EPbBAaCyGb2HAE4dmdHELYrLi9Nk/2X6L0ni7Foh9PqVTGdRcSYXPA6LiHS5iyVvteAEILtqRScAkglPl0uDyYUBWH4y1kxuP3v9HWJXltINlVfamA2hLXN2tLUQcDQF4F9axfm/jQ/Hk2E3s8LhDJa+V9KrWP0RW+qQJWZd3NjT79inTAmXwOe37UQFqqoiPT4dCvNLn7eytV+WkRZ9Qn0syOnML+bvOEUXu3SYMy5HcKXVM4ysdUrorVSuBiEBbEZptIci9o2R5kA0PsTjtsBZQcTja2j+vlHbQ7XJ6k22mU40yKDhztUzXZYj9Do2JhJN46IjsaAu4P8LAMily6sdpaRk3WboEPp6rhaf+5x4dOKi+nYui7DisSljwWlZnoL/DpbnHwynjMtxbD+AKpjkvSYimq+ll6lLIQVsDECtDnF5oJqqBoqiuue0udMIWHomUxoKdXyk1HrFsdF62tw6JLihzXseVcMYxaV40oWqgZ8FyRTIQ8GZXEwznBYApoFLJDyX6oB+kwao70lfJW/W/Uv4qfn5t1RWTQ8zZ8rXncYLMfl86JiErT3RBmIUO2lLtYZ8oyb9XuEO7IMdUnjwWy6D24wZgVGfitNxcXMGfag== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR04MB3085.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(376002)(396003)(136003)(39860400002)(346002)(478600001)(6512007)(16526019)(8676002)(186003)(38100700002)(8936002)(2616005)(956004)(4326008)(54906003)(5660300002)(2906002)(110136005)(44832011)(36756003)(26005)(66946007)(86362001)(316002)(966005)(6506007)(53546011)(66556008)(66476007)(31686004)(31696002)(6486002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y0pIQVV2ZVdjWW9nMGxiTDRlcitrbU11WmdUT3dBaUw3Q3JXNGpMZlBmVStS?= =?utf-8?B?QVJ1eEVqZ1MxUmUvQXcvOC9KVE1EakpoOE1aNG5ZYk9GcnJ1VHA0ZEZGSCtG?= =?utf-8?B?OGtRelZjekp2ZndIbEtuSkJUSTFRU0piYlprTnQ3NEZkTldqVHMxTFphdEJ5?= =?utf-8?B?eS95QWxhUWt3RDBvd0xGR3lYUmdGQTRjWVBpamtIYUpmLzVqUEVhMkNyQkpk?= =?utf-8?B?RXgxamVQWXhFLzhGcFlyTjE0VW5iOXNiai81azVIa0tDc3M1K2xNbUQyeVh0?= =?utf-8?B?UnRGMDFabWExUXlNVjk4WHJZNW9mOStSTXcvaGs3Z1grQzlUUDNwNVVNaGZk?= =?utf-8?B?bzhsSTMxbW1IK1NCaUQzd1FySmNVRzVXcXMzZ2tYT3pUaitBZ3U1d0VFbnZP?= =?utf-8?B?NjR4TUVxY0RhNG5UWXBmUW5UMHhxY3BWWlR1WUJjaTFCQ2crZVZwbFZCUU9y?= =?utf-8?B?aU9GWXRGNktBYTBTSm9jdDNjQlEyUXoyYkp5MjEzTThJZDBrNjZzSXZsZ1k5?= =?utf-8?B?bVlkSE12YzZGZDFySCtQWGFFUTZydnZES2dVVG9kZ0U1OWRMNWt6TjZYUDRT?= =?utf-8?B?L2VlRFQ5YjVkZVpuQ1hBeDRzakptckduUThMVHpnM2tpSnVuM0RTSExhQkFX?= =?utf-8?B?MnFZY1VmWnpsdmN5VXo4cHgrSFNFUGNjdHFNbHZoaUdrOE5uQ3p5Q1kyb3My?= =?utf-8?B?dVVNUUpDRms4dVp6d2NwK2tjZ3NhNlVnUzhwS3ZwU1UxYTIvK0ZJb1RtVzRs?= =?utf-8?B?TWJtSnA5MC9aVGw4VUxRc2VpaUZ0cWRqT0l6ZXRHRFFvNEEvRHR5OW5PMFEw?= =?utf-8?B?TTBtZ1o4T3d3bTdQRkhTZFVNeDY0RFRzUVdzOGRxQ29YU0RwbFQ5WHRDVnB0?= =?utf-8?B?RVNKaTVCOEpOcW80aW9FNzdVa2JZOU4yRlBqWDJhTGRVMWtLZHAwUFVqeFhN?= =?utf-8?B?UDNsWmh6dDM3NW9PWTN6azNuL09rNDlqb3JjT3N3V3c3bUdMOWN2dDFqbitG?= =?utf-8?B?UllhSkxCSnlYYTBFM285UEVUck1oMWpna1YzMUdtSVIrVmo5Tm9EK3Z1Qkw1?= =?utf-8?B?Y0M1MDY1VnYxbGJsUlA4ajltdXRGSDJNUm0xTDNRTzZobytpYmltd3k1VEtU?= =?utf-8?B?UkM2MnFFaFRDanN6UFRLNjRWYWo4enA3U2NCL3BESjg0ZFpMN2NSdG02OVNv?= =?utf-8?B?Ykx3YUhhbGlZckFhZW84QzR2bmtkenlsayttVXVpREZQaThXTjAwbWp3dTM1?= =?utf-8?B?N3FqRHVEN1BrVUZMS3FDWFlHeHpmYmVoVzR2RkF6Qkdqa2dZNy8raUd1NUdK?= =?utf-8?B?U3hrNnZNOTdpZjNlODNJWkJ1VkJMUWxJVGxLLy8yRDlKTzRVaElTZUM4R1J6?= =?utf-8?B?QmQyQkppUGJxUkJ6KzV5OTFiUytyRWo3VnJLMkxXTTlxb0Y4dmlNL0xaOUty?= =?utf-8?B?SGRRWjV0aU5ZU0lJdnhCcjhGbnR1NkFtemhRYkpQOEV6R3JwVTlMMEEzWFIw?= =?utf-8?B?RW1VeU9adzU4cU9xY1pZd0w0czJneW4zeG9VYnZrclZBMXN6STRoazlUMkZZ?= =?utf-8?B?NUFwaUpPbjVEVEtSTDBGNG9vdUd1SXBGL3N0TmNTNEpCa3M0c3NSL3dtZlZJ?= =?utf-8?B?WW5TMU9ETGNqOFZqdGtTS3dLWXN2SjBzU1dJakxVaStYVVNuUGlXOEUrNllh?= =?utf-8?B?ZVE2ZldJZTUwSXc5TlM2cUJLNXAzQUM5Wm9TVVRUK2tLaENPak9UODV1WW0r?= =?utf-8?Q?EF+rfEL35n3OTGBXea4OIYNSlmdexHqHCSoLbBC?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0bb12160-65e7-4ada-d34a-08d93169628a X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB3085.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jun 2021 08:24:54.6946 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: l2D+uQN1dn09ZvM08f459qU9enJL0UnK8keNbTGqWbBOevKBnOVVs7Kmj/kZjOqAVcwUUVRI6O+34ocAqX5UGA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2271 X-Mailman-Approved-At: Fri, 18 Jun 2021 10:27:16 +0200 Subject: Re: [dpdk-dev] [PATCH] kni: fix compilation on SLES15-SP3 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello, On 6/17/21 8:41 AM, Thomas Monjalon wrote: > 17/06/2021 08:14, Christian Ehrhardt: >> On Thu, Jun 10, 2021 at 12:30 PM Christian Ehrhardt >> wrote: >>> On Thu, Jun 10, 2021 at 10:39 AM Christian Ehrhardt >>> wrote: >>>> On Tue, Jun 8, 2021 at 1:17 PM Ferruh Yigit wrote: >>>>> On 6/2/2021 3:33 PM, Christian Ehrhardt wrote: >>>>>> Like what was done for mainline kernel in commit 38ad54f3bc76 ("kni: fix >>>>>> build with Linux 5.6"), a new parameter 'txqueue' has to be added to >>>>>> 'ndo_tx_timeout' ndo on SLES 15-SP3 kernel. >>>>>> >>>>>> Caused by: >>>>>> commit c3bf155c40e9db722feb8a08c19efd44c12d5294 >>>>>> Author: Thomas Bogendoerfer >>>>>> Date: Fri Sep 11 16:08:31 2020 +0200 >>>>>> - netdev: pass the stuck queue to the timeout handler >>>>>> (jsc#SLE-13536). >>>>>> - Refresh patches.suse/sfc-move-various-functions.patch. >>>>>> >>>>>> That is part of the SLES 5.3.18 kernel and therefore the >>>>>> version we check for. >>>>>> >>>>>> Cc: stable@dpdk.org >>>>>> >>>>>> Signed-off-by: Christian Ehrhardt >>>>> Hi Christian, >>>>> >>>>> There is a build error reported in CI [1] with 'SUSE15-64'. >>>>> Can't the check 'linux version >= 5.3.18" may hit multiple SUSE versions, with >>>>> some has the patch mentioned above backported and some did not? >>>>> Can 'SLE_VERSION_CODE' be used to differentiate the SUSE versions? >>>> I don't have a perfect insight in the SUSE distro variants and their >>>> kernel versions. >>>>> 5.3.18 in SLES15-SP3 was what broke it and I have hoped that this would apply in general. >>>> But the error above seems we have others that are > 5.3.18 but at the >>>> same time not have the backport. >>>> >>>> I'll try to create a v3, but do we have anyone from Suse to usually >>>> directly ping for feedback on this? >>> With the new version (not submitted since it fails me) you can have a >>> look at my personal WIP branch: >>> => https://github.com/cpaelzer/dpdk-stable-queue/commit/43b908fe83e9cd68b08e259c0ace26ec692bb737 >> Hello everyone, >> Ferruh and I reached out to the Suse people working on DPDK in the >> past as well as those doing the kernel backport that breaks it now. >> (I'll add them to CC here as well) >> Unfortunately there was no feedback in a week, but OTOH I also don't >> want to stall releases for too long due to this. >> >> I'll try to summarize the current understanding of this case again >> >> [1] breaks our KNI build. >> >> SLE_VERSION isn't provided by their Kernel; it is in DPDKs >> kernel/linux/kni/compat.h and not further maintained for a while. >> So we can't differentiate SLE15SP2 vs SLE15SP3 via that. >> >> The offending change was introduced in their kernel by [1] >> $ git tag --contains c3bf155c40e9 | sort | head >> rpm-5.3.18-24 >> ... >> >> But checking just the kernel version 5.3.18 (as my initial patch had) >> won't work either. >> The problem is that this only checks the three levels of kernel >> version, but not the packaging level. >> And to make things even more fun, while I don't know if opensuse leap >> has the patch applied or not atm, but the kernel version there might >> make this even more complex as it is 5.3.18-lp152 at the moment. >> >> We have now: >> SLE15 SP2 5.3.18-22 >> SLE15 SP3 5.3.18-57 (>=24) >> opensuse_leap 5.3.18-lp152 >> >> Without a change SLE15SP3 is broken due to that backport. >> By checking on >=5.3.18 we could fix SP3, but break SP2 and maybe opensuse_leap. >> >> Maybe there is something on LOCALVERSION/EXTRAVERSION we can use, but >> "guessing" how the Suse kernel behaves isn't a good approach. You could try using these: -- CONFIG_SUSE_VERSION -- CONFIG_SUSE_PATCHLEVEL for your build-time dependencies. It's as fragile as the approach of using KERNEL_VERSION but it might help with the current issue. >> Once Suse lets us know how to better differentiate their packaging >> version we can reconsider a proper fix for this. >> >> But without further input from Suse I'd (for now) ask to keep things >> as is (= not applying my patch). >> Due to that it will build in the same places it has built in the past. >> If we find a solution it can be in the next release in ~3 months, but >> I'll not further stall e.g. 19.11.9 that I'm working on right now. >> >> [1]: https://github.com/SUSE/kernel/commit/c3bf155c40e9 > Thank you for the summary. > > This explains well why we should stop supporting KNI. > >