From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 33070433A7; Thu, 23 Nov 2023 11:26:37 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AC6AD402A6; Thu, 23 Nov 2023 11:26:36 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2075.outbound.protection.outlook.com [40.107.223.75]) by mails.dpdk.org (Postfix) with ESMTP id 6D0D74026B for ; Thu, 23 Nov 2023 11:26:35 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bctdzszdehocchJQ5qoiCZRr79gqKX+TYuBvKy7s809O8HtVq2xlTdBXeAfFCCAzWevqTn3SuyJFxCowayhI9Fcs+GSBt1RMtyMHfGEqJZM+qIW7zCpKcaEipA7XDFi0v6Rk3YDc3uHvCbUGdYAPtlOUHquUBARpe8kd2NpemDJJaXszYfr8b9ztVfjfJ33Ul8+doi6BxGn96IiNrb3aNOgwqQeFcZWabhXd3R+83VCI8ATnw/ALUDxQOICCRqLh/Q3zJ30GSSepQVkzzV9/MMZy1r4hRVRHs9zz4/40PE2mW4w4sgFhFeVmYMoq9W6yEpILLL5d2kaw1677LYfvcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VxjPOx1boEpSDRRTQ7G3Y+88tyB/sgDe1m2BE+ndkdc=; b=cA5uhzV/tHUiTjACFmIqMHtRWdkjxvZ1OaslVLQOPxsFsZGTF2xFQI8/6vkr2WZcEn3iRmvDlLawUE7IPd3X1K9sP685dyfWO/PREgqiv23xTgMDsZRnI+y5Or3dei8zA5VD9FWsZma/6c0JAz2B+u/0xB67ZspUqXTg7clxRJvozfmNya2WnMAKFHwlTRcFEU5dT7bLbZKKpIorXylLqTHLID7yEVUDdYK8BuBR0cv0WnA+oi4H9Bsv/JjgkcPx00oLMgDM5Chg6L8wU/ankhnd72i6qUwNlG2AvAkfSWaiHchfgDASbfrse5JRJawe6kNE/47kYJq8pgnCxiJG6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VxjPOx1boEpSDRRTQ7G3Y+88tyB/sgDe1m2BE+ndkdc=; b=bsmuZGUiE4CY1Rd5aSXw5uHKImovNG+3+wWFYazfPjnSibNiGmnToHn4oPLmqA8SqIDchMCNsAWK07NwiE28WsrdUBO7tks5givbzcCCEH2X1HC5Eppp/qJtzgAu8LEM1AwtkJl2h1DpbPhXMPP9au9xUPoR4PDtjZr5t172XCE= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SJ0PR12MB7006.namprd12.prod.outlook.com (2603:10b6:a03:486::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.20; Thu, 23 Nov 2023 10:26:32 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f%6]) with mapi id 15.20.7025.021; Thu, 23 Nov 2023 10:26:31 +0000 Message-ID: <070f31e1-fd8a-4883-b6d5-b809bf2bf16e@amd.com> Date: Thu, 23 Nov 2023 10:26:24 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] examples/l3fwd-power: fix to configure the uncore env Content-Language: en-US To: Thomas Monjalon , Sivaprasad Tummala Cc: david.hunt@intel.com, anatoly.burakov@intel.com, david.marchand@redhat.com, dev@dpdk.org, john.mcnamara@intel.com, karen.kelly@intel.com References: <20231026151959.1458112-1-sivaprasad.tummala@amd.com> <25240705.EfDdHjke4D@thomas> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <25240705.EfDdHjke4D@thomas> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR4P281CA0082.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:cd::12) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SJ0PR12MB7006:EE_ X-MS-Office365-Filtering-Correlation-Id: 2646699c-03bf-467e-3b12-08dbec0ea825 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WrLcUZ3vABsvsoqy2yV3TXG31VlivXen7ppEB6LekATtj1LYlykx7HZdFhFXXwoGcIyDZxSWE5hfzjNmIeZaTeIZqg+JYirpBftF6tETHu1kk5RR71G2ftmPN09G2EXRjrMuUB06c/qxIwjTDr4lnltA91Dp4JDBm5e79jqFew/5I/MA4oaXMTgbTRkidHXqnlK+wN7xOrB/RHpOg/OLPFYcNlS9poU32eB3wuMOUEIYd9wktftlW6AOwuTJN3RSqCLB+0yUm/krkWV1jEHTFCZLIhvMAWNuKIoFI2P/dNNI3sp1Q+/E4UyFC16UTjrxRco0C679W7ICymq8BRPzWnjlqLx27ILgVSXonJk9xTdcSuZ79xmmG847Is7KHSxNFMuo3UhfI8MSq66RtKDK/831n/Cpyg5mQAcr9tWLKhrYyDHbBuQ8/E+yUC0fKfRgnZOgQ181MTP+hGHIIkIcDH7XNdLzcVU/FHKkPFXVMCrWybJTIU2PuJwu6K72DT2WCFrGv5cSu6Db/lcsLwzcpoT3JrTJ29xqrN4/LU7Dswwk4zYNgYOPxFOvcaaQitncyal+tkVp4uu/PGzBx1sJ1nvvkiMbcKkSo7CCjEi/7BNlLyyBEICxAmTYtEbFYh4koR5aYOavsFN7qE/hSUEDvA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(366004)(136003)(376002)(396003)(346002)(230922051799003)(451199024)(1800799012)(64100799003)(186009)(4744005)(31686004)(2906002)(44832011)(41300700001)(8676002)(8936002)(4326008)(5660300002)(316002)(6636002)(66476007)(66556008)(110136005)(86362001)(6486002)(2616005)(478600001)(83380400001)(6506007)(36756003)(66946007)(53546011)(26005)(6666004)(6512007)(38100700002)(31696002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZFYwVExsSEUwbFdYUGt2UmdETWlKaS9pdGZyL2JyRXJOUEJTMUU3N2N6NHNV?= =?utf-8?B?VnJuVXhCNm14Ukx6WnFSK2RjaTM5Ymp6VTVMREVKU1Z0cVAxVDFmNGRRdjdh?= =?utf-8?B?OTVsOU1ZRW5BbnhPUldOMk1SL2xsSVJnL3J2NWYzYXd4UWc0aFA2NTUrZGRD?= =?utf-8?B?VnBOVElUc3B1QWNaMnlpdGlSUjE3enA1K2tQZEJ4MzdkalI0cW5ybEkwcFk5?= =?utf-8?B?Z29CWFdranlzZGk1S1haRFhWeUdoNkY3N3BJeE5lU2FJcXhYY3FBTUtXTTJi?= =?utf-8?B?ekFqOWpyRHlHSEN3OS94MDE0NHMxVXkrMDFUbGh3eDBDT2VHeWN0M213Q0dO?= =?utf-8?B?VHFWNTdEdGRTeEpHNWE4RGV3djlpdk1XUkxRZEQ5MnJDbjduM0ttSWdqWUto?= =?utf-8?B?cWZYRlpGMGVNd1pjN04ybGo3bjl0aVN4dDlXRWZYU0Nac3pBY1ZVb3hLRnBm?= =?utf-8?B?NGZHa3VEK2NRb3ZlY0lodVJzRUxmVm5LVEoxdVNxaXcybHZ0ZWdrOHJCNy9O?= =?utf-8?B?RFJGL3pISmJxSWxDK05MWXkzNkZHZGRVNm45TGIyUDNpVFRrKy83KzdMYmtQ?= =?utf-8?B?dWxFSXdjSFFINFF1QUxPc1Fpb1FlVWdjSDV4ZTh0bzZzdzhCek1ZK3ZoTlhP?= =?utf-8?B?K3hPYWZTYXpmb2VMV2doQnZxU3BnM0FuaHBsWWhSNmZwRFIxYlBZTHYwajNP?= =?utf-8?B?eHpVb0hEbi9lU3k5VkNCM3Rqb3cwZER5OGJUZWVCWjVHdU1XNWQxU0pkZjFa?= =?utf-8?B?akxCRUZNZmpnbmxwcHJyZ1JWYjlidHRicnFFUk5tTGNzUXlEc0VLUE8rZGpz?= =?utf-8?B?ZGxKTXdUVHRFcXhJSXV2Vy84a0NvNW5yQU9qRS9JaU5zYlhXTmx4aDZjeUFP?= =?utf-8?B?QWkwUVA5ZmdoUHBGZHhTNGhHZ0JIZlExdWtrRlJVMStUMUFnZkowOWJVb2Zh?= =?utf-8?B?SkRjYi9aT3RtVGRmRFo1cWtKMVZUbDM5V3BHT1JIZ3llc092SFpHVmFKNDU2?= =?utf-8?B?Y0w2MG1Fdk4wYzRrMmVQSUM4TFRUMWh2emNJeXVjWVZuRG52UkVYdVNDZ0tw?= =?utf-8?B?ZGJFanMxTXhWUTkyNlBoQnlOU0FJdlJxSkRNd29ubjdENWVkVFFKWjNOcVky?= =?utf-8?B?MDFmOXNCSTVPRktmTDdnajIvWXE1cyt3U0RMdHJRZlBLSW5PbnB1MTVLdVhv?= =?utf-8?B?WnJvY011SkgrWTZwNkEzeXFFYWlvdTR1MjBjNmNQamtTdEV3UGt5ZVdTVllV?= =?utf-8?B?K21YQS9aSVNNUzBqZ05HaHk0cDQxNFQ4NWFTaHo5QkN2bXZEN1U2SVdCUWVr?= =?utf-8?B?K1FDVDA5a09Kb2ZzWVU4dndMaXZhb2RTZldaejBxU2FRVThZMExjaGJ6Ynoz?= =?utf-8?B?YTYyWGVQOVZReU1iZURPS0Zkek5PSDJvbldjZVRtM3htazJ5YVFkNXRrQlNB?= =?utf-8?B?SEliZC9HNkluUU5SK3RFVTVpS1pZNkRzOGJVTFVXMU9aQWRLb2h1bEVYZlBB?= =?utf-8?B?RFJVdFdsRFZCU2NDTmxLZjBNOEVmanJrcy84ZHRkZHJzOUFhcGMxZHRjbWVr?= =?utf-8?B?L1ludW5iUEdUdm11TnpLRElNZFl3S1R4ZjFNWXQwMnFNS0tkbmc1MnNXYXRU?= =?utf-8?B?R1g5NkN1bFdld1c4bDAzOGg3TDBOTHJPeGtoQWVxR25mZ3pOSkxIMXFnVUZK?= =?utf-8?B?M29mR083V1BrZWdUNC8xUWYyZk9hWlpTRGVSNk11TkExck5ob0l1TGRIZC9q?= =?utf-8?B?bENQbDFocndQQlVhM0pkcU1KZ3dnUlpjMDhHLzNlaFp4b1Jyd0VCYzE2Tksz?= =?utf-8?B?U3Q2Uk40aVErM0RrMFdDeG5WdGQwa08zWE11THZ3Y0xYRHNQeHE1S1hNeVpE?= =?utf-8?B?YTN0M0ptUEtnUi9ENDJuUmxjVTNJM2xwMFdIYTRWTS95YzVNdHJTRXMxNTVn?= =?utf-8?B?RThQWitDOVpaTk13cHB3Z2JBK3M4bmcySDRNZStPMXJlYVhNUUE2R0haeWhV?= =?utf-8?B?SVROdHhUVllWbmxZUDFFaWJOZlV5TDk1U01hVGJabUFUdmlOWHZ2NVNldmJm?= =?utf-8?B?ZDFzQm1aVzVzenpQUnBMa3JPcjZSMXFvblFYbjFlR0QxNU1pcHAxWjQ4U2Vj?= =?utf-8?Q?C4gI=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2646699c-03bf-467e-3b12-08dbec0ea825 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2023 10:26:30.0247 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2lhurvHbRA/XWOPakUKKH2gbFeD+Vkxz8O0lWCt7brCyNz/fLC2UM1/3B+YOelX0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB7006 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/23/2023 1:58 AM, Thomas Monjalon wrote: > 26/10/2023 17:19, Sivaprasad Tummala: >> Updated the l3fwd-power app to configure the uncore env before invoking >> any uncore APIs. With auto-detection in 'rte_power_uncore_init()' it is >> too late because other APIs already called. > > You are also updating the uncore API. > >> + if (env == RTE_UNCORE_PM_ENV_AUTO_DETECT) >> + /* Currently only intel_uncore is supported. This will be >> + * extended with auto-detection support for multiple uncore >> + * implementations. >> + */ >> + env = RTE_UNCORE_PM_ENV_INTEL_UNCORE; > > It looks like this patch does not make sense without AMD support. > Yes, right now auto detect directly fallback to Intel, but there is an intention to add AMD support too, that is why instead directly using Intel preferred the auto detection abstraction.