DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jeff Guo <jia.guo@intel.com>
To: Wei Zhao <wei.zhao1@intel.com>, dev@dpdk.org
Cc: stable@dpdk.org, qi.z.zhang@intel.com, ferruh.yigit@intel.com
Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: enable 10Mb/s speed for x553
Date: Mon, 29 Jun 2020 16:21:00 +0800	[thread overview]
Message-ID: <071506a2-87c4-a94b-7f7c-d5100cb3f801@intel.com> (raw)
In-Reply-To: <20200628061255.68963-1-wei.zhao1@intel.com>

hi, wei

On 6/28/2020 2:12 PM, Wei Zhao wrote:
> For ixgbe x553(IXGBE_DEV_ID_X550EM_A_1G_T) it support 10M
> link speed, so enable it for the kind of ixgbe nic.


This is not an enabling patch i think, it just add the support link 
speed info for specific nic, so suggest you refine the commit log and 
bring my

ack at coming version.


> Fixes: af75078fece3 ("first public release")
> Cc: stable@dpdk.org
>
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> ---
>   drivers/net/ixgbe/ixgbe_ethdev.c | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
> index f8a84c565..d812579fe 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -4320,6 +4320,10 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev,
>   			link.link_speed = ETH_SPEED_NUM_100M;
>   		break;
>   
> +	case IXGBE_LINK_SPEED_10_FULL:
> +		link.link_speed = ETH_SPEED_NUM_10M;
> +		break;
> +
>   	case IXGBE_LINK_SPEED_100_FULL:
>   		link.link_speed = ETH_SPEED_NUM_100M;
>   		break;
Acked-by:  Jeff Guo <jia.guo@intel.com>

  reply	other threads:[~2020-06-29  8:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-28  6:12 Wei Zhao
2020-06-29  8:21 ` Jeff Guo [this message]
2020-06-30  1:32   ` Zhao1, Wei
2020-06-30  1:16 ` [dpdk-dev] [PATCH v2] net/ixgbe: add the support link speed info " Wei Zhao
2020-06-30 14:14   ` Zhang, Qi Z

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=071506a2-87c4-a94b-7f7c-d5100cb3f801@intel.com \
    --to=jia.guo@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=stable@dpdk.org \
    --cc=wei.zhao1@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).