From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7948641C9C; Wed, 15 Feb 2023 04:04:27 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0D4BF40EDB; Wed, 15 Feb 2023 04:04:27 +0100 (CET) Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by mails.dpdk.org (Postfix) with ESMTP id C4E3540ED6 for ; Wed, 15 Feb 2023 04:04:25 +0100 (CET) Received: from dggpeml500024.china.huawei.com (unknown [172.30.72.53]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4PGjXp0cYVz16Ncn; Wed, 15 Feb 2023 11:02:02 +0800 (CST) Received: from [10.67.100.224] (10.67.100.224) by dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.17; Wed, 15 Feb 2023 11:04:22 +0800 Subject: Re: [PATCH v4 0/3] add telemetry cmds for ring To: Jie Hai , , , CC: , References: <20230131022841.10775-1-haijie1@huawei.com> <20230210024835.33804-1-haijie1@huawei.com> From: fengchengwen Message-ID: <07191d65-7cc4-a808-1657-089de76f91c6@huawei.com> Date: Wed, 15 Feb 2023 11:04:21 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20230210024835.33804-1-haijie1@huawei.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.100.224] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpeml500024.china.huawei.com (7.185.36.10) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org LGTM Series-acked-by: Chengwen Feng On 2023/2/10 10:48, Jie Hai wrote: > This patch set supports telemetry cmd to list rings and dump information > of a ring by its name. > > v1->v2: > 1. Add space after "switch". > 2. Fix wrong strlen parameter. > > v2->v3: > 1. Remove prefix "rte_" for static function. > 2. Add Acked-by Konstantin Ananyev for PATCH 1. > 3. Introduce functions to return strings instead copy strings. > 4. Check pointer to memzone of ring. > 5. Remove redundant variable. > 6. Hold lock when access ring data. > > v3->v4: > 1. Update changelog according to reviews of Honnappa Nagarahalli. > 2. Add Reviewed-by Honnappa Nagarahalli. > 3. Correct grammar in help information. > 4. Correct spell warning on "te" reported by checkpatch.pl. > 5. Use ring_walk() to query ring info instead of rte_ring_lookup(). > 6. Fix that type definition the flag field of rte_ring does not match the usage. > 7. Use rte_tel_data_add_dict_uint_hex instead of rte_tel_data_add_dict_u64 > for mask and flags. > > Jie Hai (3): > ring: fix unmatched type definition and usage > ring: add telemetry cmd to list rings > ring: add telemetry cmd for ring info > > lib/ring/meson.build | 1 + > lib/ring/rte_ring.c | 139 +++++++++++++++++++++++++++++++++++++++ > lib/ring/rte_ring_core.h | 2 +- > 3 files changed, 141 insertions(+), 1 deletion(-) >