From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AF5B5A0A01; Mon, 4 Jan 2021 13:03:56 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 334441606F8; Mon, 4 Jan 2021 13:03:56 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id AB9391606E6 for ; Mon, 4 Jan 2021 13:03:54 +0100 (CET) IronPort-SDR: U4eNzudl76l4Ml5AHH+Z7s+CfiNciHfPUoa0IGa55L23Rje5xtz+2NYrdXyhjRu75NgmER/jk6 s4WidAEunIoA== X-IronPort-AV: E=McAfee;i="6000,8403,9853"; a="195464761" X-IronPort-AV: E=Sophos;i="5.78,473,1599548400"; d="scan'208";a="195464761" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jan 2021 04:03:53 -0800 IronPort-SDR: QikPfWFUgCEHME0zLSsoDCad51nRe9bBOHmVmLGWTPV/8Qc6av+Z+th0SGhppqd/HG6pOSDYFm d9qJiVm91AOA== X-IronPort-AV: E=Sophos;i="5.78,473,1599548400"; d="scan'208";a="378391956" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.251.93.148]) ([10.251.93.148]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jan 2021 04:03:52 -0800 To: Balazs Nemeth , Devendra Singh Rawat , Igor Russkikh , "dev@dpdk.org" , Rasesh Mody References: <8a90fc3e-31dd-2792-0dee-7c86523f2245@marvell.com> <20b494692d1b54d1a83f519759584662371073c8.camel@redhat.com> From: Ferruh Yigit Message-ID: <073bb3ad-3844-8b54-1bc1-19ff1830aa43@intel.com> Date: Mon, 4 Jan 2021 12:03:48 +0000 MIME-Version: 1.0 In-Reply-To: <20b494692d1b54d1a83f519759584662371073c8.camel@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] Potential regression introduced by commit b10231aed1edb9 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/30/2020 12:55 PM, Balazs Nemeth wrote: > Hi, I already posted a patch that fixes the issue on my side here: > http://mails.dpdk.org/archives/dev/2020-December/195206.html > > Regards, > Balazs > > On Wed, 2020-12-30 at 12:51 +0000, Devendra Singh Rawat wrote: >> Adding more people to comment/investigate here. >> >> Devendra, could it be that we don't consider subsequent calls of >> promisc_enabled + allmulti_enable ? >> >> Devendra >> yes, I agree that as long as promiscuous mode is enabled >> for a port, all traffic should be accepted even if allmulticast is >> enabled latter. Commit b10231aed1edb9 shouldn't have changed that. >> I will prepare a fix patch for this. >> >> On 18/12/2020 2:34 pm, Balazs Nemeth wrote: >>> Hi, >>> >>> introduces a regression on my systems. I have a >>> "QLogic Corp. FastLinQ QL41000 Series 10/25/40/50GbE Controller" >>> which >>> relies on the qede driver. Calling >>> rte_eth_promiscuous_enable(portid) >>> followed by rte_eth_allmulticast_enable(port_id) causes no packets >>> to >>> arrive from my generator. It's important to add that the generator >>> doesn't specifically target the mac of the port. I presume that >>> irrespective of dst mac, if a port is put into promiscuous mode, >>> all >>> packets should arrive and rte_eth_allmulticast_enable should not >>> cause >>> *less* packets to arrive. Am I missing something? It seems that >>> b10231aed1edb9 inadvertently introduced either a bug or a pretty >>> significant change in semantics (at least for qede)? >>> >>> Regards, >>> Balazs >>> > Hi Balazs, You can create Bugzilla issue as well, that helps to record and track the issues: https://bugs.dpdk.org/