DPDK patches and discussions
 help / color / mirror / Atom feed
From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Yajun Wu <yajunw@nvidia.com>,
	matan@nvidia.com, Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Cc: dev@dpdk.org, thomas@monjalon.net, mkashani@nvidia.com, stable@dpdk.org
Subject: Re: [PATCH] vdpa/mlx5: fix queue enable drain CQ
Date: Tue, 6 Feb 2024 15:06:20 +0100	[thread overview]
Message-ID: <07564659-e793-42fb-ba7a-f9a076c7e313@redhat.com> (raw)
In-Reply-To: <a9a5712e-ff61-4404-ace9-fd3d3094d6b6@redhat.com>



On 2/6/24 14:17, Maxime Coquelin wrote:
> 
> 
> On 1/25/24 04:17, Yajun Wu wrote:
>> For the case: `ethtool -L eth0 combined xxx` in VM, VQ will disable
>> and enable without calling device close. In such case, need add
>> drain CQ before reuse/reset event QP.
>>
>> Fixes: 24969c7b62 ("vdpa/mlx5: reuse event queues")

No need to resend, but the Fixes SHA1 should be 12 chars long, not 10.
As a helper, you can below alias in your .gitconfig:

[alias]
	fixline = log -1 --abbrev=12 --format='Fixes: %h (\"%s\")%nCc: %ae'

Then, you can just use it like this:

$ git fixline 24969c7b6224afc48751d94fc0152fca8b6645b1
Fixes: 24969c7b6224 ("vdpa/mlx5: reuse event queues")
Cc: yajunw@nvidia.com

>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Yajun Wu <yajunw@nvidia.com>
>> Acked-by: Matan Azrad <matan@nvidia.com>
>> ---
>>   drivers/vdpa/mlx5/mlx5_vdpa_event.c | 29 +++++++++++++++++++----------
>>   1 file changed, 19 insertions(+), 10 deletions(-)
>>
> 
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> 
> Thanks,
> Maxime
> 


  reply	other threads:[~2024-02-06 14:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-25  3:17 Yajun Wu
2024-02-06 13:17 ` Maxime Coquelin
2024-02-06 14:06   ` Maxime Coquelin [this message]
2024-02-06 14:58 ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=07564659-e793-42fb-ba7a-f9a076c7e313@redhat.com \
    --to=maxime.coquelin@redhat.com \
    --cc=dev@dpdk.org \
    --cc=matan@nvidia.com \
    --cc=mkashani@nvidia.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    --cc=viacheslavo@nvidia.com \
    --cc=yajunw@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).