From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1798E454EF; Tue, 25 Jun 2024 13:21:02 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 602E642D66; Tue, 25 Jun 2024 13:17:46 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) by mails.dpdk.org (Postfix) with ESMTP id CE5A742DCA for ; Tue, 25 Jun 2024 13:16:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719314209; x=1750850209; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=6j/a+IOqXpVKm9arLvP0+YBzqcvQKfIZj1yMzQbDdrA=; b=GuW50IILMicT0XMzVUIcFRmF3jL6Kk7NKWRB7x5W50t49Kziau18Xn+W BqB+E9bGvVZTF3Ad+23l1/7ezX9tuWwq7HBkgKsOHRf99Yka3akMHkiBq OjFHfHtZ9WA6TPCmbACOl6H6sWq3iQv1LLx3Te4yZ6xUPQkrlmhOsDTud FdHrt7U/7irrjqFJn4Cdt/icWHfYFVQNo/K26dTFGEmNtF+KmdZgJrFye JtCiyZqnwgq0cFjVKtz4QcgKHFvEySEVkym0YqCw4hKBlVyXG5dPRpp0j gzdPxmPIW3iUKbcZQ7Zv8B9YgrklHy0kG9QJXBo4OSiFAaXLSRO9KZqC8 Q==; X-CSE-ConnectionGUID: zQ8fDBjCSYGjEPZ6JqEl6w== X-CSE-MsgGUID: V4mGuu8ZTsSqPPjmSOkcFg== X-IronPort-AV: E=McAfee;i="6700,10204,11113"; a="16080214" X-IronPort-AV: E=Sophos;i="6.08,263,1712646000"; d="scan'208";a="16080214" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jun 2024 04:16:14 -0700 X-CSE-ConnectionGUID: tyicpFnpQMeRWpxCrabK1A== X-CSE-MsgGUID: B4y1J7L9SyuHIjGtMRHbrQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,263,1712646000"; d="scan'208";a="43719184" Received: from unknown (HELO silpixa00401119.ir.intel.com) ([10.55.129.167]) by orviesa009.jf.intel.com with ESMTP; 25 Jun 2024 04:16:13 -0700 From: Anatoly Burakov To: dev@dpdk.org Cc: Jacob Keller , bruce.richardson@intel.com, ian.stokes@intel.com Subject: [PATCH v3 046/129] net/ice/base: use ICE_PTP_NOP to better indicate no action Date: Tue, 25 Jun 2024 12:12:51 +0100 Message-ID: <075aaf866b33c2c1db469c9ae784289deca05cff.1719313663.git.anatoly.burakov@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Jacob Keller A couple of E822 PTP functions use ICE_PTP_READ_TIME on the main timer to avoid any side effects when programming a single PHY port. Match the ETH56G code by using ICE_PTP_NOP instead, which better reflects the intended behavior. Signed-off-by: Jacob Keller Signed-off-by: Ian Stokes --- drivers/net/ice/base/ice_ptp_hw.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/ice/base/ice_ptp_hw.c b/drivers/net/ice/base/ice_ptp_hw.c index 5508c2e7f6..dbcd26c68a 100644 --- a/drivers/net/ice/base/ice_ptp_hw.c +++ b/drivers/net/ice/base/ice_ptp_hw.c @@ -4192,8 +4192,8 @@ static int ice_sync_phy_timer_e822(struct ice_hw *hw, u8 port) if (status) goto err_unlock; - /* Init PHC mstr/src cmd for exec during sync */ - ice_ptp_src_cmd(hw, ICE_PTP_READ_TIME); + /* Do not perform any action on the main timer */ + ice_ptp_src_cmd(hw, ICE_PTP_NOP); /* Issue the sync to activate the time adjustment */ ice_ptp_exec_tmr_cmd(hw); @@ -4320,8 +4320,8 @@ ice_start_phy_timer_e822(struct ice_hw *hw, u8 port, bool bypass) if (status) return status; - /* Init PHC mstr/src cmd for exec during sync */ - ice_ptp_src_cmd(hw, ICE_PTP_READ_TIME); + /* Do not perform any action on the main timer */ + ice_ptp_src_cmd(hw, ICE_PTP_NOP); ice_ptp_exec_tmr_cmd(hw); -- 2.43.0