From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2B82DA051A; Fri, 17 Jan 2020 10:20:06 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 621091D412; Fri, 17 Jan 2020 10:20:05 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 47FFF1D3F0 for ; Fri, 17 Jan 2020 10:20:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579252802; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=7qF0gngZ2JW94IaFmE76mzF1ara5274tfBTKFAOxYqE=; b=RnvfeVPmr7Za/WPcR53+TBwpOlhOwFpTsLRGkIspy/04YZ6BJUQE3zxfxnYFUFSiFy41A4 R6Xi2WeEOpWOJQMxdVhUSVUFUf68+UxIKUpo4UKB5tgWURN35he8xSK25hfQHsd7UEuCR+ 1duv3zDZ+rQT6VR6L0s4yCmiu1Tvqoo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-397-6ic9aOP4P7iI-iIiBz9S8g-1; Fri, 17 Jan 2020 04:19:59 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CC5168024E0; Fri, 17 Jan 2020 09:19:57 +0000 (UTC) Received: from [10.33.36.27] (unknown [10.33.36.27]) by smtp.corp.redhat.com (Postfix) with ESMTP id 22D165C241; Fri, 17 Jan 2020 09:19:52 +0000 (UTC) To: Maxime Coquelin , Jerin Jacob Cc: Jerin Jacob , dpdk-dev , Thomas Monjalon , techboard@dpdk.org, "Richardson, Bruce" References: <20191212131302.1626130-1-jerinj@marvell.com> <898e1731-4921-721b-0e42-ada50ab2bf94@redhat.com> From: Kevin Traynor Autocrypt: addr=ktraynor@redhat.com; keydata= mQINBF2J2awBEADUEPNhgNI+nJNgiTAUcw4YIgVXEoHlsNPyyzG1BEXkWXALy0Y3fNTiw6+r ltWDkF9jzL9kfkecgQ67itGfk1OaBXgSGKuw1PUpxAwX2Bi76LAR6M5OsyGM9TSVVQwARalz hMwRBIZPzPc7or6Pw7jAOJ8SQGJ1Zlp1YJCjrvpe87V1tH/LY8Wnxn/EuoseFmWILAQZAtYS tGjcrAgYn3SPMLR1B0BP5bTBY06vWQjiufH8drenfDnMJAzuBdG1mqjnTqCjULZ3Hunv4xqZ aMnkvL/K5Tj1c12Oe4930EE53LrXIBUltRg5mBudSWHnC7twjH0082HH9f963Z/2UI63SFIT iUvRvAzJYytgy7XnWLQ0+goZBADKYfolOuC0H8VgCaux8u8KFF28Dy+N6TV2KI58jTlyg1Zu l7QwykZpnOkJFiy37Gfbu3YEOzO72cP/S7/A+zvuqkxi63jyEkd+FY99vLt/HN2MUZwRmKDw UPbLkmrs8WU01/POVsqDcfvz7vu2St8hqqTiSIdQGS2zyTKB2/DvPSM3jws3udkIYSuhn+X4 QBiV6lkVZ7DSE6a065gnAauAql+b32Eymy+xnG5jCt1tR+0Cp2VZYCR9OU2gmomUKBDoX/He pSgED01CqYPNjN+TddirwmQX7ep4DtXc8FWvv2g/pq9WZFQk2QARAQABtCNLZXZpbiBUcmF5 bm9yIDxrdHJheW5vckByZWRoYXQuY29tPokCTgQTAQgAOBYhBAoiOaH51tHF7VYtEI9CINER a+yJBQJdidmsAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEI9CINERa+yJoxIP/3VF 2TIgW4ckxhRFCvFu/606bnvCPie88ake4uWVWMAWwcMc4fKEltRWRCpkSVOwgqoMHnyHxK5r kOKzx2CLJMX5TgTMfKzPuaBDHngHLUzl2DStpBzrod0cVg5TShdmmfjY61uxRJKz+DlSkwgJ riADdVF5PPosQXTkKSGf2ombpTGpx/pue9ocjnr3x4SDpRLlnooM6Jf/3Y3Ib4jX6HPEyWuY b+owIIk9y2nRRGPQ6jbqAhsrXd9V+77UL0QuGWloMuKMZFbNg8hbu7X5aFijAbfxj4YUgojS ba7gfGZQan8h32A9KGQWrmsCBc3j2GqEPsX0r05X7cn7WL6IOPgQJ5EiQ7PlazQYVLrvZg9B n0GKK0k6895mLG0ZZ5v/qajOPF52etSmvFD1WUPb4OqaHqGA9ZtMpaKFRt7Y6rpXqKNU1xzW F5KjbTPtTb9WF3An8dciVv+AYUI7totkZYkWvQtgss8lfaX3NKUvXLVxqK0z3dQyr7rF/tYz PneTKypSksjCgaEBLSrsRmM5zKfe7tSNF/fDntfIq/029Jtcw29TcWEP57peNu6TtejewQD9 sTI+oqiXvW2D5l7LNUDYG8eMJp2oT7I0ZSBRvwcbmjH0DtN/bXCCFfCvk8Yic68F3tV1ctix wQARVKDBhT30uCxycRWojCYqTgNJJS71uQINBF2J2awBEADP57PR2IpSYBeNSrsAjeIcsahE N4SQP2C4s50S8QEWAUhqMRI7WNv5cfeef0nDvcl1IUA6oz5SokbcsbMa+mRgaNF4N5KikWTO LPYxq2YVJoXwJ+tKmNzyOLFUIfFJ4NBJZple5dTfWzD00Dbb19Mri1hy1mWMqNTPGBee1+hw Qcp6n3mmGECvajs8G5A7NyXbwL8ihN7HX9D01ucD62b4G03yKe2g/hvKgcdUVmhCldJlF27I 2fSR9tDxH9pZqRODY4rjbFZEey/vWKXqjE+DQ8AtMSEaDfFe5D+i4Aw6erWQ3Wr+DwZt1/7G dIAElGA/q90T1ENVwJX9y7fsQssawKYYdDqURHCl5JuDXI+VXUypExipUUT5SPycMmbLsx0D iKEqPPDQWKxkIDVKqj2+EhamSuJznZUwBLJKn0h4zrIWiXWUy07lRwtVuhaDXhF3GfW+5W/x wAg7Qg3w00ASsb/XTHBIhMnenKDfS7ihtQA8SacwX8ySdxb+15XPyiplM979qBQ0mhnilulm MIJzEf/JxoYR5huuj4f1PFqqrsP06Dl+YGB7dQZp3IKggS5c3/TAynARRg9N89UsDXNtp7X0 tgIPFF5k6fnHE0J5O64GYHeTqN/1aE6dAEOV9WrGzQAJxU9ipikb8jKAWXzLewRIKGmoPcRZ WdB0NmIjmQARAQABiQI2BBgBCAAgFiEECiI5ofnW0cXtVi0Qj0Ig0RFr7IkFAl2J2awCGwwA CgkQj0Ig0RFr7IkkORAAl/NbX93WK5MEoRw7/DaPTo/Lo6Pj1XMeSqGyACigHK/452UDvlEH NjNJMzYYrNIjMtEmN9VVCfjT38CSca7mpGQVwchc0mC7QSPAETLCS+UacVf/Kwxz5FfkEUUw UT7A+uyVOIgW3d9ldlRzkHA2czonSSgTQU+i2g6DM4ha+BuQb4byAXH6HQHt/Zh1J64z0ohH v6iGsCzCY/sMWF8+LEGSnzMGRCLiiwSF0vJBHbzWK68fANaF4gBV0Z/+6tQRFN7YMhj/INmk qgvHj1ZzHFNtirjMGPRxoZs51YoLQM/aBPxKrnmXThx1ufH+0L6sGmFTugiDt0XSEkC5reH7 a+VhQ1VTFFQrClA8NmDSPzFeuhru4ryaaDHO+uEB16cNHxHrQtlP/2hts2JM5lwkZRWJ5A57 h8eDEIK5be47T85NVHfuTaboNRmgg1HygVejhGUtt69u/0MVRg/roUTa0FyEbNsvz4qAecyW yWzMcVrcGJDQLC9JLKEpoyUF6gdTKaiDL2Vao4+XRIA3Y57b6MO35a3HuzAv7+i5Z0mnDEJO XxXqTOmKYpMIGexzM/PtuA0712sT1abG9tAJ17ao/B7cqMW5IkKkalemFbWfI2unns4Papvo tk9igVqyp6EJDU98z5TJioCVojwK2laDaoIjTJk9YYv3iwCsqPd5feU= Message-ID: <079fa64b-e742-9126-380f-7a598e49445a@redhat.com> Date: Fri, 17 Jan 2020 09:19:52 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-MC-Unique: 6ic9aOP4P7iI-iIiBz9S8g-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [dpdk-techboard] [PATCH] config: disable all kmods by default from v20.02 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 17/01/2020 08:29, Maxime Coquelin wrote: >=20 >=20 > On 1/16/20 7:43 PM, Jerin Jacob wrote: >> On Fri, Jan 17, 2020 at 12:04 AM Maxime Coquelin >> wrote: >>> >>> >>> >>> On 1/16/20 2:11 PM, Jerin Jacob wrote: >>>> Ping. >>>> >>>> On Thu, Dec 12, 2019 at 6:42 PM wrote: >>>>> >>>>> From: Jerin Jacob >>>>> >>>>> Based on the techboard meeting held on 2019-11-06, >>>>> It's been decided to disable all kmods by default from v20.02. >>>>> >>>>> http://mails.dpdk.org/archives/dev/2019-November/151763.html >>>>> >>>>> Signed-off-by: Jerin Jacob >>>>> --- >>>>> config/common_linux | 2 -- >>>>> 1 file changed, 2 deletions(-) >>>>> >>>>> diff --git a/config/common_linux b/config/common_linux >>>>> index c5cf3d662..583efadc7 100644 >>>>> --- a/config/common_linux >>>>> +++ b/config/common_linux >>>>> @@ -8,9 +8,7 @@ CONFIG_RTE_EXEC_ENV_LINUX=3Dy >>>>> CONFIG_RTE_EXEC_ENV_LINUXAPP=3Dy >>>>> >>>>> CONFIG_RTE_EAL_NUMA_AWARE_HUGEPAGES=3Dy >>>>> -CONFIG_RTE_EAL_IGB_UIO=3Dy >>>>> CONFIG_RTE_EAL_VFIO=3Dy >>>>> -CONFIG_RTE_KNI_KMOD=3Dy >>>>> CONFIG_RTE_LIBRTE_KNI=3Dy >>>>> CONFIG_RTE_LIBRTE_PMD_KNI=3Dy >>>>> CONFIG_RTE_LIBRTE_VHOST=3Dy >>>>> -- >>>>> 2.24.0 >>>>> >>>> >>> >>> Looks good for make build system, but what about Meson? >>> as per meson_options.txt, isn't it enabled by default? >>> $ grep -rn enable_kmods meson_options.txt >>> 7:option('enable_kmods', type: 'boolean', value: true, >> >> + Bruce, >> >> Since meson autodetect the presence of Linux kernel dependency for the >> kmod build, >> I thought of keeping as it is as there is no harm. I am fine with >> either way, let me the >> know the feedback, I will send the v2 based on the comment. >=20 > Actually, it would defeat the main reason I pushed for the kmods to be > disabled by default. Indeed, even if the kernel dependencies are > installed, build can break if internal kernel API changes, e.g.: >=20 > commit c128a4e6317d49362e2158edc29887c844067c65 > Author: David Zeng > Date: Sat Dec 22 00:27:33 2018 +0800 >=20 > kni: fix build on RHEL8 for arm and Power9 >=20 > [ upstream commit 3d5501d568aacbcf71832691278f5656d3a9b649 ] >=20 > Signed-off-by: David Zeng > Acked-by: Ferruh Yigit >=20 That's a good point. We take these types of patches into stable, but there would be a few months delay between a new kernel causing breakage and the time when stable releases containing the fix are released. Disabling would at least avoid non-kmod interested user being impacted by default.