From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <arybchenko@solarflare.com> Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id ED95D1CA18 for <dev@dpdk.org>; Sat, 7 Apr 2018 11:51:51 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1-us4.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 69576B40053; Sat, 7 Apr 2018 09:51:50 +0000 (UTC) Received: from [192.168.38.17] (84.52.114.114) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Sat, 7 Apr 2018 10:51:45 +0100 To: Adrien Mazarguil <adrien.mazarguil@6wind.com>, Thomas Monjalon <thomas@monjalon.net>, Ferruh Yigit <ferruh.yigit@intel.com>, <dev@dpdk.org> CC: "Zhang, Qi Z" <qi.z.zhang@intel.com> References: <20180404150312.12304-1-adrien.mazarguil@6wind.com> <20180406131736.19145-1-adrien.mazarguil@6wind.com> <20180406131736.19145-15-adrien.mazarguil@6wind.com> From: Andrew Rybchenko <arybchenko@solarflare.com> Message-ID: <07a42ecb-3a82-edc7-6763-1fd850ce580b@solarflare.com> Date: Sat, 7 Apr 2018 12:51:40 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180406131736.19145-15-adrien.mazarguil@6wind.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-Originating-IP: [84.52.114.114] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.100.1062-23768.003 X-TM-AS-Result: No--9.960300-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-MDID: 1523094711-ByVdDRBYve9k Subject: Re: [dpdk-dev] [PATCH v2 14/15] ethdev: add physical port action to flow API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Sat, 07 Apr 2018 09:51:52 -0000 On 04/06/2018 04:25 PM, Adrien Mazarguil wrote: > This patch adds the missing action counterpart to the PHY_PORT pattern > item, that is, the ability to directly inject matching traffic into a > physical port of the underlying device. Does it mean that if it is applied on ingress (incoming packet from network) it will simply send packets back to network (specified physical port)? And if it is applied on egress (outgoing from device to network) it will be directed to possibly different physical port and sent to network. > It breaks ABI compatibility for the following public functions: > > - rte_flow_copy() > - rte_flow_create() > - rte_flow_query() > - rte_flow_validate() > > Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com> > Cc: "Zhang, Qi Z" <qi.z.zhang@intel.com> > --- > app/test-pmd/cmdline_flow.c | 35 ++++++++++++++++++++++++ > app/test-pmd/config.c | 1 + > doc/guides/prog_guide/rte_flow.rst | 20 ++++++++++++++ > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 5 ++++ > lib/librte_ether/rte_flow.c | 1 + > lib/librte_ether/rte_flow.h | 22 +++++++++++++++ > 6 files changed, 84 insertions(+) <...>