From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 9AD54A05D3 for ; Wed, 22 May 2019 17:57:16 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9A8BB25A1; Wed, 22 May 2019 17:57:15 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id CA63E10BD for ; Wed, 22 May 2019 17:57:13 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 May 2019 08:57:12 -0700 X-ExtLoop1: 1 Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.237.220.70]) ([10.237.220.70]) by fmsmga006.fm.intel.com with ESMTP; 22 May 2019 08:57:10 -0700 To: Nicolas Dichtel , dev@dpdk.org Cc: Olivier Matz , Didier Pallard References: <20190522154143.8041-1-nicolas.dichtel@6wind.com> From: "Burakov, Anatoly" Message-ID: <07c05411-51bb-2a8c-c941-bc7483683c02@intel.com> Date: Wed, 22 May 2019 16:57:09 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190522154143.8041-1-nicolas.dichtel@6wind.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] librte_eal: ease init in a docker container X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 22-May-19 4:41 PM, Nicolas Dichtel wrote: > move_pages() is only used to get the numa node id, but this function > is not allowed by default in docker (it needs CAP_SYS_NICE and an update of > the seccomp profile). > get_mempolicy() also requires CAP_SYS_NICE but doesn't need any change in > the default seccomp profile. > > Note that the returned value of move_pages() was not checked, thus some > errors could be hidden (if the requested id was 0). > > Signed-off-by: Nicolas Dichtel > Reviewed-by: Olivier Matz > Reviewed-by: Didier Pallard > --- I can see the check for move_pages and it's a good fix, but what is the relation to docker init here? The patch by itself only enables handling of move_pages() failure and adds nothing else. The commit message doesn't match the patch in question IMO. Also, Cc: stable and Fixes: ? -- Thanks, Anatoly