From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9403DA04BB; Tue, 6 Oct 2020 13:09:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6ECCF2B8B; Tue, 6 Oct 2020 13:09:27 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 0A51EA3 for ; Tue, 6 Oct 2020 13:09:24 +0200 (CEST) IronPort-SDR: 4aX9IPdKn8/wVMJkGrEvYY4Y92zYSRD3TOp+lMQ+nyBZ5nAfMn+1NPIU+dDWyBc2NzBp1+zhKH 14cT3EwQCyiA== X-IronPort-AV: E=McAfee;i="6000,8403,9765"; a="226047816" X-IronPort-AV: E=Sophos;i="5.77,343,1596524400"; d="scan'208";a="226047816" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2020 04:09:24 -0700 IronPort-SDR: JCWR/pVb2SBBM4n1JuyoehVtlyrlKZWqOInsIcw2eoDR9il4sxcKty7p1NXwjg1kPGw0zLtH5j UlWTAz/+L1GA== X-IronPort-AV: E=Sophos;i="5.77,343,1596524400"; d="scan'208";a="342197213" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.241.102]) ([10.213.241.102]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2020 04:09:20 -0700 To: Thomas Monjalon Cc: dev@dpdk.org, david.marchand@redhat.com, jerinj@marvell.com, stephen@networkplumber.org, Nicolas Chautru , Somalapuram Amaranath , John Griffin , Fiona Trahe , Deepak Kumar Jain , Marcin Wojtas , Michal Krawczyk , Guy Tzalik , Evgeny Schemeilin , Igor Chauskin , Ray Kinsella , Neil Horman , Anatoly Burakov References: <20200907225049.547832-1-thomas@monjalon.net> <20201005094300.590912-1-thomas@monjalon.net> <7b7c60ef-8b11-ca20-bf09-5f43132cbe3b@intel.com> <4658008.ZccNZLbTaq@thomas> From: Ferruh Yigit Message-ID: <07c1fc99-0d82-a659-6d2a-c57e9de3d922@intel.com> Date: Tue, 6 Oct 2020 12:09:17 +0100 MIME-Version: 1.0 In-Reply-To: <4658008.ZccNZLbTaq@thomas> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v4] kernel/linux: remove igb_uio X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/6/2020 11:54 AM, Thomas Monjalon wrote: > 06/10/2020 12:16, Ferruh Yigit: >> On 10/5/2020 10:42 AM, Thomas Monjalon wrote: >>> As decided in the Technical Board in November 2019, >>> the kernel module igb_uio is moved to the dpdk-kmods repository >>> in the /linux/igb_uio/ directory. > > [...] >> Patch doesn't apply cleanly, not sure why, CI seems having same problem: >> http://mails.dpdk.org/archives/test-report/2020-October/156378.html > > That's because I used --irreversible-delete to minimize the size of the patch. > > [...] >>> If UEFI secure boot is enabled, the Linux kernel may disallow the use of >>> UIO on the system. Therefore, devices for use by DPDK should be bound to the >>> - ``vfio-pci`` kernel module rather than ``igb_uio`` or ``uio_pci_generic``. >>> + ``vfio-pci`` kernel module rather than any UIO-based module. >>> For more details see :ref:`linux_gsg_binding_kernel` below. >> >> Should we change the order of the kernel drivers, currently first section is >> "UIO" and second section is "VFIO". Since we encoruage vfio and move igb_uio out >> of the repo, should we list the "VfIO" first? > > Absolutely. > In general we need to encourage more VFIO and remove some references > to igb_uio. But I don't want to do such "marketing" change in this patch. > The goal of this patch is just to move the code. > OK. > [...] >>> +* kernel: The module ``igb_uio`` has been moved to the git repository >>> +``dpdk-kmods`` in a new directory ``linux/igb_uio``. >>> + >> >> Doc build giving warning on this: >> WARNING: Bullet list ends without a blank line; unexpected unindent. > > Probably a merge issue. That's fine on my side. > I can see it is wrong in the patch itself, please double check in your end to be sure warning is not hidden in doc build. I am good as long as there is no warning. >> Except from above minor comments looks good to me, >> Reviewed-by: Ferruh Yigit > > Do we agree I can merge without any change? > Agree if the above doc warning is gone.