From: Alfredo Cardigliano <cardigliano@ntop.org>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Sunil Kumar Kori <skori@marvell.com>, dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3 1/1] net/ionic: use standard stdbool.h
Date: Tue, 10 Mar 2020 16:31:02 +0100 [thread overview]
Message-ID: <0809A9C0-612D-4366-9F11-D1917F744F78@ntop.org> (raw)
In-Reply-To: <7305ce1e-026a-3654-5f1a-8c5d85e1cf07@intel.com>
> On 10 Mar 2020, at 16:21, Ferruh Yigit <ferruh.yigit@intel.com> wrote:
>
> On 3/9/2020 9:09 AM, Sunil Kumar Kori wrote:
>> Any DPDK public header file which includes stdbool.h may conflict with
>> local definition of bool, if any, which further results in compilation
>> error. To avoid, used standard stdbool.h instead of defining bool
>> internally.
>>
>> I observed this issue during a development where I included rte_uuid.h
>> into rte_ethdev.h. As rte_ethdev.h is included to PMD driver, it started
>> throwing error as given below:
>>
>> CC ionic_rxtx.o
>> In file included from .../dpdk/build/include/rte_uuid.h:17:0,
>> from .../dpdk/build/include/rte_ethdev.h:161,
>> from .../dpdk/build/include/rte_ethdev_driver.h:18,
>> from .../dpdk/drivers/net/ionic/ionic_rxtx.c:34:
>> .../dpdk/drivers/net/ionic/ionic_osdep.h:48:17: error: two or more data types in declaration specifiers
>> typedef uint8_t bool;
>> ^
>> In file included from .../dpdk/drivers/net/ionic/ionic_dev.h:8:0,
>> from .../dpdk/drivers/net/ionic/ionic.h:13,
>> from .../dpdk/drivers/net/ionic/ionic_mac_api.h:8,
>> from .../dpdk/drivers/net/ionic/ionic_rxtx.c:45:
>> .../dpdk/drivers/net/ionic/ionic_osdep.h:48:1: warning: useless type name in empty declaration
>> typedef uint8_t bool;
>> ^~~~~~~
>> cc1: warning: unrecognized command line option ‘-Wno-address-of-packed-member’
>> .../dpdk/mk/internal/rte.compile-pre.mk:114: recipe for target 'ionic_rxtx.o' failed
>>
>> Fixes: 5ef518098ec6 ("net/ionic: register and initialize adapter")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
>
> Hi Alfredo,
>
> Do you have any concern/objection on the patch? If not it will be merged soon.
>
> Thanks,
> ferruh
>
Hi Ferruh
it looks fine, please go ahead.
Thank you
Alfredo
next prev parent reply other threads:[~2020-03-10 15:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-09 7:53 [dpdk-dev] [PATCH v2 " Sunil Kumar Kori
2020-03-09 8:16 ` Jerin Jacob
2020-03-09 8:43 ` Ferruh Yigit
2020-03-09 9:10 ` [dpdk-dev] [EXT] " Sunil Kumar Kori
2020-03-09 9:09 ` [dpdk-dev] [PATCH v3 " Sunil Kumar Kori
2020-03-10 15:21 ` Ferruh Yigit
2020-03-10 15:31 ` Alfredo Cardigliano [this message]
2020-03-10 17:10 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0809A9C0-612D-4366-9F11-D1917F744F78@ntop.org \
--to=cardigliano@ntop.org \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=skori@marvell.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).