From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id C63E11B4F1 for ; Thu, 2 Aug 2018 20:27:49 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C70CB8198B00; Thu, 2 Aug 2018 18:27:48 +0000 (UTC) Received: from ktraynor.remote.csb (ovpn-117-113.ams2.redhat.com [10.36.117.113]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5C6B27C45; Thu, 2 Aug 2018 18:27:47 +0000 (UTC) To: Andrew Rybchenko , Thomas Monjalon Cc: dev@dpdk.org, Ferruh Yigit , Stephen Hemminger References: <1533213223-24028-1-git-send-email-ktraynor@redhat.com> <00c35ad3-e063-b14e-ef56-e4308ec83f52@solarflare.com> <581602cf-36ba-2d6f-03ab-b00e9817f2a8@redhat.com> <7727240.AGfPpAcRVp@xps> From: Kevin Traynor Organization: Red Hat Message-ID: <080a3e26-121f-daf9-85f8-927d2cd6e8ba@redhat.com> Date: Thu, 2 Aug 2018 19:27:46 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Thu, 02 Aug 2018 18:27:48 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Thu, 02 Aug 2018 18:27:48 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'ktraynor@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] [PATCH] ethdev: decrease log level for successful API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Aug 2018 18:27:50 -0000 On 08/02/2018 07:01 PM, Andrew Rybchenko wrote: > On 02.08.2018 19:14, Thomas Monjalon wrote: >> 02/08/2018 16:52, Kevin Traynor: >>> On 08/02/2018 03:41 PM, Andrew Rybchenko wrote: >>>> On 02.08.2018 17:09, Kevin Traynor wrote: >>>>> On 08/02/2018 02:52 PM, Andrew Rybchenko wrote: >>>>>> On 02.08.2018 16:35, Kevin Traynor wrote: >>>>>>> On 08/02/2018 01:59 PM, Andrew Rybchenko wrote: >>>>>>>> On 02.08.2018 15:33, Kevin Traynor wrote: >>>>>>>>> @@ -1319,5 +1319,5 @@ struct rte_eth_dev * >>>>>>>>> if (dev->data->dev_started == 0) { >>>>>>>>> - RTE_ETHDEV_LOG(ERR, >>>>>>>>> + RTE_ETHDEV_LOG(DEBUG, >>>>>>>>> "Device with port_id=%"PRIu16" already >>>>>>>>> stopped\n", >>>>>>>>> port_id); >>>>>>>> I would suggest to use WARNING here. Yes, it is not an error since >>>>>>>> nothing bad has >>>>>>>> happened and we handle duplicate stop and duplicate start, >>>>>>>> but I think it is bad that (buggy?) application does it. Making it >>>>>>>> debug >>>>>>>> we simply >>>>>>>> hide it too much. >>>>>>>> >>>>>>> I think an application following the documented API is not bad or >>>>>>> buggy. >>>>>> I've failed to find the place were it is documented that device/queue >>>>>> may be stopped/started twice. Could you point out? >>>>>> Yes, return value 0 means success, but it is a separate thing. >>>>>> >>>>> I was commenting directly on the API and it's documentation e.g. below >>>>> for dev start. I'm not aware of other documentation specifying how it >>>>> can/cannot be called. >>>> I would not say so. "0: Success. Ethernet device started" means that >>>> function managed to do the job and finally the device is started. >>>> >>>> Never-mind it is not that important and already paid to much attention. >>>> I've included in CC other ethdev maintainers (who should be there from >>>> the very beginning). I don't mind if it is acked by other ethdev >>>> maintainer >>>> and applied. It is definitely not an error as it is now. Thanks. >>>> >>> Sure, sounds good - I'm glad we agree on something :-) I'll leave it for >>> a day and can re-spin tomorrow. >> I would like to give an opinion, but unfortunately it's hard to decide. >> For sure, it should not be a WARNING level (used for non-fatal errors). >> What else do we have? NOTICE, INFO and DEBUG. >> I think it can be INFO. > > So, we have ERR (now), WARNING (my initial suggestion), NOTICE > (by Stephen), INFO (by Thomas) and DEBUG (by Kevin) :) > Well, we completed the set :-) > If it is not treated as an error in application behaviour, I agree that my > suggestion of WARNING is not suitable. Typically NOTICE is the default > log level and if we consider such behaviour of apps correct, it should > be INFO to be silent by default. I really don't like DEBUG since these > messages are still important and could be simply lost in DEBUG > which could to be very-very verbose. ok, I'll update and send as INFO before someone suggests adding new log levels to choose from.